functional test: correctly detect nonstd TRUC tx vsize in feature_taproot #32859

1. 
   instagibbs commented at 3:05 pm on July 2, 2025: member

   Resolves #32841 (review)
2. 
   DrahtBot commented at 3:06 pm on July 2, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32859.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	darosior, w0xlt, davidgumberg, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. in test/functional/feature_taproot.py:1543 in b7e137ec61 outdated

   1538@@ -1538,7 +1539,8 @@ def test_spenders(self, node, spenders, input_counts):
   1539                 is_standard_tx = (
   1540                     fail_input is None  # Must be valid to be standard
   1541                     and (all(utxo.spender.is_standard for utxo in input_utxos))  # All inputs must be standard
   1542-                    and tx.version in TX_STANDARD_VERSIONS)  # The tx version must be standard
   1543+                    and tx.version in TX_STANDARD_VERSIONS # The tx version must be standard
   1544+                    and not (tx.version == 3 and tx.get_vsize() > TRUC_MAX_VSIZE))  # And any additional topological standardness rules followed
   

   ---

   ---

   

   maflcko commented at 3:13 pm on July 2, 2025:

   0                    and not (tx.version == 3 and tx.get_vsize() > TRUC_MAX_VSIZE)  # Topological standardness rules must be followed
   1                )
   

   nit: Could move the ) on the next line, to avoid having to touch the line again next time a rule is added below?

   ---

   

   instagibbs commented at 3:24 pm on July 2, 2025:

   taken, thanks
4. maflcko approved
5. 
   maflcko commented at 3:13 pm on July 2, 2025: member

   lgtm
6. functional test: correctly detect nonstd TRUC tx vsize in feature_taproot f0524cda39
7. instagibbs force-pushed on Jul 2, 2025
8. fanquake requested review from darosior on Jul 2, 2025
9. darosior approved
10. 
    darosior commented at 4:36 pm on July 2, 2025: member

    utACK f0524cda3995cf65adab3d0ca8da0dee4e31c79b
11. 
    w0xlt commented at 5:04 pm on July 2, 2025: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/32859/commits/f0524cda3995cf65adab3d0ca8da0dee4e31c79b
12. 
    davidgumberg commented at 10:54 pm on July 2, 2025: contributor

    utACK https://github.com/bitcoin/bitcoin/commit/f0524cda3995cf65adab3d0ca8da0dee4e31c79b
13. 
    achow101 commented at 10:55 pm on July 2, 2025: member

    ACK f0524cda3995cf65adab3d0ca8da0dee4e31c79b
14. achow101 merged this on Jul 2, 2025
15. achow101 closed this on Jul 2, 2025

    ---

Contributors
instagibbs DrahtBot maflcko darosior w0xlt davidgumberg achow101