Backports
[29.x] Backports #32863
pull fanquake wants to merge 15 commits into bitcoin:29.x from fanquake:probably_final_29_backports changing 21 files +249 −64-
fanquake commented at 11:08 am on July 3, 2025: member
-
test: check P2SH sigop count for coinbase tx
Github-Pull: #32850 Rebased-From: d6aaffcb11adcf47480fcc5081af9dcb732decf3
-
test: Clarify roles in outbound eviction comments
Some ambiguous uses of "we" referring to either the node or the peer are replaced with clearer phrasing. Also rephrase some comments for consistency and readability. Applies to all relevant outbound eviction tests in p2p_eviction_logic.py. Github-Pull: #32823 Rebased-From: 26598ed21ea7228c4ecf85da24527c88f9c1f1c1
-
test: Use rehash() in outbound eviction block-relay
Ensure that tip_header.rehash() is used instead of tip_header.hash, which is None when the header is deserialized from hex. This avoids depending on wait_for_getheaders() falling back to any received message, making the test more explicit and robust. Github-Pull: #32823 Rebased-From: ec004cdb86e6471915e1033f390c76ee0428e415
-
depends: Override host compilers for FreeBSD and OpenBSD
When building depends on FreeBSD/OpenBSD `aarch64`, the host compilers default to `default_host_{CC,CXX}`, which resolves to `gcc`/`g++`. This is incorrect on these systems, where Clang is the default system compiler. Github-Pull: #32716 Rebased-From: 4f10a57671c19cacca630b2401e42a213aacff1b
-
feature_taproot: sample tx version border values more
Currently if the version 3 is selected for an otherwise standard spender, the test will fail. It's unlikely but possible, so change the test to update expectations and sample more aggressively on border values to instigate failures much quicker in the future if another version is made standard. Github-Pull: #32841 Rebased-From: 4be81e9746e9e18923386d6f4945a33885fd98a7
-
functional test: correctly detect nonstd TRUC tx vsize in feature_taproot
Github-Pull: #32859 Rebased-From: f0524cda3995cf65adab3d0ca8da0dee4e31c79b
-
fanquake added this to the milestone 29.1 on Jul 3, 2025
-
DrahtBot added the label Backport on Jul 3, 2025
-
DrahtBot commented at 11:08 am on July 3, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32863.
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
LLM Linter (✨ experimental)
Possible typos and grammar issues:
- defintions -> definitions [spelling error]
drahtbot_id_4_m
-
DrahtBot added the label CI failed on Jul 3, 2025
-
DrahtBot removed the label CI failed on Jul 3, 2025
-
doc: Add workaround for vcpkg issue with paths with embedded spaces
Github-Pull: #32858 Rebased-From: 0a1af4418ed2a135001cc0e10f0af44cbd64e521
-
fanquake force-pushed on Jul 3, 2025
-
doc: clarify that the "-j N" goes after the "--build build" part
Also, capitalized the comments in build-unix.md for uniformity with the docs on other targets. Github-Pull: #32846 Rebased-From: 0e9f409db3b7b08aef75ce39765b018b69cc8e9d
-
fanquake force-pushed on Jul 3, 2025
-
test: fix incorrect subtest in `feature_fee_estimation.py`
- Update `check_smart_estimates` to calculate the fee rate ceiling by taking the maximum of fees seen, minrelaytxfee, and mempoolminfee. - Improve the subtest name and comments. Github-Pull: #32463 Rebased-From: 5c1236f04a24716b2cbd9b9b283863d3a8a6fa87
-
test: retain the intended behavior of `feature_fee_estimation.py` nodes
- Increase block weight by 4000 for all nodes with custom -blockmaxweight. Prior to this commit, we generated blocks with 4000 weight units less worth of transactions. See https://github.com/bitcoin/bitcoin/issues/32461#issuecomment-2925282272 for details. This commit fixes it by increasing the block weight by 4000. Github-Pull: #32463 Rebased-From: 9b75cfda4d62a0a3bde402503244dd57e1621a12
-
fanquake force-pushed on Jul 4, 2025
-
add more bad p2p ports
Github-Pull: #32826 Rebased-From: 6967e8e8abbc35ac98e8e3745a8bbed56e77526f
-
fanquake force-pushed on Jul 4, 2025
-
DrahtBot added the label CI failed on Jul 4, 2025
-
DrahtBot removed the label CI failed on Jul 7, 2025
-
fanquake marked this as ready for review on Jul 7, 2025
-
depends: Force `CMAKE_EXPORT_NO_PACKAGE_REGISTRY=TRUE`
When using CMake policies 3.14 and below, the `export(PACKAGE)` command by default populates the user package registry, which is stored outside the build tree. Setting the `CMAKE_EXPORT_NO_PACKAGE_REGISTRY` variable disables this side effect. In CMake 3.15 and later, this behavior is disabled by default, and the variable has no effect. Github-Pull: #32943 Rebased-From: 44f3bae300dcafbe53f9b07e6cc22a112833e579
-
fanquake force-pushed on Jul 14, 2025
-
cmake: Drop no longer necessary "cmakeMinimumRequired" object
Github-Pull: #32954 Rebased-From: 12a6959892cb24b940b3579828f2066651572153
-
depends: fix libevent _WIN32_WINNT usage
Starting with version 13.x, the mingw headers will define the value of NTDDI_VERSION, based on the value of _WIN32_WINNT, if that version is < Windows 10. Given that libevent was undefining our _WIN32_WINNT, and redefining it to a value < Windows 10 (0x0501), NTDDI_VERSION was also being defined to that value, leading to functions not being exposed in the mingw-w64 headers; see here: https://github.com/mingw-w64/mingw-w64/blob/9c2668ef77e75ea4d8a6c7d100b14643269caec3/mingw-w64-headers/include/iphlpapi.h#L36-L41. Imports a commit from usptream (a14ff91254f40cf36e0fee199e26fb11260fab49). Fixes #32707. Github-Pull: #32837 Rebased-From: f5647c6c5ae85e9469cfc5df6fcac23752e1695a
-
doc: update release notes for 29.x 5300295083
-
fanquake force-pushed on Jul 16, 2025
-
hebasto approved
-
glozow commented at 5:25 pm on July 18, 2025: memberACK 5300295083f2e199c22a7ad55e62a8dc7549a76e
-
glozow merged this on Jul 18, 2025
-
glozow closed this on Jul 18, 2025
-
fanquake deleted the branch on Jul 19, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-26 21:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-26 21:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me