rest: replace rf_names[0].rf by RESTResponseFormat::UNDEF #32884

pull eval-exec wants to merge 1 commits into bitcoin:master from eval-exec:exec/rest-ParseDataFormat-improve changing 1 files +2 −2
  1. eval-exec commented at 3:22 am on July 6, 2025: contributor
    I’m reviewing the bitcoin’s rest.cpp source code. In the function: ParseDataFormat, rf_names[0].rf is actualy RESTResponseFormat::UNDEF: https://github.com/bitcoin/bitcoin/blob/e3f416dbf7633b2fb19c933e5508bd231cc7e9cf/src/rest.cpp#L48-L57 so it would be more clarity and code readability to use return RESTResponseFormat::UNDEF; to replace return rf_names[0].rf;
  2. rest: replace `rf_names[0].rf` by `RESTResponseFormat::UNDEF` for code clarity 6d19815cd4
  3. DrahtBot added the label RPC/REST/ZMQ on Jul 6, 2025
  4. DrahtBot commented at 3:22 am on July 6, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32884.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, brunoerg

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. eval-exec commented at 8:03 am on July 7, 2025: contributor
    Friendly request @fanquake to review this PR.
  6. maflcko commented at 10:09 am on July 8, 2025: member
    lgtm ACK 6d19815cd44031ff2b45fc9532f579cd81c62749
  7. brunoerg approved
  8. brunoerg commented at 2:34 pm on July 8, 2025: contributor
    code review ACK 6d19815cd44031ff2b45fc9532f579cd81c62749
  9. fanquake renamed this:
    rest: replace `rf_names[0].rf` by `RESTResponseFormat::UNDEF` for code clarity
    rest: replace `rf_names[0].rf` by `RESTResponseFormat::UNDEF`
    on Jul 8, 2025
  10. fanquake merged this on Jul 8, 2025
  11. fanquake closed this on Jul 8, 2025

  12. stickies-v commented at 5:33 pm on July 10, 2025: contributor

    post-merge ACK 6d19815cd44031ff2b45fc9532f579cd81c62749

    Looking at this code inspired me to make some related modernizations to the rf_names code: https://github.com/bitcoin/bitcoin/pull/32942


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-02 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me