I'm reviewing the bitcoin's rest.cpp source code.
In the function: ParseDataFormat, rf_names[0].rf is actualy RESTResponseFormat::UNDEF:
https://github.com/bitcoin/bitcoin/blob/e3f416dbf7633b2fb19c933e5508bd231cc7e9cf/src/rest.cpp#L48-L57
so it would be more clarity and code readability to use return RESTResponseFormat::UNDEF; to replace return rf_names[0].rf;
rest: replace `rf_names[0].rf` by `RESTResponseFormat::UNDEF` #32884
pull eval-exec wants to merge 1 commits into bitcoin:master from eval-exec:exec/rest-ParseDataFormat-improve changing 1 files +2 −2-
eval-exec commented at 3:22 AM on July 6, 2025: contributor
-
rest: replace `rf_names[0].rf` by `RESTResponseFormat::UNDEF` for code clarity 6d19815cd4
- DrahtBot added the label RPC/REST/ZMQ on Jul 6, 2025
-
DrahtBot commented at 3:22 AM on July 6, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32884.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
-
maflcko commented at 10:09 AM on July 8, 2025: member
lgtm ACK 6d19815cd44031ff2b45fc9532f579cd81c62749
- brunoerg approved
-
brunoerg commented at 2:34 PM on July 8, 2025: contributor
code review ACK 6d19815cd44031ff2b45fc9532f579cd81c62749
- fanquake renamed this:
rest: replace `rf_names[0].rf` by `RESTResponseFormat::UNDEF` for code clarity
rest: replace `rf_names[0].rf` by `RESTResponseFormat::UNDEF`
on Jul 8, 2025 - fanquake merged this on Jul 8, 2025
- fanquake closed this on Jul 8, 2025
-
stickies-v commented at 5:33 PM on July 10, 2025: contributor
post-merge ACK 6d19815cd44031ff2b45fc9532f579cd81c62749
Looking at this code inspired me to make some related modernizations to the
rf_namescode: https://github.com/bitcoin/bitcoin/pull/32942 - stringintech referenced this in commit f19e7819e9 on Jul 19, 2025
- alexanderwiederin referenced this in commit 9997c3d993 on Jul 25, 2025
- alexanderwiederin referenced this in commit 8d6ebb9c4e on Jul 28, 2025
- alexanderwiederin referenced this in commit 533a4585b5 on Jul 28, 2025
- yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
- bug-castercv502 referenced this in commit d4bd8a1259 on Sep 28, 2025
- stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025
- Kino1994 referenced this in commit 01ce3733ab on Jun 28, 2026
- BigcoinBGC referenced this in commit f4cb1867ae on Jun 30, 2026
- bitcoin locked this on Jul 30, 2026
Contributors
Labels