test: Add missing convert_to_json_for_cli #32932

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2507-test-fix-cli changing 1 files +2 −2
  1. maflcko commented at 9:00 am on July 10, 2025: member

    Currently the tests are failing on current master, if they use the --usecli flag. See https://github.com/bitcoin/bitcoin/runs/45676472375, https://cirrus-ci.com/task/5707897310543872.

    This can be reproduced locally via:

    0./bld-cmake/test/functional/wallet_reorgsrestore.py --usecli
    

    Fix it by adding the missing hash_or_height=self.convert_to_json_for_cli(tip) for the value that could either be a string (needs quotes in json), or a number (does not need quotes in json).

  2. test: Add missing convert_to_json_for_cli fa0528479d
  3. DrahtBot added the label Tests on Jul 10, 2025
  4. DrahtBot commented at 9:00 am on July 10, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32932.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. maflcko added this to the milestone 30.0 on Jul 10, 2025
  6. fanquake approved
  7. fanquake commented at 10:03 am on July 10, 2025: member
    ACK fa0528479d5e37833fa66395c94d4611aa9270f6
  8. fanquake merged this on Jul 10, 2025
  9. fanquake closed this on Jul 10, 2025

  10. maflcko deleted the branch on Jul 10, 2025


maflcko DrahtBot fanquake

Labels
Tests

Milestone
30.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-11 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me