test: Add missing convert_to_json_for_cli #32932

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2507-test-fix-cli changing 1 files +2 −2
  1. maflcko commented at 9:00 AM on July 10, 2025: member

    Currently the tests are failing on current master, if they use the --usecli flag. See https://github.com/bitcoin/bitcoin/runs/45676472375, https://cirrus-ci.com/task/5707897310543872.

    This can be reproduced locally via:

    ./bld-cmake/test/functional/wallet_reorgsrestore.py --usecli
    

    Fix it by adding the missing hash_or_height=self.convert_to_json_for_cli(tip) for the value that could either be a string (needs quotes in json), or a number (does not need quotes in json).

  2. test: Add missing convert_to_json_for_cli fa0528479d
  3. DrahtBot added the label Tests on Jul 10, 2025
  4. DrahtBot commented at 9:00 AM on July 10, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32932.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. maflcko added this to the milestone 30.0 on Jul 10, 2025
  6. fanquake approved
  7. fanquake commented at 10:03 AM on July 10, 2025: member

    ACK fa0528479d5e37833fa66395c94d4611aa9270f6

  8. fanquake merged this on Jul 10, 2025
  9. fanquake closed this on Jul 10, 2025

  10. maflcko deleted the branch on Jul 10, 2025
  11. stringintech referenced this in commit f19e7819e9 on Jul 19, 2025
  12. alexanderwiederin referenced this in commit 9997c3d993 on Jul 25, 2025
  13. alexanderwiederin referenced this in commit 8d6ebb9c4e on Jul 28, 2025
  14. alexanderwiederin referenced this in commit 533a4585b5 on Jul 28, 2025
  15. yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
  16. bug-castercv502 referenced this in commit d4bd8a1259 on Sep 28, 2025
  17. stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025
  18. Kino1994 referenced this in commit de2d1817d4 on Jun 28, 2026
  19. BigcoinBGC referenced this in commit 61fa616979 on Jun 30, 2026
  20. bitcoin locked this on Jul 30, 2026
Labels

Milestone
30.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-04 00:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me