cmake: Use newer signature of `qt6_add_lrelease` when available #32940

hebasto commented at 3:47 PM on July 10, 2025: member

See Qt docs here: https://doc.qt.io/qt-6/qtlinguist-cmake-qt-add-lrelease.html.

Fixes #32710.

cmake: Use newer signature of `qt6_add_lrelease` when available 94931656b5

hebasto added the label Build system on Jul 10, 2025

DrahtBot commented at 3:47 PM on July 10, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32940.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto commented at 10:19 AM on July 11, 2025: member

My Guix build:

aarch64
9a9cd30b66d0c150c6e843a37b89cdbae284e0e7c2829d7d6c64076453d4be1f  guix-build-94931656b52f/output/aarch64-linux-gnu/SHA256SUMS.part
e7525f1c1cf720f53a292b404ccd63ca792631c14587a1a34978b33d35c4fece  guix-build-94931656b52f/output/aarch64-linux-gnu/bitcoin-94931656b52f-aarch64-linux-gnu-debug.tar.gz
231c4e16929291d5d6edf1d3bf0c0ba2f9fda5a11586941a92f256f6bd1067c7  guix-build-94931656b52f/output/aarch64-linux-gnu/bitcoin-94931656b52f-aarch64-linux-gnu.tar.gz
f965bfc13e7a57276ed660e7d8cbcaa7b1f3073524221dc450984bafe6c2571b  guix-build-94931656b52f/output/arm-linux-gnueabihf/SHA256SUMS.part
414e1b45c4a3de05ed7ab5224a797e890f2eb9ab40cc25e8cf4911329378b0b6  guix-build-94931656b52f/output/arm-linux-gnueabihf/bitcoin-94931656b52f-arm-linux-gnueabihf-debug.tar.gz
daff1ce1fe7c35a438615aebea93d9ca6e5814bbb626fecc72916e9468a178f6  guix-build-94931656b52f/output/arm-linux-gnueabihf/bitcoin-94931656b52f-arm-linux-gnueabihf.tar.gz
a4dc03fe537d246abfead819f5cb517084a2836c60972d449a48118953925901  guix-build-94931656b52f/output/arm64-apple-darwin/SHA256SUMS.part
91ab09afa6f31e1d4d7cca85efc3fa3d78dce39a852d0c4cea4a90533b2dd3f3  guix-build-94931656b52f/output/arm64-apple-darwin/bitcoin-94931656b52f-arm64-apple-darwin-codesigning.tar.gz
00069f7a66965c935d22d13de6a59aa5162e60629dff604861b10c3a14b2edac  guix-build-94931656b52f/output/arm64-apple-darwin/bitcoin-94931656b52f-arm64-apple-darwin-unsigned.tar.gz
dbb3a6038fb24b7ccb0f6cc93adccc590a97c425fb15e658eb3dabc49e9ee98d  guix-build-94931656b52f/output/arm64-apple-darwin/bitcoin-94931656b52f-arm64-apple-darwin-unsigned.zip
0fe324525691bfba464edaf9c895cce2e784da915576f3575be33f326055f2fb  guix-build-94931656b52f/output/dist-archive/bitcoin-94931656b52f.tar.gz
2954b42e53355624d99f087b217856c526765845a7e36806dc8d125fd22a1aee  guix-build-94931656b52f/output/powerpc64-linux-gnu/SHA256SUMS.part
efa7747e51e5c7299e31771e70c6aba5260f568aa815b69f083687abfa70d476  guix-build-94931656b52f/output/powerpc64-linux-gnu/bitcoin-94931656b52f-powerpc64-linux-gnu-debug.tar.gz
59f94863afe636f7d9bf8b329243b89fe1abb2b711350afa3a6055a3555544e2  guix-build-94931656b52f/output/powerpc64-linux-gnu/bitcoin-94931656b52f-powerpc64-linux-gnu.tar.gz
1fcf070e5306eb99ef35470927063ce9990a9cf36176c1ad879772ed6450ada3  guix-build-94931656b52f/output/riscv64-linux-gnu/SHA256SUMS.part
b43e8509991afd9f1842930dcaca21fced6aa36bd36d956d2160558d899431aa  guix-build-94931656b52f/output/riscv64-linux-gnu/bitcoin-94931656b52f-riscv64-linux-gnu-debug.tar.gz
17ed1d821725d524e0aa27d9b5d4ff45e87d83f64d18c7a468015425a90c6000  guix-build-94931656b52f/output/riscv64-linux-gnu/bitcoin-94931656b52f-riscv64-linux-gnu.tar.gz
ba1428c418f002a7570e371c58b9fbb6b63eb775ee2bbe4265912b1941ac0079  guix-build-94931656b52f/output/x86_64-apple-darwin/SHA256SUMS.part
02c74abec6dcf25d0f40e4eefdb23bbe967c6ea37586d70d3b86350cf1d97600  guix-build-94931656b52f/output/x86_64-apple-darwin/bitcoin-94931656b52f-x86_64-apple-darwin-codesigning.tar.gz
a8d131febfea3def13ccd47f9186c9f5392103d0da7cafcf173fd212fa709926  guix-build-94931656b52f/output/x86_64-apple-darwin/bitcoin-94931656b52f-x86_64-apple-darwin-unsigned.tar.gz
f65d923c879eaca7b398b4674ef893b8ffbba3e9e2f518e72f19f2b41be0f943  guix-build-94931656b52f/output/x86_64-apple-darwin/bitcoin-94931656b52f-x86_64-apple-darwin-unsigned.zip
f264e2f36ca7d322c1f3813d023e578f4ef24c914fcdc069dffd785ba0b25253  guix-build-94931656b52f/output/x86_64-linux-gnu/SHA256SUMS.part
77d8d8a837578eaf591044cac6324ffe82f860bf6c0793f32b6bfddb017c6b21  guix-build-94931656b52f/output/x86_64-linux-gnu/bitcoin-94931656b52f-x86_64-linux-gnu-debug.tar.gz
88927145ce621e432a242454b58cb599c783602d020d3051f9f70153c1a11aac  guix-build-94931656b52f/output/x86_64-linux-gnu/bitcoin-94931656b52f-x86_64-linux-gnu.tar.gz
4591bdd94369570ad6dbb553dd50affe008ec9b4da2ebd711d6de58957d00523  guix-build-94931656b52f/output/x86_64-w64-mingw32/SHA256SUMS.part
32491ad141bb001e33a5a5f39fe63122ffea67ddfb7452ba7defdb67a42abadd  guix-build-94931656b52f/output/x86_64-w64-mingw32/bitcoin-94931656b52f-win64-codesigning.tar.gz
37d75223f5b0739a679af6ab9f6e3ceba79c8253afd88d39ece9b745fc3b52ac  guix-build-94931656b52f/output/x86_64-w64-mingw32/bitcoin-94931656b52f-win64-debug.zip
44ea00451980b4bde16c3eb3cf96822e73160759c1dc639089291b8d9dea588e  guix-build-94931656b52f/output/x86_64-w64-mingw32/bitcoin-94931656b52f-win64-setup-unsigned.exe
192c0594421e8c8e7a397d9990d87fb9ae06d827bb08106551822ed3acfb5b9e  guix-build-94931656b52f/output/x86_64-w64-mingw32/bitcoin-94931656b52f-win64-unsigned.zip

fanquake approved

fanquake commented at 1:22 PM on July 11, 2025: member

ACK 94931656b52fddb7c03b29685844d85c008cf6ca

fanquake merged this on Jul 11, 2025

fanquake closed this on Jul 11, 2025

hebasto deleted the branch on Jul 11, 2025

stringintech referenced this in commit f19e7819e9 on Jul 19, 2025

alexanderwiederin referenced this in commit 9997c3d993 on Jul 25, 2025

alexanderwiederin referenced this in commit 8d6ebb9c4e on Jul 28, 2025

alexanderwiederin referenced this in commit 533a4585b5 on Jul 28, 2025

yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025

bug-castercv502 referenced this in commit d4bd8a1259 on Sep 28, 2025

stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025

luke-jr referenced this in commit 8819931d2b on Feb 5, 2026

kwsantiago referenced this in commit 4ceed15338 on Feb 16, 2026

Kino1994 referenced this in commit 9ce373446d on Jun 28, 2026

BigcoinBGC referenced this in commit 0c9565875f on Jun 30, 2026

bitcoin locked this on Jul 30, 2026