ci: Use APT_LLVM_V in msan task #32999

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2507-msan-ci-apt changing 5 files +32 −22
  1. maflcko commented at 7:57 AM on July 17, 2025: member

    This skips compilation of clang by using the apt.

  2. DrahtBot added the label Tests on Jul 17, 2025
  3. DrahtBot commented at 7:58 AM on July 17, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32999.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK willcl-ark, m3dwards

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. DrahtBot added the label CI failed on Jul 17, 2025
  5. in ci/test/01_base_install.sh:62 in bfdda06fa7 outdated 
      72 | -  update-alternatives --install /usr/bin/clang clang /msan/clang_build/bin/clang 100
  73 | -  update-alternatives --install /usr/bin/llvm-symbolizer llvm-symbolizer /msan/clang_build/bin/llvm-symbolizer 100
  74 | +  if [ -n "${APT_LLVM_V}" ]; then
  75 | +    ${CI_RETRY_EXE} git clone --depth=1 https://github.com/llvm/llvm-project -b "llvmorg-20.1.7" /msan/llvm-project
  76 | +  else
  77 | +    ${CI_RETRY_EXE} git clone --depth=1 https://github.com/llvm/llvm-project -b "llvmorg-20.1.0" /msan/llvm-project
    fanquake commented at 8:54 AM on July 17, 2025:

    .8 while touching?

    fanquake commented at 9:02 AM on July 17, 2025:

    Actually, I'm wondering why these can't both be 20.1.8? If the checkout needs to match the apt version, then its going to break whenever the apt is updated but this isn't bumped.

    maflcko commented at 9:22 AM on July 17, 2025:

    There shouldn't be any breaking changes in minor versions, so anything is probably fine here. However, if msan fuzz wants to use a different major version, it seems better to keep it separate?

    Maybe a follow-up can investigate if msan fuzz can bootstrap compiler-rt (libfuzzer) directly, and remove all of this code here.

    however, my guess is that you still need to compile at least libcxx(abi) in this this if-branch.

  6. ci: Use APT_LLVM_V in msan task
    Also, use update-alternatives to avoid having to manually specify
clang-${APT_LLVM_V} or llvm-symbolizer-${APT_LLVM_V} everywhere.
    fad040a578
  7. maflcko force-pushed on Jul 17, 2025
  8. maflcko marked this as ready for review on Jul 17, 2025
  9. maflcko removed the label CI failed on Jul 17, 2025
  10. willcl-ark approved
  11. willcl-ark commented at 2:15 PM on July 17, 2025: member

    ACK fad040a5787a8ac0a13aef5c54e5a675de239e92

    Code changes look correct to me.

    In the CI run this installed clang-20.1.7 from apt, before cloning https://github.com/llvm/llvm-project -b llvmorg-20.1.7 and building the llvm runtimes with msan enabled.

    nit: I do notice that bitcoin configure output claims it's using clang from /bin/clang++ which differs from the update-alternatives dir used: /usr/bin/clang++, but it appears to be the correct version so I guess it's an apt install symlink?:

    C++ compiler .......................... Clang 20.1.7, /bin/clang++
  12. maflcko commented at 2:24 PM on July 17, 2025: member

    bin

    It is a symlink:

    # podman run --rm   'ubuntu:questing' ls -ld /bin 
lrwxrwxrwx 1 root root 7 Apr 24 16:59 /bin -> usr/bin
  13. m3dwards commented at 5:03 PM on July 18, 2025: contributor

    ACK fad040a5787a8ac0a13aef5c54e5a675de239e92

    This will cut down on the msan job run time a lot when the docker build cache is empty.

  14. fanquake commented at 10:45 AM on July 21, 2025: member

    Should probably adjust the timeout / comment: https://github.com/bitcoin/bitcoin/blob/5878f35446ae260ccb0ab5051b795b4364f77951/.cirrus.yml#L160 but given it's being moved in #32989, left a note there.

  15. fanquake merged this on Jul 21, 2025
  16. fanquake closed this on Jul 21, 2025
  17. maflcko deleted the branch on Jul 24, 2025
  18. sedited referenced this in commit 02ded863ba on Jul 28, 2025
  19. sedited referenced this in commit 52d7f32bd6 on Jul 28, 2025
  20. alexanderwiederin referenced this in commit 28fe919bf7 on Aug 6, 2025
  21. sedited referenced this in commit b98d982d79 on Aug 7, 2025
  22. alexanderwiederin referenced this in commit 4152176d02 on Aug 8, 2025
  23. alexanderwiederin referenced this in commit 9ef94c31db on Aug 8, 2025
  24. stringintech referenced this in commit 71275a1b5e on Aug 17, 2025
  25. yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
  26. fanquake referenced this in commit 10cbf2255d on Sep 3, 2025
  27. fanquake referenced this in commit a0e438bd49 on Sep 8, 2025
  28. bug-castercv502 referenced this in commit 4aa5572aea on Sep 28, 2025
  29. stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025
  30. morozow referenced this in commit 78ac51b1bb on May 8, 2026
  31. morozow referenced this in commit 01440f0ced on May 8, 2026
  32. Kino1994 referenced this in commit 4dbf0d8992 on Jun 28, 2026
  33. BigcoinBGC referenced this in commit ca789f334d on Jun 30, 2026
  34. bitcoin locked this on Jul 30, 2026
Contributors
maflckoDrahtBotfanquakewillcl-arkm3dwards
Labels
Tests
Linked (view graph)
#33294 [29.x] *san CI backports
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-01 17:51 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me