This contains four commits from #28792 that can be easily reviewed and merged independently. I hope splitting this change off can make this part move a bit faster and reduce frequency of needed rebases for #28792.
The commits in order:
- Add additional unit test vectors to the asmap interpreter (written by sipa). This helps to ensure that the further refactors in #28792 don’t change behavior.
- Modernizes the logging in
util/asmap.cpp
, I added this while touching the rest of the file all over anyway. - Fixes the behavior of the
GetPathArg
function when an path arg is given “1” (for example-asmap=1
), which would be interpreted as a path but should be interpreted as using the are without a parameter which activates the fallback. There is no explicit test added here because this is tested implicitly in the tests added in #28792. - Adds an
AutoFile::size
helper function