This is #27593 cleaned up / rebased, now that the legacy wallet has been dropped.
Closes #27593.
test: fix RPC coverage check #33064
pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:29387_rebased changing 3 files +6 −1-
fanquake commented at 2:02 PM on July 25, 2025: member
- DrahtBot added the label Tests on Jul 25, 2025
-
DrahtBot commented at 2:02 PM on July 25, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33064.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #31668 (Added rescan option for import descriptors by saikiran57)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- DrahtBot added the label CI failed on Jul 25, 2025
-
test: add abortrescan RPC test 2630b64f81
-
test: fix RPC coverage check 8aed477c33
- fanquake force-pushed on Jul 26, 2025
- fanquake marked this as ready for review on Jul 26, 2025
- DrahtBot removed the label CI failed on Jul 26, 2025
-
cedwies commented at 3:52 PM on July 27, 2025: none
Tested on MacOS 15.5 (Debug build).
- unit tests pass (0/143 failures)
- ./test/functional/wallet_transactiontime_rescan.py passes (11 s)
Question: would it make sense to also test "abortrescan" during an active rescan to hit the True path and ensure the scan halts as expected?
ACK 8aed477
-
maflcko commented at 8:41 AM on July 28, 2025: member
lgtm ACK 8aed477c3322212a636ab69d4923f89e2d9a63a2
-
fanquake commented at 9:40 AM on July 28, 2025: member
Question: would it make sense to also test "abortrescan" during an active rescan to hit the True path and ensure the scan halts as expected?
Feel free to open a new PR, adding additional test changes.
- fanquake merged this on Jul 28, 2025
- fanquake closed this on Jul 28, 2025
- fanquake deleted the branch on Jul 28, 2025
Labels