Backports:
[29.x] Backports #33074
pull fanquake wants to merge 8 commits into bitcoin:29.x from fanquake:29_rc_backports changing 10 files +62 −33-
fanquake commented at 9:30 am on July 28, 2025: member
-
doc/zmq: fix unix socket path example
Following https://github.com/bitcoin/bitcoin/blob/75a5c8258ec5309fe506438aa3815608430b53d6/doc/release-notes/release-notes-28.0.md?plain=1#L105 Github-Pull: #33070 Rebased-From: e83699a626b8a41c8fb9d0450e14e06a29a98bb8
-
fanquake added this to the milestone 29.1 on Jul 28, 2025
-
DrahtBot added the label Backport on Jul 28, 2025
-
DrahtBot commented at 9:30 am on July 28, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33074.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK glozow If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
tracing: fix pointer argument handling in mempool_monitor.py
The BPF code was incorrectly passing pointer variables by value to bpf_usdt_readarg(), causing the function to fail silently and resulting in transaction hashes and reason strings displaying as zeros or garbage. This fix adds the missing reference operator (&) when passing pointer variables to bpf_usdt_readarg(), allowing the function to properly write the pointer values and enabling correct display of transaction hashes and removal/rejection reasons. Fixes the regression introduced in ec47ba349d where bpf_usdt_readarg_p was replaced with bpf_usdt_readarg but the calling convention wasn't properly updated for pointer arguments. Github-Pull: #33086 Rebased-From: 0ce041ea88dbea2bdfaf21fd0e60a86012498f0a
-
fanquake force-pushed on Jul 29, 2025
-
guix: warn SOURCE_DATE_EPOCH set in guix-codesign
Currently there is a warning for this in guix-build, but we also need one in guix-codesign, otherwise the codesigned hashes are not reproducible. Move common functionality into prelude and call the function in both guix actions. Github-Pull: #33073 Rebased-From: 1bed0f734b3f2dd876193b5cad303bfab1d250d5
-
fanquake force-pushed on Jul 29, 2025
-
doc: Add rel note for breaking change in dumptxoutset RPC
This was missed in the v29.0 release notes.
-
fanquake force-pushed on Jul 30, 2025
-
doc: move `cmake -B build -LH` up in Unix build docs
Github-Pull: #33088 Rebased-From: 6757052fc439bedd1fa88ee1d23b4f17cf2c4f7a
-
fanquake force-pushed on Aug 3, 2025
-
rpc: fix getpeerinfo ping duration unit docs
The getpeerinfo docs incorrectly specified the ping durations as milliseconds. This was incorrectly changed in a3789c700b5a43efd4b366b4241ae840d63f2349 (released in v25; master since Sept. 2022). The correct duration unit is seconds. Also, remove the documentation of the getpeerinfo RPC response from the ping RPC since it's incomplete. Better to just reference the getpeerinfo RPC and it's documenation for this. Github-Pull: #33133 Rebased-From: 1252eeb997df2eb12c33d92eb1a5c9d6643a67ff
-
fanquake force-pushed on Aug 5, 2025
-
test: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify 'spend_vin' is the correct field
Github-Pull: #33119 Rebased-From: 3543bfdfec345cf2c952143c31674ef02de2a64b
-
doc: update release notes for 29.x b9e637bd0e
-
fanquake force-pushed on Aug 6, 2025
-
fanquake marked this as ready for review on Aug 7, 2025
-
glozow commented at 4:50 pm on August 7, 2025: member
ACK b9e637bd0ee4d1da5f587ec33cbed9ee28c07daf
Compared the backport, didn’t test
-
fanquake requested review from willcl-ark on Aug 13, 2025
-
fanquake merged this on Aug 15, 2025
-
fanquake closed this on Aug 15, 2025
-
fanquake deleted the branch on Aug 15, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-22 21:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-22 21:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me