rpc: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify fix #33119

pull Christewart wants to merge 1 commits into bitcoin:master from Christewart:2025-08-01-getdescriptoractivity-help-bug changing 2 files +2 −1

Christewart commented at 9:35 PM on August 1, 2025: contributor

Fixes bug in getdescriptoractivity RPC help manual.

Here is the line that pushes spend_vin field, there is no spend_vout json field.

https://github.com/bitcoin/bitcoin/blob/master/src/rpc/blockchain.cpp#L2757
DrahtBot added the label Docs on Aug 1, 2025
DrahtBot commented at 9:35 PM on August 1, 2025: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33119.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK nervana21, jonatack, luke-jr

Concept ACK Sammie05

Stale ACK pablomartin4btc

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
pablomartin4btc commented at 11:39 PM on August 1, 2025: member

cr ACK b17918d66743d6ee1cd2df7fd0a6c05dc87f71d8

Maybe you can add the field validation in rpc_getdescriptoractivity.py (ie test_receive_then_spend).
Sammie05 commented at 3:09 AM on August 2, 2025: none

Thanks for the fix, As mentioned above, adding a test for this in rpc_getdescriptoractivity.py would make the PR even more robust. ACK from me for this doc update
test: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify 'spend_vin' is the correct field 3543bfdfec
Christewart force-pushed on Aug 2, 2025
Christewart renamed this:
~~doc: Fix 'getdescriptoractivity' RPCHelpMan~~
test: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify fix
on Aug 2, 2025
Christewart commented at 3:27 PM on August 2, 2025: contributor

@pablomartin4btc @Sammie05 Done in 3543bfd
nervana21 commented at 6:29 PM on August 2, 2025: contributor

tACK 3543bfd
DrahtBot requested review from pablomartin4btc on Aug 2, 2025
jonatack commented at 9:20 PM on August 4, 2025: member

ACK 3543bfdfec345cf2c952143c31674ef02de2a64b

Suggest updating the PR title prefix from "test" to "rpc"
Christewart renamed this:
~~test: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify fix~~
rpc: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify fix
on Aug 4, 2025
luke-jr commented at 2:36 AM on August 5, 2025: member

utACK 3543bfdfec345cf2c952143c31674ef02de2a64b
luke-jr commented at 2:38 AM on August 5, 2025: member

The commit message should probably also be corrected (maybe "Docfix: RPC/blockchain: ..."?)
luke-jr referenced this in commit 44fcd33fcc on Aug 5, 2025
fanquake merged this on Aug 6, 2025
fanquake closed this on Aug 6, 2025
fanquake referenced this in commit 2b9738a083 on Aug 6, 2025
fanquake commented at 10:18 AM on August 6, 2025: member

Backported to 29.x in #33074.