The SECP256K1_DISABLE_SHARED
CMake variable has been removed upstream.
This PR removes its usage ahead of the next secp256k1
subtree update to prevent breakage and simplify integration.
SECP256K1_DISABLE_SHARED
#33101
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33101.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
APPEND_*FLAGS
variables early by hebasto)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Possible typos and grammar issues:
drahtbot_id_4_m
Nice. I’ve been wanting to scope the secp add_subdirectory
for a while now.
utACK d5d95035bc6ef135476d7f734c574b38d6faaf70. Reviewed with git diff --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change
The `SECP256K1_DISABLE_SHARED` CMake variable has been removed upstream.
This change removes its usage ahead of the next `secp256k1` subtree
update to prevent breakage and simplify integration.
Guix Build (aarch64):
01a4f3c804b729fdc5a3d4831239b6bd7e34e0ca9061395578dfce07ffa8ea1cf guix-build-b093a19ae2ef/output/aarch64-linux-gnu/SHA256SUMS.part
103563287d5fd2f87829e2569e2fc02e8e6c0f9dc3db22d196fe442b852b242f0 guix-build-b093a19ae2ef/output/aarch64-linux-gnu/bitcoin-b093a19ae2ef-aarch64-linux-gnu-debug.tar.gz
25aee57e7e430fe8c7d0214dcc5717a1e50992fa9a28252804658fe262d6cde0e guix-build-b093a19ae2ef/output/aarch64-linux-gnu/bitcoin-b093a19ae2ef-aarch64-linux-gnu.tar.gz
3d619695f4a0ce8b74a70a222f9c4ff3532b7eaf3e46b19bb585bc8d0a44d8fa4 guix-build-b093a19ae2ef/output/arm-linux-gnueabihf/SHA256SUMS.part
429444e50a63ff8971bd72b02a297740baf129de543ebe280f78462a0529d08a1 guix-build-b093a19ae2ef/output/arm-linux-gnueabihf/bitcoin-b093a19ae2ef-arm-linux-gnueabihf-debug.tar.gz
5ce3aa54f27cd02bd96cd52d13113f9e3e78c11f4eec20caa66273506065847c3 guix-build-b093a19ae2ef/output/arm-linux-gnueabihf/bitcoin-b093a19ae2ef-arm-linux-gnueabihf.tar.gz
6bfaa3a80d8078f46bf757e4e17794cf0371b7bcc3c7246b59d8d4d414bf2a25b guix-build-b093a19ae2ef/output/arm64-apple-darwin/SHA256SUMS.part
7b61c4b4638eec218f391af243790ccdbbcec61d668ab70082153167e3d5abc45 guix-build-b093a19ae2ef/output/arm64-apple-darwin/bitcoin-b093a19ae2ef-arm64-apple-darwin-codesigning.tar.gz
873bef894bfabbf69ff5802c96dcee4418d270c8a5a69f84f7a5aa614337107fe guix-build-b093a19ae2ef/output/arm64-apple-darwin/bitcoin-b093a19ae2ef-arm64-apple-darwin-unsigned.tar.gz
92b73a6354bfc746c7e8b34d35e1144c2e1ea0c5718146e4f879b03da65b033b4 guix-build-b093a19ae2ef/output/arm64-apple-darwin/bitcoin-b093a19ae2ef-arm64-apple-darwin-unsigned.zip
10f3fd8a9eaa640dd7532da6af1a2a81883f220d68c12313ff70a9292a81de979d guix-build-b093a19ae2ef/output/dist-archive/bitcoin-b093a19ae2ef.tar.gz
11b9e0fde4d6a3a37837206ead8687a1639498a080b48a7f7a2ce89094d9794631 guix-build-b093a19ae2ef/output/powerpc64-linux-gnu/SHA256SUMS.part
12d75ba692b6c55c69f8d52f70f68985dfc3ae9c6fa60fec3967fa2c18cfa3161f guix-build-b093a19ae2ef/output/powerpc64-linux-gnu/bitcoin-b093a19ae2ef-powerpc64-linux-gnu-debug.tar.gz
13b39303207f3a4cf54a79f76f655b02cf23b8f91f2b342885b4f622e9ab6245cc guix-build-b093a19ae2ef/output/powerpc64-linux-gnu/bitcoin-b093a19ae2ef-powerpc64-linux-gnu.tar.gz
1402e519b8825c089df62def0ebf33595323183b832fb466cccf885792558581aa guix-build-b093a19ae2ef/output/riscv64-linux-gnu/SHA256SUMS.part
1507ff752956fb318b1b9ea7851f300f7f8a38f0bf80aa4c5ab552a05daeb8b15e guix-build-b093a19ae2ef/output/riscv64-linux-gnu/bitcoin-b093a19ae2ef-riscv64-linux-gnu-debug.tar.gz
16b1da13582199184d860686150c382a83161230a58eafc7987372691b51933085 guix-build-b093a19ae2ef/output/riscv64-linux-gnu/bitcoin-b093a19ae2ef-riscv64-linux-gnu.tar.gz
1771b90a0e33269ee883058394c14037447762178b172f56e66c8b84fae5277dab guix-build-b093a19ae2ef/output/x86_64-apple-darwin/SHA256SUMS.part
187ea2e8214aaf42c8e4b63f6ab7ce5d69d347918b2bd4cd07761859ebc441c466 guix-build-b093a19ae2ef/output/x86_64-apple-darwin/bitcoin-b093a19ae2ef-x86_64-apple-darwin-codesigning.tar.gz
191e626756c7e899700fec5d060dbf791b169c83da6696d2df538b2bdd40da732d guix-build-b093a19ae2ef/output/x86_64-apple-darwin/bitcoin-b093a19ae2ef-x86_64-apple-darwin-unsigned.tar.gz
20e06e445ef6382e6f51cd3cbe4197a07b2c14033a4f7f633fa0a2ec53e8479186 guix-build-b093a19ae2ef/output/x86_64-apple-darwin/bitcoin-b093a19ae2ef-x86_64-apple-darwin-unsigned.zip
21a75743dcbf9e83f93d9e8f973b67fb6be39a216c3e7e598e5c1ca852b388a701 guix-build-b093a19ae2ef/output/x86_64-linux-gnu/SHA256SUMS.part
22b23ae4acda8d9ccb85ce813b6857a024d46c529a285ab44f0b4f4a00e4369c9e guix-build-b093a19ae2ef/output/x86_64-linux-gnu/bitcoin-b093a19ae2ef-x86_64-linux-gnu-debug.tar.gz
23b5428cb3de138ecf159784b33ef64ae5cb444997a7a3608cf79d1b61310d67d1 guix-build-b093a19ae2ef/output/x86_64-linux-gnu/bitcoin-b093a19ae2ef-x86_64-linux-gnu.tar.gz
24fe680b04532d08366c68ea3ed33208a2a9b76981e90ac9c4ca93d638ba00052d guix-build-b093a19ae2ef/output/x86_64-w64-mingw32/SHA256SUMS.part
250f4de9ccba8f1dc39bb477423e168a3735467cd7d956085a35688fe08b6e4ab6 guix-build-b093a19ae2ef/output/x86_64-w64-mingw32/bitcoin-b093a19ae2ef-win64-codesigning.tar.gz
2683101c499b05d05ee2dc44a3927ddd6c895d34459c97df25598641bb9217631b guix-build-b093a19ae2ef/output/x86_64-w64-mingw32/bitcoin-b093a19ae2ef-win64-debug.zip
27c8036cb6a582a539981213499f3e9b48b3fd3432b412912f390a97d62b4c6ef4 guix-build-b093a19ae2ef/output/x86_64-w64-mingw32/bitcoin-b093a19ae2ef-win64-setup-unsigned.exe
28246e39e8d7abcd7f08b627ceb2981176b9f7bc7ff703ad57267dc9028e00f858 guix-build-b093a19ae2ef/output/x86_64-w64-mingw32/bitcoin-b093a19ae2ef-win64-unsigned.zip