cmake: Proactively avoid use of `SECP256K1_DISABLE

hebasto commented at 12:48 PM on July 30, 2025: member

The SECP256K1_DISABLE_SHARED CMake variable has been removed upstream.

This PR removes its usage ahead of the next secp256k1 subtree update to prevent breakage and simplify integration.

hebasto added the label Build system on Jul 30, 2025

DrahtBot commented at 12:48 PM on July 30, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33101.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake
Stale ACK	theuni

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#32617 ([Draft/POC] Add secp256k1-based HPKE (Hybrid Public Key Encryption) For Payjoin v2 by w0xlt)
#32367 (cmake: Check user-defined APPEND_*FLAGS variables early by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

LLM Linter (✨ experimental)

Possible typos and grammar issues:

“during building depends and configuring this build system” -> “during building dependencies and configuring this build system” [“depends” is incorrect here and hinders comprehension; “dependencies” fits the context]

<sup>drahtbot_id_4_m</sup>

fanquake commented at 3:52 PM on July 30, 2025: member

cc @theuni @purpleKarrot

theuni approved

theuni commented at 6:33 PM on July 30, 2025: member

Nice. I've been wanting to scope the secp add_subdirectory for a while now.

utACK d5d95035bc6ef135476d7f734c574b38d6faaf70. Reviewed with git diff --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change

DrahtBot added the label Needs rebase on Jul 31, 2025

cmake, refactor: Encapsulate adding secp256k1 subtree in function eb59a192d9

cmake: Proactively avoid use of `SECP256K1_DISABLE_SHARED`

The `SECP256K1_DISABLE_SHARED` CMake variable has been removed upstream.

This change removes its usage ahead of the next `secp256k1` subtree
update to prevent breakage and simplify integration.

b093a19ae2

hebasto force-pushed on Aug 1, 2025

hebasto commented at 9:37 AM on August 1, 2025: member

Rebased due to a conflict with merged #31244.

DrahtBot removed the label Needs rebase on Aug 1, 2025

fanquake commented at 10:24 AM on August 6, 2025: member

ACK b093a19ae2eff306b8ed6ce74d133e3ec53ef64e

DrahtBot requested review from theuni on Aug 6, 2025

fanquake merged this on Aug 6, 2025

fanquake closed this on Aug 6, 2025

fanquake commented at 10:47 AM on August 6, 2025: member

Guix Build (aarch64):

1a4f3c804b729fdc5a3d4831239b6bd7e34e0ca9061395578dfce07ffa8ea1cf  guix-build-b093a19ae2ef/output/aarch64-linux-gnu/SHA256SUMS.part
03563287d5fd2f87829e2569e2fc02e8e6c0f9dc3db22d196fe442b852b242f0  guix-build-b093a19ae2ef/output/aarch64-linux-gnu/bitcoin-b093a19ae2ef-aarch64-linux-gnu-debug.tar.gz
5aee57e7e430fe8c7d0214dcc5717a1e50992fa9a28252804658fe262d6cde0e  guix-build-b093a19ae2ef/output/aarch64-linux-gnu/bitcoin-b093a19ae2ef-aarch64-linux-gnu.tar.gz
d619695f4a0ce8b74a70a222f9c4ff3532b7eaf3e46b19bb585bc8d0a44d8fa4  guix-build-b093a19ae2ef/output/arm-linux-gnueabihf/SHA256SUMS.part
29444e50a63ff8971bd72b02a297740baf129de543ebe280f78462a0529d08a1  guix-build-b093a19ae2ef/output/arm-linux-gnueabihf/bitcoin-b093a19ae2ef-arm-linux-gnueabihf-debug.tar.gz
ce3aa54f27cd02bd96cd52d13113f9e3e78c11f4eec20caa66273506065847c3  guix-build-b093a19ae2ef/output/arm-linux-gnueabihf/bitcoin-b093a19ae2ef-arm-linux-gnueabihf.tar.gz
bfaa3a80d8078f46bf757e4e17794cf0371b7bcc3c7246b59d8d4d414bf2a25b  guix-build-b093a19ae2ef/output/arm64-apple-darwin/SHA256SUMS.part
b61c4b4638eec218f391af243790ccdbbcec61d668ab70082153167e3d5abc45  guix-build-b093a19ae2ef/output/arm64-apple-darwin/bitcoin-b093a19ae2ef-arm64-apple-darwin-codesigning.tar.gz
73bef894bfabbf69ff5802c96dcee4418d270c8a5a69f84f7a5aa614337107fe  guix-build-b093a19ae2ef/output/arm64-apple-darwin/bitcoin-b093a19ae2ef-arm64-apple-darwin-unsigned.tar.gz
2b73a6354bfc746c7e8b34d35e1144c2e1ea0c5718146e4f879b03da65b033b4  guix-build-b093a19ae2ef/output/arm64-apple-darwin/bitcoin-b093a19ae2ef-arm64-apple-darwin-unsigned.zip
f3fd8a9eaa640dd7532da6af1a2a81883f220d68c12313ff70a9292a81de979d  guix-build-b093a19ae2ef/output/dist-archive/bitcoin-b093a19ae2ef.tar.gz
b9e0fde4d6a3a37837206ead8687a1639498a080b48a7f7a2ce89094d9794631  guix-build-b093a19ae2ef/output/powerpc64-linux-gnu/SHA256SUMS.part
d75ba692b6c55c69f8d52f70f68985dfc3ae9c6fa60fec3967fa2c18cfa3161f  guix-build-b093a19ae2ef/output/powerpc64-linux-gnu/bitcoin-b093a19ae2ef-powerpc64-linux-gnu-debug.tar.gz
b39303207f3a4cf54a79f76f655b02cf23b8f91f2b342885b4f622e9ab6245cc  guix-build-b093a19ae2ef/output/powerpc64-linux-gnu/bitcoin-b093a19ae2ef-powerpc64-linux-gnu.tar.gz
02e519b8825c089df62def0ebf33595323183b832fb466cccf885792558581aa  guix-build-b093a19ae2ef/output/riscv64-linux-gnu/SHA256SUMS.part
07ff752956fb318b1b9ea7851f300f7f8a38f0bf80aa4c5ab552a05daeb8b15e  guix-build-b093a19ae2ef/output/riscv64-linux-gnu/bitcoin-b093a19ae2ef-riscv64-linux-gnu-debug.tar.gz
b1da13582199184d860686150c382a83161230a58eafc7987372691b51933085  guix-build-b093a19ae2ef/output/riscv64-linux-gnu/bitcoin-b093a19ae2ef-riscv64-linux-gnu.tar.gz
71b90a0e33269ee883058394c14037447762178b172f56e66c8b84fae5277dab  guix-build-b093a19ae2ef/output/x86_64-apple-darwin/SHA256SUMS.part
7ea2e8214aaf42c8e4b63f6ab7ce5d69d347918b2bd4cd07761859ebc441c466  guix-build-b093a19ae2ef/output/x86_64-apple-darwin/bitcoin-b093a19ae2ef-x86_64-apple-darwin-codesigning.tar.gz
1e626756c7e899700fec5d060dbf791b169c83da6696d2df538b2bdd40da732d  guix-build-b093a19ae2ef/output/x86_64-apple-darwin/bitcoin-b093a19ae2ef-x86_64-apple-darwin-unsigned.tar.gz
e06e445ef6382e6f51cd3cbe4197a07b2c14033a4f7f633fa0a2ec53e8479186  guix-build-b093a19ae2ef/output/x86_64-apple-darwin/bitcoin-b093a19ae2ef-x86_64-apple-darwin-unsigned.zip
a75743dcbf9e83f93d9e8f973b67fb6be39a216c3e7e598e5c1ca852b388a701  guix-build-b093a19ae2ef/output/x86_64-linux-gnu/SHA256SUMS.part
b23ae4acda8d9ccb85ce813b6857a024d46c529a285ab44f0b4f4a00e4369c9e  guix-build-b093a19ae2ef/output/x86_64-linux-gnu/bitcoin-b093a19ae2ef-x86_64-linux-gnu-debug.tar.gz
b5428cb3de138ecf159784b33ef64ae5cb444997a7a3608cf79d1b61310d67d1  guix-build-b093a19ae2ef/output/x86_64-linux-gnu/bitcoin-b093a19ae2ef-x86_64-linux-gnu.tar.gz
fe680b04532d08366c68ea3ed33208a2a9b76981e90ac9c4ca93d638ba00052d  guix-build-b093a19ae2ef/output/x86_64-w64-mingw32/SHA256SUMS.part
0f4de9ccba8f1dc39bb477423e168a3735467cd7d956085a35688fe08b6e4ab6  guix-build-b093a19ae2ef/output/x86_64-w64-mingw32/bitcoin-b093a19ae2ef-win64-codesigning.tar.gz
83101c499b05d05ee2dc44a3927ddd6c895d34459c97df25598641bb9217631b  guix-build-b093a19ae2ef/output/x86_64-w64-mingw32/bitcoin-b093a19ae2ef-win64-debug.zip
c8036cb6a582a539981213499f3e9b48b3fd3432b412912f390a97d62b4c6ef4  guix-build-b093a19ae2ef/output/x86_64-w64-mingw32/bitcoin-b093a19ae2ef-win64-setup-unsigned.exe
246e39e8d7abcd7f08b627ceb2981176b9f7bc7ff703ad57267dc9028e00f858  guix-build-b093a19ae2ef/output/x86_64-w64-mingw32/bitcoin-b093a19ae2ef-win64-unsigned.zip

hebasto deleted the branch on Aug 6, 2025

cmake: Proactively avoid use of `SECP256K1_DISABLE_SHARED` #33101

Code Coverage & Benchmarks

Reviews

Conflicts

LLM Linter (✨ experimental)