cmake: Switch to generated `ts

hebasto commented at 12:31 pm on August 1, 2025: member

This PR:

Moves handling of Qt TS files into the locale directory.
Switches from inferior globbing to the explicit file list generated by the bitcoin-maintainer-tools/update-translations.py script.

Closes #32653.

DrahtBot added the label Build system on Aug 1, 2025

DrahtBot commented at 12:31 pm on August 1, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33115.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake
Stale ACK	BrandonOdiwuor

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto added the label GUI on Aug 1, 2025

hebasto commented at 12:31 pm on August 1, 2025: member

Friendly ping @laanwj :)

fanquake commented at 12:37 pm on August 1, 2025: member

Can we do a translation update here, to show that this change, and https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/185, are working properly.

hebasto commented at 1:05 pm on August 1, 2025: member

Can we do a translation update here, to show that this change, and bitcoin-core/bitcoin-maintainer-tools#185, are working properly.

Sure. A commit has been added. Please see the commit message for details.

fanquake commented at 1:35 pm on August 1, 2025: member

https://github.com/bitcoin/bitcoin/pull/33115/checks?check_run_id=47202038035:

0[09:14:13.759] gmake[2]: *** No rule to make target 'src/qt/locale/bitcoin_uz.qm', needed by 'src/qt/bitcoinqt_autogen/EJRQKI7XPS/qrc_bitcoin_locale.cpp'.  Stop.
1[09:14:13.759] gmake[2]: *** Waiting for unfinished jobs....

hebasto force-pushed on Aug 1, 2025

DrahtBot added the label CI failed on Aug 1, 2025

hebasto marked this as a draft on Aug 1, 2025

cmake, refactor: Move handling of Qt TS files into `locale` directory

This change offers a few advantages, such as:
- a more readable and cleaner `ts_files.cmake` (see the next commit);
- a scoped `ts_files` variable;
- improved code locality;
- no need to adjust the location of the resulting `*.qm` files.

95341de6ca

cmake: Switch to generated `ts_files.cmake` file

See the `update-translations.py` script in the
`bitcoin-maintainer-tools` repository.

ca04eebd72

hebasto force-pushed on Aug 1, 2025

hebasto marked this as ready for review on Aug 1, 2025

hebasto force-pushed on Aug 1, 2025

DrahtBot removed the label CI failed on Aug 1, 2025

BrandonOdiwuor commented at 6:34 am on August 2, 2025: contributor

Code Review ACK f2bfe852236f45b9ea81d6b3f06c6a0097be3ddd

Environment: macOS 15.5, Qt 6.9.0

Build & GUI Test: Built successfully; GUI tested with generated ts_files.cmake via updated update_translations.py. No errors. Translation Test: Kiswahili (sw) loaded correctly in GUI. Screenshot:

Also tested the updated update_transaltions.py against master branch and confirmed Greek (el) and Vietnamese (vi) as the only difference in ts_files.cmake list as intended

in src/qt/locale/bitcoin_pl.ts:148 in f2bfe85223 outdated

147-        <translation type="unfinished">Pokaż hasło </translation>
148+        <translation type="unfinished">Pokaż hasło</translation>
149     </message>
150     <message>
151         <source>Encrypt wallet</source>
152         <translation type="unfinished">Zaszyfruj portfel </translation>

maflcko commented at 7:51 am on August 2, 2025:

There are still some spacing issues here. See also the report https://github.com/maflcko/b-c-gui-translations-review/blob/ab6dc43a4c543c072d916a268a0bc34562ce3f81/README.md

cc https://github.com/maflcko/DrahtBot/issues/49

jesterhodl commented at 8:53 am on August 2, 2025:

Thanks, I’ll review those

jesterhodl commented at 8:57 pm on August 2, 2025:

transifex updated

fanquake commented at 9:03 am on August 4, 2025:

Are we going to pull in the updates, or leave this as-is?

maflcko commented at 9:34 am on August 4, 2025:

Are we going to pull in the updates, or leave this as-is?

I’ve also created a preliminary review for all languages: https://github.com/maflcko/b-c-gui-translations-review/tree/main/reviews

There is some obvious erroneous translations, like https://github.com/maflcko/b-c-gui-translations-review/blob/05100fec918fc44787d43004ea3b02749f5a16ee/reviews/te.md#L160-L166, but I am not familiar with those languages, so I can’t evaluate if the LLM generated translation is correct.

hebasto commented at 11:41 am on August 4, 2025:

transifex updated

I’ve pulled the most recent translations.

hebasto commented at 11:46 am on August 4, 2025:

Are we going to pull in the updates, or leave this as-is?

I’ve also created a preliminary review for all languages: https://github.com/maflcko/b-c-gui-translations-review/tree/main/reviews

There is some obvious erroneous translations, like https://github.com/maflcko/b-c-gui-translations-review/blob/05100fec918fc44787d43004ea3b02749f5a16ee/reviews/te.md#L160-L166, but I am not familiar with those languages, so I can’t evaluate if the LLM generated translation is correct.

Thanks @maflcko! I’ll link your suggestions to the Translation Opening Announcement as part of the upcoming v30 release process to notify all translators.

As for this PR, the last commit only serves only to demonstrate that the modified build system handles translation files properly. So I don’t think that any translation-specific issue should block it.

maflcko commented at 12:46 pm on August 4, 2025:

As for this PR, the last commit only serves only to demonstrate that the modified build system handles translation files properly. So I don’t think that any translation-specific issue should block it.

Agree. Discussion can be closed.

qt: Translations update

The translations for the following languages, which appear to be the
result of a mistake or an act of vandalism, have been discarded:
- Greek (el)
- Vietnamese (vi)

a26fbee38f

hebasto force-pushed on Aug 4, 2025

fanquake commented at 9:42 am on August 6, 2025: member

ACK a26fbee38f95e71fbbeb6cf09e18ed7fff089ec8

DrahtBot requested review from BrandonOdiwuor on Aug 6, 2025

fanquake merged this on Aug 6, 2025

fanquake closed this on Aug 6, 2025

hebasto deleted the branch on Aug 6, 2025

sipa commented at 4:18 am on August 7, 2025: member

The changes in src/qt/bitcoin_szl.ts look like they contain Rust source code?

maflcko commented at 6:19 am on August 7, 2025: member

The changes in src/qt/bitcoin_szl.ts look like they contain Rust source code?

cmake: Switch to generated ts_files.cmake file #33115

Code Coverage & Benchmarks

Reviews

cmake: Switch to generated `ts_files.cmake` file #33115