rpc: Fix ‘getdescriptoractivity’ RPCHelpMan, add test to verify fix #33119

1. 
   Christewart commented at 9:35 pm on August 1, 2025: contributor

   Fixes bug in getdescriptoractivity RPC help manual.

   Here is the line that pushes spend_vin field, there is no spend_vout json field.

   https://github.com/bitcoin/bitcoin/blob/master/src/rpc/blockchain.cpp#L2757

2. DrahtBot added the label Docs on Aug 1, 2025
3. 
   DrahtBot commented at 9:35 pm on August 1, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33119.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	nervana21, jonatack, luke-jr
   Concept ACK	Sammie05
   Stale ACK	pablomartin4btc

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. 
   pablomartin4btc commented at 11:39 pm on August 1, 2025: member

   cr ACK b17918d66743d6ee1cd2df7fd0a6c05dc87f71d8

   Maybe you can add the field validation in rpc_getdescriptoractivity.py (ie test_receive_then_spend).

5. 
   Sammie05 commented at 3:09 am on August 2, 2025: none

   Thanks for the fix, As mentioned above, adding a test for this in rpc_getdescriptoractivity.py would make the PR even more robust. ACK from me for this doc update
6. test: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify 'spend_vin' is the correct field 3543bfdfec
7. Christewart force-pushed on Aug 2, 2025
8. Christewart renamed this:
   doc: Fix 'getdescriptoractivity' RPCHelpMan
   test: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify fix
   on Aug 2, 2025
9. 
   Christewart commented at 3:27 pm on August 2, 2025: contributor

   @pablomartin4btc @Sammie05 Done in 3543bfd
10. 
    nervana21 commented at 6:29 pm on August 2, 2025: contributor

    tACK 3543bfd
11. DrahtBot requested review from pablomartin4btc on Aug 2, 2025
12. 
    jonatack commented at 9:20 pm on August 4, 2025: member

    ACK 3543bfdfec345cf2c952143c31674ef02de2a64b

    Suggest updating the PR title prefix from “test” to “rpc”

13. Christewart renamed this:
    test: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify fix
    rpc: Fix 'getdescriptoractivity' RPCHelpMan, add test to verify fix
    on Aug 4, 2025
14. 
    luke-jr commented at 2:36 am on August 5, 2025: member

    utACK 3543bfdfec345cf2c952143c31674ef02de2a64b
15. 
    luke-jr commented at 2:38 am on August 5, 2025: member

    The commit message should probably also be corrected (maybe “Docfix: RPC/blockchain: …”?)
16. luke-jr referenced this in commit 44fcd33fcc on Aug 5, 2025
17. fanquake merged this on Aug 6, 2025
18. fanquake closed this on Aug 6, 2025

    ---

19. fanquake referenced this in commit 2b9738a083 on Aug 6, 2025
20. 
    fanquake commented at 10:18 am on August 6, 2025: member

    Backported to 29.x in #33074.

Contributors
Christewart DrahtBot pablomartin4btc Sammie05 nervana21 jonatack luke-jr fanquake

Review Requested
pablomartin4btc

Labels
Docs