doc: Fix ‘getdescriptoractivity’ RPCHelpMan #33119

pull Christewart wants to merge 1 commits into bitcoin:master from Christewart:2025-08-01-getdescriptoractivity-help-bug changing 1 files +1 −1
  1. Christewart commented at 9:35 pm on August 1, 2025: contributor

    Fixes bug in getdescriptoractivity RPC help manual.

    Here is the line that pushes spend_vin field, there is no spend_vout json field.

    https://github.com/bitcoin/bitcoin/blob/master/src/rpc/blockchain.cpp#L2757

  2. doc: Fix 'getdescriptoractivity' RPCHelpMan b17918d667
  3. DrahtBot added the label Docs on Aug 1, 2025
  4. DrahtBot commented at 9:35 pm on August 1, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33119.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK pablomartin4btc
    Concept ACK Sammie05

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. pablomartin4btc commented at 11:39 pm on August 1, 2025: member

    cr ACK b17918d66743d6ee1cd2df7fd0a6c05dc87f71d8

    Maybe you can add the field validation in rpc_getdescriptoractivity.py (ie test_receive_then_spend).

  6. Sammie05 commented at 3:09 am on August 2, 2025: none
    Thanks for the fix, As mentioned above, adding a test for this in rpc_getdescriptoractivity.py would make the PR even more robust. ACK from me for this doc update

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-02 12:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me