ci: Use mlc v1 and fix typos #33125

1. 
   fanquake commented at 11:22 am on August 2, 2025: member

   Update mcl to v1 & shellcheck to 0.11.0. Includes other cherry-picked lint-related changes.
2. DrahtBot added the label Tests on Aug 2, 2025
3. 
   DrahtBot commented at 11:23 am on August 2, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33125.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   No conflicts as of last run.

4. in test/lint/test_runner/src/main.rs:691 in 8691ba8fae outdated

   687@@ -688,6 +688,7 @@ fn lint_doc() -> LintResult {
   688 fn lint_markdown() -> LintResult {
   689     let bin_name = "mlc";
   690     let mut md_ignore_paths = get_subtrees();
   691+    md_ignore_paths.push("./depends/work/");
   

   ---

   ---

   

   maflcko commented at 8:39 am on August 4, 2025:

   This was already reported in #31044 (and fixed?) So it looks like a regression and this is the wrong fix?

   ---

   

   willcl-ark commented at 2:20 pm on August 4, 2025:

   Yes, the --gitignore flag is slightly buggy. I have fix this (and speeded up the entire run) by ignoring all files in ignore directores in this patch: https://github.com/becheran/mlc/compare/master...willcl-ark:mlc:ignore-dirs-find

   Running that branch, with a dirty depends dir fixes that issue for me, although I still see one incorrect “error”:

    0Result (1871 links):
    1
    2OK       458
    3Skipped  1057
    4Warnings 355
    5Errors   1
    6
    7
    8The following links could not be resolved:
    9
   10./src/secp256k1/doc/release-process.md (37, 12) => /tools/check-abi.sh
   

   Where the issue is that the markdown is correct, but mlc does not understand this is a subtree. I suppose we should explicitly ignore our subtrees too then…

   ---

   

   fanquake commented at 2:42 pm on August 4, 2025:

   I suppose we should explicitly ignore our subtrees too then…

   Aren’t we already with let mut md_ignore_paths = get_subtrees(); ?

   ---

   

   fanquake commented at 8:04 am on August 7, 2025:

   Dropped this for now.
5. fanquake force-pushed on Aug 4, 2025
6. fanquake force-pushed on Aug 5, 2025
7. fanquake marked this as a draft on Aug 5, 2025
8. doc: fix typos 96f8673b87
9. test: Rename shuffled_indeces to shuffled_indices d818340e7e
10. doc: fix typos 49f2f3c89f
11. fix typo 7d60c0eb69
12. ci: update mlc to v1 e46af30441
13. ci: update shellcheck to v0.11.0 f28a94b40e
14. fanquake force-pushed on Aug 7, 2025
15. fanquake renamed this:
    ci: Use mlc `v1` and ignore `depends/work`
    ci: Use mlc `v1` and fix typos
    on Aug 7, 2025
16. 
    maflcko commented at 8:08 am on August 7, 2025: member

    Is this ready for review?
17. fanquake marked this as ready for review on Aug 7, 2025
18. 
    fanquake commented at 8:32 am on August 7, 2025: member

    It can be.
19. 
    maflcko commented at 10:07 am on August 7, 2025: member

    lgtm ACK f28a94b40eea8669eafc1b4152823e1ab26fa618
20. fanquake merged this on Aug 7, 2025
21. fanquake closed this on Aug 7, 2025

    ---

22. fanquake deleted the branch on Aug 7, 2025

Contributors
fanquake DrahtBot maflcko willcl-ark

Labels
Tests