ci: Use mlc `v1` and fix typos #33125

pull fanquake wants to merge 6 commits into bitcoin:master from fanquake:misc_cleanups changing 6 files +10 −10

fanquake commented at 11:22 AM on August 2, 2025: member

Update mcl to v1 & shellcheck to 0.11.0. Includes other cherry-picked lint-related changes.
DrahtBot added the label Tests on Aug 2, 2025
DrahtBot commented at 11:23 AM on August 2, 2025: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33125.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

No conflicts as of last run.
in test/lint/test_runner/src/main.rs:691 in 8691ba8fae outdated
```
 687 | @@ -688,6 +688,7 @@ fn lint_doc() -> LintResult {
 688 |  fn lint_markdown() -> LintResult {
 689 |      let bin_name = "mlc";
 690 |      let mut md_ignore_paths = get_subtrees();
 691 | +    md_ignore_paths.push("./depends/work/");
```
maflcko commented at 8:39 AM on August 4, 2025:

This was already reported in #31044 (and fixed?) So it looks like a regression and this is the wrong fix?
willcl-ark commented at 2:20 PM on August 4, 2025:

Yes, the --gitignore flag is slightly buggy. I have fix this (and speeded up the entire run) by ignoring all files in ignore directores in this patch: https://github.com/becheran/mlc/compare/master...willcl-ark:mlc:ignore-dirs-find

Running that branch, with a dirty depends dir fixes that issue for me, although I still see one incorrect "error":

Result (1871 links): OK 458 Skipped 1057 Warnings 355 Errors 1 The following links could not be resolved: ./src/secp256k1/doc/release-process.md (37, 12) => /tools/check-abi.sh

Where the issue is that the markdown is correct, but mlc does not understand this is a subtree. I suppose we should explicitly ignore our subtrees too then...
fanquake commented at 2:42 PM on August 4, 2025:

I suppose we should explicitly ignore our subtrees too then...

Aren't we already with let mut md_ignore_paths = get_subtrees(); ?

fanquake commented at 8:04 AM on August 7, 2025:

Dropped this for now.
fanquake force-pushed on Aug 4, 2025
fanquake force-pushed on Aug 5, 2025
fanquake marked this as a draft on Aug 5, 2025
doc: fix typos 96f8673b87
test: Rename shuffled_indeces to shuffled_indices d818340e7e
doc: fix typos 49f2f3c89f
fix typo 7d60c0eb69
ci: update mlc to v1 e46af30441
ci: update shellcheck to v0.11.0 f28a94b40e
fanquake force-pushed on Aug 7, 2025
fanquake renamed this:
~~ci: Use mlc `v1` and ignore `depends/work`~~
ci: Use mlc `v1` and fix typos
on Aug 7, 2025
maflcko commented at 8:08 AM on August 7, 2025: member

Is this ready for review?
fanquake marked this as ready for review on Aug 7, 2025
fanquake commented at 8:32 AM on August 7, 2025: member

It can be.
maflcko commented at 10:07 AM on August 7, 2025: member

lgtm ACK f28a94b40eea8669eafc1b4152823e1ab26fa618
fanquake merged this on Aug 7, 2025
fanquake closed this on Aug 7, 2025
fanquake deleted the branch on Aug 7, 2025

Type	Reviewers
ACK	maflcko

Contributors

Labels

ci: Use mlc `v1` and fix typos #33125

Code Coverage & Benchmarks

Reviews

Conflicts