depends: remove xinerama extension from libxcb #33217

1. 
   fanquake commented at 5:29 pm on August 19, 2025: member

   This is listed on https://doc.qt.io/qt-5.15/linux-requirements.html as “recommended”, and doesn’t seem to be needed (only used for windowing over multiple screens support?) , and the fact that it’s no-longer installed by default on modern linux distros (i.e Ubuntu), is annoying/confusing for users. See:

   #30061 #32097 #33197 https://bitcoin.stackexchange.com/questions/122646/libxcb-xinerama0-library-required-by-bitcoin-qt

   I haven’t tested the GUI with these changes. Just opening an alternative to #33197. Note that we also already have libxcb-cursor0 documented as a potentially missing runtime dependency (see build-unix.md).

2. DrahtBot added the label Build system on Aug 19, 2025
3. 
   DrahtBot commented at 5:29 pm on August 19, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33217.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. fanquake requested review from hebasto on Aug 20, 2025
5. 
   luke-jr commented at 1:57 pm on August 20, 2025: member

   (only used for windowing over multiple screens support?)

   Deprecated by and incompatible with XRandR which was introduced in ~2001.

6. luke-jr referenced this in commit de3675ca8d on Aug 20, 2025
7. luke-jr referenced this in commit 6789dc2e17 on Aug 20, 2025
8. depends: remove xinerama extension from libxcb

   This is listed on https://doc.qt.io/qt-5.15/linux-requirements.html as
   "recommended", however doesn't seem to be needed, and the fact that it's
   no-longer installed by default on modern linux distros, is
   annoying/confusing for users. See:
   
   https://github.com/bitcoin/bitcoin/issues/30061
   https://bitcoin.stackexchange.com/questions/122646/libxcb-xinerama0-library-required-by-bitcoin-qt
   https://github.com/bitcoin/bitcoin/pull/33197
   https://github.com/bitcoin/bitcoin/issues/32097

   3d9314f383
9. guix: remove libxcb-xinerama.so.0 from allowed libs decc3671c8
10. fanquake force-pushed on Aug 21, 2025
11. 
    hebasto commented at 6:12 pm on August 21, 2025: member

    Concept ACK.
12. 
    hebasto commented at 7:48 pm on August 21, 2025: member

    Here are related Qt issues and commits:

    • QTBUG-69411
    • QTBUG-86082
    • https://github.com/qt/qtbase/commit/c91d1fdc100cda88b94217153def52ab7fe63d21
13. 
    hebasto commented at 8:06 pm on August 21, 2025: member

    My Guix builds for Linux hosts:

     0aarch64
     1591acd2a1f17197ebf8da6c347cb976d5cf1faae174722e00bca5e54596dd8a9  guix-build-decc3671c88b/output/aarch64-linux-gnu/SHA256SUMS.part
     2f8075cbb6f4c09673aad64c79793c97f47209ea3b8b695992cfd8b16e98e3ff6  guix-build-decc3671c88b/output/aarch64-linux-gnu/bitcoin-decc3671c88b-aarch64-linux-gnu-debug.tar.gz
     3dc45ee866d0848bdb19dfbae47f591d78bf552604b866e521fe8dbc7acd169e1  guix-build-decc3671c88b/output/aarch64-linux-gnu/bitcoin-decc3671c88b-aarch64-linux-gnu.tar.gz
     4a421380acb71fed41313baec139919e7978b6d15ff082669c0ed0a9eab6e4b14  guix-build-decc3671c88b/output/arm-linux-gnueabihf/SHA256SUMS.part
     5d0335cb46e5494930c575b4afb7d5e4e1b3cc35a73e37ffe5763157ed6b45412  guix-build-decc3671c88b/output/arm-linux-gnueabihf/bitcoin-decc3671c88b-arm-linux-gnueabihf-debug.tar.gz
     615c0ddc782ef621b19ccf36f395a2f3614949278f07065ffff68a17b9efdcea9  guix-build-decc3671c88b/output/arm-linux-gnueabihf/bitcoin-decc3671c88b-arm-linux-gnueabihf.tar.gz
     7457c2b0ec830b5297bc8af6c6e75293c9a0913c4b87bc5a98106b489680e0177  guix-build-decc3671c88b/output/dist-archive/bitcoin-decc3671c88b.tar.gz
     861da648db94ed73bfb52cadc38121a0c2cf2f3a8d838bd5614364f217b024ae2  guix-build-decc3671c88b/output/powerpc64-linux-gnu/SHA256SUMS.part
     99a4096bdcc1e2edb2ab831d1d80322036e19130b3aa0d1452566a6cb1067f273  guix-build-decc3671c88b/output/powerpc64-linux-gnu/bitcoin-decc3671c88b-powerpc64-linux-gnu-debug.tar.gz
    105a8b542c376c9c67bdb2ea0c04c5730d2d954d3f9edae86d72ff6e10fc733ffd  guix-build-decc3671c88b/output/powerpc64-linux-gnu/bitcoin-decc3671c88b-powerpc64-linux-gnu.tar.gz
    11716631e7175a1693706032f8626bcadb46b62efdec54149db3e7d882aebc6ed8  guix-build-decc3671c88b/output/riscv64-linux-gnu/SHA256SUMS.part
    12a4b64b6f58c4dbf267df46a388baa2483df23818a6fca5400b6c7be0bd4121fc  guix-build-decc3671c88b/output/riscv64-linux-gnu/bitcoin-decc3671c88b-riscv64-linux-gnu-debug.tar.gz
    13b294d52a7edcaf56e6e59c00f6d68a49272401281b0cbc013a82304f674fab0e  guix-build-decc3671c88b/output/riscv64-linux-gnu/bitcoin-decc3671c88b-riscv64-linux-gnu.tar.gz
    14be9304bc2f9e571a94da5919a34dc0b57460e79ccb7a2b630714ad0d09583d98  guix-build-decc3671c88b/output/x86_64-linux-gnu/SHA256SUMS.part
    151728cb94c937e424ec70ff7d712578e6ca252e26cf9b5c4f1ac6f6466ead15a3  guix-build-decc3671c88b/output/x86_64-linux-gnu/bitcoin-decc3671c88b-x86_64-linux-gnu-debug.tar.gz
    16113f4bb5f65c8a924d6e137571f588fb33480620ce7319495ab97d9d9d0182c9  guix-build-decc3671c88b/output/x86_64-linux-gnu/bitcoin-decc3671c88b-x86_64-linux-gnu.tar.gz
    

14. hebasto approved
15. 
    hebasto commented at 8:28 pm on August 21, 2025: member

    ACK decc3671c88bb3acdf137c6bc46892f99319104e.

    This PR doesn’t affect the bitcoin-qt executable, since libxcb-xinerama.so isn’t used even in the current master branch @ 7d9789401be4c91a9eb3c1112564a6524bdc4f70.

16. fanquake merged this on Aug 22, 2025
17. fanquake closed this on Aug 22, 2025

    ---

18. fanquake deleted the branch on Aug 22, 2025
19. fanquake referenced this in commit d9532415da on Aug 22, 2025
20. fanquake referenced this in commit 1e8637c064 on Aug 22, 2025
21. 
    fanquake commented at 11:47 am on August 22, 2025: member

    Backported to 29.x in #33238.

    This wasn’t backported.

22. alexanderwiederin referenced this in commit 49e068b15b on Sep 16, 2025
23. alexanderwiederin referenced this in commit 4b0c2f2a8f on Sep 17, 2025
24. alexanderwiederin referenced this in commit 2edb618ffe on Sep 17, 2025
25. stringintech referenced this in commit fb8510ba20 on Sep 17, 2025

Contributors
fanquake DrahtBot luke-jr hebasto

Labels
Build system