Backports #33217 to the 29.x branch.
Same rationale as #33217. xinerama was obseleted well before it's removal in Qt6.
[29.x] depends: remove xinerama extension from libxcb #33238
pull fanquake wants to merge 3 commits into bitcoin:29.x from fanquake:backport_33217 changing 3 files +2 −2-
fanquake commented at 11:47 AM on August 22, 2025: member
-
d9532415da
depends: remove xinerama extension from libxcb
This is listed on https://doc.qt.io/qt-5.15/linux-requirements.html as "recommended", however doesn't seem to be needed, and the fact that it's no-longer installed by default on modern linux distros, is annoying/confusing for users. See: https://github.com/bitcoin/bitcoin/issues/30061 https://bitcoin.stackexchange.com/questions/122646/libxcb-xinerama0-library-required-by-bitcoin-qt https://github.com/bitcoin/bitcoin/pull/33197 https://github.com/bitcoin/bitcoin/issues/32097 Github-Pull: #33217 Rebased-From: 3d9314f3838c3b369bb79a64479f110c35b78644
-
1e8637c064
guix: remove libxcb-xinerama.so.0 from allowed libs
Github-Pull: #33217 Rebased-From: decc3671c88bb3acdf137c6bc46892f99319104e
-
doc: update release notes for 29.x 6b8a782bbd
- fanquake requested review from hebasto on Aug 22, 2025
- DrahtBot added the label Backport on Aug 22, 2025
-
DrahtBot commented at 11:47 AM on August 22, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33238.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
fanquake commented at 12:41 PM on August 22, 2025: member
Guess we can't backport this unless we also backport the removal in Qt. Will take a look.
- DrahtBot added the label CI failed on Aug 22, 2025
-
hebasto commented at 2:04 PM on August 24, 2025: member
Guess we can't backport this unless we also backport the removal in Qt. Will take a look.
Indeed. And there's no
configureoption to disable the XCB Xinerama extension.I assume that backporting https://github.com/qt/qtbase/commit/c91d1fdc100cda88b94217153def52ab7fe63d21 might be non-trivial, and it would definitely require extensive testing across a range of platforms.
While the dependency on this extension "is annoying/confusing for users", it is not a bug. We could keep things as they are, treating this dependency as an artifact of the legacy Qt5-based GUI.
- fanquake closed this on Sep 1, 2025
- fanquake deleted the branch on Sep 1, 2025