doc: unify datacarriersize warning with release notes #33224

1. 
   l0rinc commented at 3:45 am on August 20, 2025: contributor

   Follow-up to #32406

   ---

   The release notes claim

   […] marked as deprecated and are expected to be removed in a future release

   but the warning itself claims

   […] marked as deprecated. They will be removed in a future version.

   To be less aggressive (since some have objected against this version online) - and to unify the deprecation warning with the release notes - I have changed the warning to communicate our expectation in a friendlier way.

2. doc: unify `datacarriersize` warning with release notes

   Unified the deprecation warning for the recently deprecated datacarrier[size] options to match the phrasing of release-notes-32406.md.

   2885bd0e1c
3. DrahtBot added the label Docs on Aug 20, 2025
4. 
   DrahtBot commented at 3:45 am on August 20, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33224.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	janb84, Zero-1729, cedwies, jonatack, ryanofsky, hodlinator, ajtowns

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. 
   janb84 commented at 12:19 pm on August 20, 2025: contributor

   ACK 2885bd0e1c4fc863a7f28ff0fd353f5cffb03442

   Pr changes warning of datacarriersize to a friendlier one. The friendlier text aligns also with the release notes.

   Given that deprecation not always results in removal (in this project), I find this warning message a better representation of the reality.

6. 
   Zero-1729 commented at 12:32 pm on August 20, 2025: contributor

   LGTM

   crACK 2885bd0e1c4fc863a7f28ff0fd353f5cffb03442

   Good catch; the new message tone is more aligned and communicates the intention better.

7. 
   cedwies commented at 12:41 pm on August 20, 2025: none

   ACK 2885bd0

   The PR adjusts the -datacarrier/-datacarriersize deprecation warning to be less absolute and better match the release notes. I think the new wording still communicates deprecation, but without overstating certainty about removal. Code change is minimal and the functional test was updated accordingly.

8. 
   jonatack commented at 4:21 pm on August 20, 2025: member

   ACK 2885bd0e1c4fc863a7f28ff0fd353f5cffb03442
9. achow101 added this to the milestone 30.0 on Aug 21, 2025
10. achow101 removed this from the milestone 30.0 on Aug 21, 2025
11. 
    ryanofsky commented at 4:59 pm on August 21, 2025: contributor

    Code review ACK 2885bd0e1c4fc863a7f28ff0fd353f5cffb03442. I don’t think it is good for the release notes and the runtime warning message to say two different things. I’d also be happy if release notes were updated to match the runtime warning, instead of vice versa. Whatever is more accurate is better.
12. hodlinator approved
13. 
    hodlinator commented at 5:51 pm on August 21, 2025: contributor

    ACK 2885bd0e1c4fc863a7f28ff0fd353f5cffb03442

    Makes wording consistent with release notes (end of line):

    https://github.com/bitcoin/bitcoin/blob/f5f853d952542ebd45339a270a98362696877657/doc/release-notes-32406.md?plain=1#L1

14. 
    ajtowns commented at 3:03 am on August 22, 2025: contributor

    ACK 2885bd0e1c4fc863a7f28ff0fd353f5cffb03442

    Unless there’s an explicit schedule for the removal (eg -paytxfee is deprecated and will be fully removed in v31.0), this phrasing seems more accurate. Probably the testnet3 deprecation should also either be scheduled or changed to “is expected to be removed” as well.

15. 
    fanquake commented at 11:40 am on August 22, 2025: member

    cc @hebasto; given this would change translations after translation string freeze.

Contributors
l0rinc DrahtBot janb84 Zero-1729 cedwies jonatack ryanofsky hodlinator ajtowns fanquake

Labels
Docs