188@@ -188,10 +189,10 @@ static const CRPCConvertParam vRPCConvertParams[] =
189 { "gettxout", 1, "n" },
190 { "gettxout", 2, "include_mempool" },
191 { "gettxoutproof", 0, "txids" },
192- { "gettxoutsetinfo", 1, "hash_or_height" },
193+ { "gettxoutsetinfo", 1, "hash_or_height", /*also_string=*/true },
194 { "gettxoutsetinfo", 2, "use_index"},
195 { "dumptxoutset", 2, "options" },
196- { "dumptxoutset", 2, "rollback" },
197+ { "dumptxoutset", 2, "rollback", /*also_string=*/true },
Will this entry have an effect? In the positional map members, the key ("dumptxoutset", 2) is first set to false. My understanding is that subsequent encounters of the same key are ignored by std::map::emplace. Is this the desired behavior, or should the subsequent value overwrite the first?
0{ "dumptxoutset", 2, "options", /*also_string=*/false }, // inserted
1{ "dumptxoutset", 2, "rollback", /*also_string=*/true }, // ignored or used to overwrite?
Yes, the effect it has is on the named parameter. rollback cannot actually be passed as a positional parameter since it is actually part of the options object which would have to be passed in position 2. However, if rollback is passed by name, then we need to apply the conversion.
Order does matter here in that the options parameter needs to come first so that the positional is not interpreted as a string.
