doc: follow-ups to “Add bitcoin-{node,gui} to release binaries for IPC” #33233

pull Sjors wants to merge 4 commits into bitcoin:master from Sjors:2025/08/pr-31802-followups changing 3 files +11 −5
  1. Sjors commented at 10:10 am on August 21, 2025: member
    • have dependencies.md link to the PR that updated the capnp version: #31802 (review)
  2. doc: link to capnp version bump PR 2a815d126b
  3. DrahtBot commented at 10:11 am on August 21, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33233.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, janb84
    Stale ACK ryanofsky

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. janb84 commented at 10:16 am on August 21, 2025: contributor

    ACK 2a815d126bc90f787f7adbe8cade45cb7307429b

    PR updates dependencies document to point to version bump PR of capnproto.

    • “code” review ✅
  5. maflcko commented at 10:30 am on August 21, 2025: member
    lgtm ACK 2a815d126bc90f787f7adbe8cade45cb7307429b
  6. ryanofsky commented at 12:35 pm on August 21, 2025: contributor

    Code review ACK 2a815d126bc90f787f7adbe8cade45cb7307429b

    Maybe we want to keep this PR open a little longer in case there are other small documentation updates like this? Seems fine to merge now though if preferred.

    May also want to include “doc:” in PR title

    Another little thing I noticed is that italics should be removed from these files in files.md since they are now included in binary releases:

    https://github.com/bitcoin/bitcoin/blob/7d9789401be4c91a9eb3c1112564a6524bdc4f70/doc/files.md?plain=1#L153-L154

  7. Sjors commented at 1:18 pm on August 21, 2025: member

    Maybe we want to keep this PR open a little longer in case there are other small documentation updates like this?

    Yes, I was assuming there would be more things showing up over the next few days. Though I can always open another PR.

  8. doc: mark bitcoin-{node,gui} installed in files.md eab5518913
  9. maflcko commented at 1:57 pm on August 21, 2025: member

    Also, on Fedora you need both packages, see https://github.com/maflcko/b-c-nightly/commit/14d34abdda4bbb327583f908742925b230944444.

    Suggested patch:

     0diff --git a/doc/build-unix.md b/doc/build-unix.md
     1index 38b4496687..04f757ba52 100644
     2--- a/doc/build-unix.md
     3+++ b/doc/build-unix.md
     4@@ -122,7 +122,7 @@ User-Space, Statically Defined Tracing (USDT) dependencies:
     5 
     6 Cap'n Proto is needed for IPC functionality (see [multiprocess.md](multiprocess.md)):
     7 
     8-    sudo dnf install capnproto
     9+    sudo dnf install capnproto capnproto-devel
    10 
    11 Compile with `-DENABLE_IPC=OFF` if you do not need IPC functionality.
    12 
    
  10. fanquake commented at 3:54 pm on August 21, 2025: member
    You’ll also need to add the capnp install instructions for Alpine and Arch in build-unix.md.
  11. fanquake added this to the milestone 30.0 on Aug 21, 2025
  12. doc: add capnproto-devel to Fedora build instruction
    Co-authored-by: maflcko <6399679+maflcko@users.noreply.github.com>
    49d1a1a363
  13. Sjors commented at 4:20 pm on August 21, 2025: member

    Arch instruction taken from: https://capnproto.org/install.html

    For Alpine I added capnproto and capnproto-dev since they both exist, but didn’t test if the latter is needed.

  14. doc: capnproto instruction for Alpine and Arch de65c86572
  15. Sjors force-pushed on Aug 21, 2025
  16. maflcko commented at 4:32 pm on August 21, 2025: member

    For Alpine I added capnproto and capnproto-dev since they both exist, but didn’t test if the latter is needed.

    dev installs the other: https://cirrus-ci.com/task/6500081345495040?logs=install#L0

  17. maflcko commented at 4:32 pm on August 21, 2025: member
    lgtm ACK de65c86572c5ca96e388a444aae9aa73bbd8860a
  18. DrahtBot requested review from ryanofsky on Aug 21, 2025
  19. DrahtBot requested review from janb84 on Aug 21, 2025
  20. janb84 commented at 4:37 pm on August 21, 2025: contributor
    re ACK de65c86572c5ca96e388a444aae9aa73bbd8860a
  21. jonatack commented at 8:50 pm on August 21, 2025: member

    LGTM, though suggest renaming the PR title to

    doc: follow-ups to "Add bitcoin-{node,gui} to release binaries for IPC"

  22. Sjors renamed this:
    IPC followups for PR 31802
    doc: follow-ups to "Add bitcoin-{node,gui} to release binaries for IPC"
    on Aug 22, 2025
  23. DrahtBot added the label Docs on Aug 22, 2025
  24. Sjors commented at 6:17 am on August 22, 2025: member
    @jonatack done, although I wasn’t expecting there to be only doc changes.
  25. fanquake commented at 11:46 am on August 22, 2025: member
    If there are more changes, there can be more PRs. We can fixup the docs now, and open more PRs when needed.
  26. fanquake merged this on Aug 22, 2025
  27. fanquake closed this on Aug 22, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-22 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me