rpc: deprecateboolverbose Boolean verbosity is deprecated #33288

pull fqlx wants to merge 1 commits into bitcoin:master from fqlx:rpc/deprecateboolverbose changing 12 files +129 −11
  1. fqlx commented at 2:58 am on September 3, 2025: none
    • Added a deprecation flag -deprecatedrpc=boolverbose
    • Modified ParseVerbosity to check this flag and warn when boolean is used
    • Boolean verbosity still works WITH the deprecation flag but shows warnings
    • WITHOUT the flag, it throws the deprecation error
  2. DrahtBot commented at 2:58 am on September 3, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33288.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  3. DrahtBot added the label CI failed on Sep 3, 2025
  4. DrahtBot commented at 3:03 am on September 3, 2025: contributor

    🚧 At least one of the CI tasks failed. Task lint: https://github.com/bitcoin/bitcoin/runs/49461079135 LLM reason (✨ experimental): Lint tests failed due to a file permission issue on test/functional/rpc_boolverbose_deprecated.py (needs 755), causing lint-files.py to fail.

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  5. fqlx force-pushed on Sep 3, 2025
  6. fqlx force-pushed on Sep 3, 2025
  7. rpc/deprecateboolverbose Boolean verbosity is deprecated c37d5ab7d6
  8. fqlx force-pushed on Sep 3, 2025
  9. fqlx renamed this:
    rpc/deprecateboolverbose Boolean verbosity is deprecated
    rpc: deprecateboolverbose Boolean verbosity is deprecated
    on Sep 3, 2025
  10. fanquake commented at 8:55 am on September 3, 2025: member
    There’s no need to open a new PR here, you can make these changes in #33214.
  11. maflcko closed this on Sep 3, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-19 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me