trace: Workaround GCC bug compiling with old systemtap #33310

1. 
   luke-jr commented at 7:26 pm on September 4, 2025: member
2. trace: Workaround GCC bug compiling with old systemtap 93a29ff283
3. 
   DrahtBot commented at 7:27 pm on September 4, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33310.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	0xB10C

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. 
   fanquake commented at 11:18 am on September 5, 2025: member

   Recreated the issue using 4.6:

    0        Run Build Command(s): /usr/bin/cmake -E env VERBOSE=1 /bin/gmake -f Makefile cmTC_5ba56/fast
    1        /bin/gmake  -f CMakeFiles/cmTC_5ba56.dir/build.make CMakeFiles/cmTC_5ba56.dir/build
    2        gmake[1]: Entering directory '/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-goOPiQ'
    3        Building CXX object CMakeFiles/cmTC_5ba56.dir/src.cxx.o
    4        /bin/arm-linux-gnueabihf-g++ -DHAVE_USDT_H -I/bitcoin/depends/arm-linux-gnueabihf/include -O2 -O2 -g -std=c++20 -o CMakeFiles/cmTC_5ba56.dir/src.cxx.o -c /bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-goOPiQ/src.cxx
    5        during RTL pass: mach
    6        /bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-goOPiQ/src.cxx: In function 'int main()':
    7        /bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-goOPiQ/src.cxx:12:5: internal compiler error: in create_fix_barrier, at config/arm/arm.cc:18266
    8           12 |     }
    9              |     ^
   10        0x1a0339f internal_error(char const*, ...)
   11        	???:0
   12        0x677e6b fancy_abort(char const*, int, char const*)
   13        	???:0
   14        Please submit a full bug report, with preprocessed source (by using -freport-bug).
   15        Please include the complete backtrace with any bug report.
   16        See <file:///usr/share/doc/gcc-14/README.Bugs> for instructions.
   17        gmake[1]: *** [CMakeFiles/cmTC_5ba56.dir/build.make:81: CMakeFiles/cmTC_5ba56.dir/src.cxx.o] Error 1
   18        gmake[1]: Leaving directory '/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-goOPiQ'
   19        gmake: *** [Makefile:134: cmTC_5ba56/fast] Error 2
   20        
   21      exitCode: 2
   

5. 
   0xB10C commented at 7:13 am on September 12, 2025: contributor

   lgtm ACK 93a29ff2830162c8129d35c7b9beb43fab984503 - I did not test this.

   The change in Systemtap can be found here: https://sourceware.org/git/?p=systemtap.git;a=blobdiff;f=includes/sys/sdt.h;h=28d236d91cd8e4d3a5db8b13cac90fb678c629cf;hp=9ecb1cb6fed2bbb9f58aaca640c5840e471b67ac;hb=34facf7ee6b43dae66cc109973a4eda42e439163;hpb=2c11a115bdbe41a7f064ccd32b41c76c5b7c516d

   Including this makes sense as there are likely some OSs (e.g. Ubuntu 22.04) still shipping <systemtap-4.7.

   Depends builds use systemtap 4.8 at the moment: https://github.com/bitcoin/bitcoin/blob/b81445333a10c50e2f74b6629a7b41542fcbd4a5/depends/packages/systemtap.mk#L2

6. fanquake merged this on Sep 12, 2025
7. fanquake closed this on Sep 12, 2025

   ---

8. fanquake referenced this in commit 35038b03c9 on Sep 12, 2025
9. 
   fanquake commented at 10:51 am on September 12, 2025: member

   Backported to 30.x in #33356.
10. fanquake referenced this in commit e97588fc3d on Sep 12, 2025
11. 
    fanquake commented at 10:53 am on September 12, 2025: member

    Backported to 29.x in #33344.

Contributors
luke-jr DrahtBot fanquake 0xB10C