trace: Workaround GCC bug compiling with old systemtap #33310

No description provided.

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33310.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

<!--5faf32d7da4f0f540f40219e4f7537a3-->

Recreated the issue using 4.6:

        Run Build Command(s): /usr/bin/cmake -E env VERBOSE=1 /bin/gmake -f Makefile cmTC_5ba56/fast
        /bin/gmake  -f CMakeFiles/cmTC_5ba56.dir/build.make CMakeFiles/cmTC_5ba56.dir/build
        gmake[1]: Entering directory '/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-goOPiQ'
        Building CXX object CMakeFiles/cmTC_5ba56.dir/src.cxx.o
        /bin/arm-linux-gnueabihf-g++ -DHAVE_USDT_H -I/bitcoin/depends/arm-linux-gnueabihf/include -O2 -O2 -g -std=c++20 -o CMakeFiles/cmTC_5ba56.dir/src.cxx.o -c /bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-goOPiQ/src.cxx
        during RTL pass: mach
        /bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-goOPiQ/src.cxx: In function 'int main()':
        /bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-goOPiQ/src.cxx:12:5: internal compiler error: in create_fix_barrier, at config/arm/arm.cc:18266
           12 |     }
              |     ^
        0x1a0339f internal_error(char const*, ...)
        	???:0
        0x677e6b fancy_abort(char const*, int, char const*)
        	???:0
        Please submit a full bug report, with preprocessed source (by using -freport-bug).
        Please include the complete backtrace with any bug report.
        See <file:///usr/share/doc/gcc-14/README.Bugs> for instructions.
        gmake[1]: *** [CMakeFiles/cmTC_5ba56.dir/build.make:81: CMakeFiles/cmTC_5ba56.dir/src.cxx.o] Error 1
        gmake[1]: Leaving directory '/bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-goOPiQ'
        gmake: *** [Makefile:134: cmTC_5ba56/fast] Error 2
        
      exitCode: 2

lgtm ACK 93a29ff2830162c8129d35c7b9beb43fab984503 - I did not test this.

The change in Systemtap can be found here: https://sourceware.org/git/?p=systemtap.git;a=blobdiff;f=includes/sys/sdt.h;h=28d236d91cd8e4d3a5db8b13cac90fb678c629cf;hp=9ecb1cb6fed2bbb9f58aaca640c5840e471b67ac;hb=34facf7ee6b43dae66cc109973a4eda42e439163;hpb=2c11a115bdbe41a7f064ccd32b41c76c5b7c516d

Including this makes sense as there are likely some OSs (e.g. Ubuntu 22.04) still shipping <systemtap-4.7.

Depends builds use systemtap 4.8 at the moment: https://github.com/bitcoin/bitcoin/blob/b81445333a10c50e2f74b6629a7b41542fcbd4a5/depends/packages/systemtap.mk#L2

Backported to 30.x in #33356.

Backported to 29.x in #33344.