ci: Remove bash -c from cmake invocation using eval #33401

Follow up to #32970

#32970#r2213730157

Does cmake -S ... still need to be wrapped in bash -c "..."?

#32970#r2213741192

It is not trivial to replace. Maybe the eval hack from below can be used:

  # parses TEST_RUNNER_EXTRA as an array which allows for multiple arguments such as TEST_RUNNER_EXTRA='--exclude "rpc_bind.py --ipv6"'

  eval "TEST_RUNNER_EXTRA=($TEST_RUNNER_EXTRA)"

however, I haven't tried this yet.

#32970#r2213801696

Yeah, the eval hack should work:

$ export T="-DREDUCE_EXPORTS=ON -DCMAKE_CXX_FLAGS='-Wno-psabi     -Wno-error=maybe-uninitialized'";  eval "T=($T)"; for i in "${T[@]}"; do  echo "_${i}_" ; done 
_-DREDUCE_EXPORTS=ON_
_-DCMAKE_CXX_FLAGS=-Wno-psabi     -Wno-error=maybe-uninitialized_

(can be done in a follow-up)

This replaces the bash -c wrapper with an eval-based array parsing to preserve spaces in flag values (e.g., in CMAKE_CXX_FLAGS), allowing ShellCheck to lint the cmake command

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33401.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

<!--5faf32d7da4f0f540f40219e4f7537a3-->

Concept ACK on expanding ShellCheck lint coverage.

nice, lgtm ACK 8406c1e6321fbc3ce739aa7ccb18c67fb706a4b9

ACK 8406c1e6321fbc3ce739aa7ccb18c67fb706a4b9.

lgtm ACK 50194029e7c2581b751931080f5999785a39929f

ACK 50194029e7c2581b751931080f5999785a39929f.