cmake: Install bitcoin manpage #33407

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250916-bitcoin-manpage changing 1 files +1 −1
  1. hebasto commented at 1:20 pm on September 16, 2025: member
    This PR is an amendment to #31375.
  2. cmake: Install `bitcoin` manpage 7584a4fda9
  3. hebasto added this to the milestone 30.0 on Sep 16, 2025
  4. hebasto added the label Build system on Sep 16, 2025
  5. hebasto added the label Needs backport (30.x) on Sep 16, 2025
  6. DrahtBot commented at 1:20 pm on September 16, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33407.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK ryanofsky

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #33229 (multiprocess: Don’t require bitcoin -m argument when IPC options are used by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. fanquake commented at 1:23 pm on September 16, 2025: member

    This PR is an amendment to #33348.

    Not sure this is related to #33348. It should have been part of #31375?

  8. hebasto commented at 1:24 pm on September 16, 2025: member

    This PR is an amendment to #33348.

    Not sure this is related to #33348. It should have been part of #31375?

    The PR description has been updated.

  9. ryanofsky approved
  10. ryanofsky commented at 5:27 pm on September 16, 2025: contributor

    Code review ACK 7584a4fda95d004d31c2df15fdb6f3a7f9654348.

    If I’m understanding this right, #31375 added the executable without a manpage, #33348 added the manpage but did not install it, so it would not be included with release binaries, and this PR installs it so it is included.

  11. fanquake merged this on Sep 17, 2025
  12. fanquake closed this on Sep 17, 2025

  13. fanquake removed the label Needs backport (30.x) on Sep 17, 2025
  14. fanquake commented at 8:57 am on September 17, 2025: member
    Backported to 30.x in #33356.
  15. fanquake referenced this in commit c9f751090c on Sep 17, 2025
  16. hebasto deleted the branch on Sep 17, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-18 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me