[28.x] More backports #33415

1. 
   fanquake commented at 11:09 am on September 17, 2025: member

   Further backports for 28.x:

   • #33236
   • #33340
   • #33395

   Plus changes for 28.3rc1.

2. Fix benchmark CSV output

   The `SHA256AutoDetect` return output is used, among other use cases, to
   name benchmarks. Using a comma breaks the CSV output.
   
   This change replaces the comma with a semicolon, which fixes the issue.
   
   Github-Pull: #33340
   Rebased-From: 790b440197bde322432a5bab161f1869b667e681

   e94515b919
3. net: Do not apply whitelist permission to onion inbounds

   Tor inbound connections do not reveal the peer's actual network address.
   Therefore do not apply whitelist permissions to them.
   
   Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
   
   Github-Pull: #33395
   Rebased-From: f563ce90818d486d2a199439d2f6ba39cd106352

   69ce524e46
4. doc: Remove wrong and redundant doxygen tag

   Remove it in feerate.
   
   Fix it in the other places.
   
   Github-Pull: #33236
   Rebased-From: 966666de9a6211b8748f43d682490c924e132e58

   7c59f03edc
5. fanquake added this to the milestone 28.3 on Sep 17, 2025
6. DrahtBot added the label Backport on Sep 17, 2025
7. 
   DrahtBot commented at 11:09 am on September 17, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33415.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Stale ACK	willcl-ark

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

8. DrahtBot added the label CI failed on Sep 17, 2025
9. fanquake marked this as ready for review on Sep 17, 2025
10. fanquake force-pushed on Sep 17, 2025
11. willcl-ark approved
12. 
    willcl-ark commented at 2:39 pm on September 17, 2025: member

    ACK 7575828dd2ea539e103067cd35e31333797d22e3

    Backports look good. Release notes contain all commits and authors.

13. doc: update release notes for 28.x 35e38588f5
14. build: bump version to 28.3rc1 75bd3ba87b
15. doc: update manual pages for v28.3rc1 a79508f226
16. fanquake force-pushed on Sep 17, 2025
17. 
    achow101 commented at 6:19 pm on September 17, 2025: member

    Should we also backport #33106 if we’re going to be doing a 28.3 anyways?
18. 
    glozow commented at 8:43 pm on September 17, 2025: member

    Should we also backport #33106 if we’re going to be doing a 28.3 anyways?

    Here is a branch to do this: https://github.com/glozow/bitcoin/tree/2025-09-28.3-backport

    Similar to #33226, needed to do some test massaging. I also needed #30948 and #30748 for the test utils/refactors. Feel free to pull; I updated the final changes as well.

19. 
    fanquake commented at 9:32 am on September 18, 2025: member

    Here is a branch to do this: https://github.com/glozow/bitcoin/tree/2025-09-28.3-backport

    Thanks. Looks like there are some issues with this branch. i.e:

    0test/mempool_tests.cpp:434: Entering test case "MempoolSizeLimitTest"
    1<snip>
    2test/mempool_tests.cpp:562: error: in "mempool_tests/MempoolSizeLimitTest": check pool.GetMinFee(1).GetFeePerK() == maxFeeRateRemoved.GetFeePerK() + 1000 has failed [19941 != 20841]
    32025-09-18T09:27:52.459923Z (mocktime: 1970-01-01T12:00:42Z) [test] [validationinterface.cpp:228] [MempoolTransactionsRemovedForBlock] [validation] Enqueuing MempoolTransactionsRemovedForBlock: block height=1 txs removed=0
    4test/mempool_tests.cpp:566: error: in "mempool_tests/MempoolSizeLimitTest": check pool.GetMinFee(1).GetFeePerK() == llround((maxFeeRateRemoved.GetFeePerK() + 1000)/2.0) has failed [9971 != 10421]
    5test/mempool_tests.cpp:570: error: in "mempool_tests/MempoolSizeLimitTest": check pool.GetMinFee(pool.DynamicMemoryUsage() * 5 / 2).GetFeePerK() == llround((maxFeeRateRemoved.GetFeePerK() + 1000)/4.0) has failed [4985 != 5210]
    6test/mempool_tests.cpp:574: error: in "mempool_tests/MempoolSizeLimitTest": check pool.GetMinFee(pool.DynamicMemoryUsage() * 9 / 2).GetFeePerK() == llround((maxFeeRateRemoved.GetFeePerK() + 1000)/8.0) has failed [2493 != 2605]
    7test/mempool_tests.cpp:578: error: in "mempool_tests/MempoolSizeLimitTest": check pool.GetMinFee(1).GetFeePerK() == 1000 has failed [100 != 1000]
    

    Want to PR / debug that separately?

Contributors
fanquake DrahtBot willcl-ark achow101 glozow

Labels
Backport CI failed

Milestone
28.3