ci: remove Clang build from msan fuzz job #33425

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:just_link_libstdcpp changing 2 files +4 −18
  1. fanquake commented at 11:17 am on September 18, 2025: member
    Remove the Clang build from msan fuzz by using the apt install LLVM / Clang, and just linking against -lstdc++.
  2. DrahtBot added the label Tests on Sep 18, 2025
  3. DrahtBot commented at 11:17 am on September 18, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33425.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #33381 (test: Fix TestFlushBehavior when coin has non-zero dynamic memory usage by PiRK)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. fanquake marked this as ready for review on Sep 18, 2025
  5. fanquake marked this as a draft on Sep 18, 2025
  6. fanquake force-pushed on Sep 18, 2025
  7. fanquake commented at 1:08 pm on September 18, 2025: member

    Runtime is alright, and similar to Valgrind, is being blown a bit by the slowest tests. i.e mini_miner running for a half hour:

     0Run mini_miner with args ['/home/admin/actions-runner/_work/_temp/build/bin/fuzz', '-runs=1', PosixPath('/home/admin/actions-runner/_work/_temp/ci/scratch/qa-assets/fuzz_corpora/mini_miner')]INFO: Running with entropic power schedule (0xFF, 100).
     1<snip>
     2Done 641 runs in 1868 second(s)
     3Run txdownloadman_impl with args ['/home/admin/actions-runner/_work/_temp/build/bin/fuzz', '-runs=1', PosixPath('/home/admin/actions-runner/_work/_temp/ci/scratch/qa-assets/fuzz_corpora/txdownloadman_impl')]INFO: Running with entropic power schedule (0xFF, 100).
     4<snip>
     5Done 633 runs in 1194 second(s)
     6Run tx_pool_standard with args ['/home/admin/actions-runner/_work/_temp/build/bin/fuzz', '-runs=1', PosixPath('/home/admin/actions-runner/_work/_temp/ci/scratch/qa-assets/fuzz_corpora/tx_pool_standard')]INFO: Running with entropic power schedule (0xFF, 100).
     7<snip>
     8Done 920 runs in 1068 second(s)
     9Run addrman_serdeser with args ['/home/admin/actions-runner/_work/_temp/build/bin/fuzz', '-runs=1', PosixPath('/home/admin/actions-runner/_work/_temp/ci/scratch/qa-assets/fuzz_corpora/addrman_serdeser')]INFO: Running with entropic power schedule (0xFF, 100).
    10<snip>
    11Done 988 runs in 1131 second(s)
    12Run ephemeral_package_eval with args ['/home/admin/actions-runner/_work/_temp/build/bin/fuzz', '-runs=1', PosixPath('/home/admin/actions-runner/_work/_temp/ci/scratch/qa-assets/fuzz_corpora/ephemeral_package_eval')]INFO: Running with entropic power schedule (0xFF, 100).
    13>snip>
    14Done 945 runs in 942 second(s)
    
  8. fanquake force-pushed on Sep 19, 2025
  9. fanquake referenced this in commit 953544d028 on Sep 20, 2025
  10. fanquake force-pushed on Sep 20, 2025
  11. fanquake commented at 8:23 am on September 21, 2025: member

    Runtime currently 25m, which is on par with ASAN, and faster than both Windows CIs. Slowest targets:

    0addrman_serdeser: 1019
    1descriptor_parse: 875
    2ephemeral_package_eval: 863
    3tx_pool_standard: 829s
    4mocked_descriptor_parse: 756
    
  12. maflcko commented at 9:33 am on September 23, 2025: member
    Unrelatedly(?), I wonder if it is possible to adjust the existing macos fuzz task to have stdlib hardening enabled.
  13. ci: link against -lstdc++ in native fuzz with msan job b77137a564
  14. fanquake force-pushed on Sep 23, 2025
  15. fanquake marked this as ready for review on Sep 23, 2025
  16. fanquake renamed this:
    ci: run native_fuzz_with_msan
    ci: remove Clang build from msan fuzz job
    on Sep 23, 2025
  17. fanquake commented at 1:57 pm on September 23, 2025: member
    Dropped adding the job to the CI (just dropping the Clang build for now).
  18. maflcko commented at 2:02 pm on September 23, 2025: member
    lgtm ACK b77137a5644e09a08442aed7d8a4a9290fb53526
  19. fanquake merged this on Sep 23, 2025
  20. fanquake closed this on Sep 23, 2025

  21. fanquake deleted the branch on Sep 23, 2025
  22. fanquake referenced this in commit 18ccbf971e on Sep 23, 2025
  23. fanquake referenced this in commit 7ebdfa2173 on Sep 23, 2025
  24. willcl-ark referenced this in commit fc8912715b on Sep 23, 2025
  25. willcl-ark referenced this in commit 5750355139 on Sep 23, 2025
  26. fanquake referenced this in commit c5d8702c3f on Sep 23, 2025
  27. fanquake commented at 2:38 pm on September 23, 2025: member

    Unrelatedly(?), I wonder if it is possible to adjust the existing macos fuzz task to have stdlib hardening enabled.

    Opened #33462 to have a look.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-26 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me