ci: remove Clang build from msan fuzz job #33425

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:just_link_libstdcpp changing 2 files +4 −18
  1. fanquake commented at 11:17 AM on September 18, 2025: member

    Remove the Clang build from msan fuzz by using the apt install LLVM / Clang, and just linking against -lstdc++.

  2. DrahtBot added the label Tests on Sep 18, 2025
  3. DrahtBot commented at 11:17 AM on September 18, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33425.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #33381 (test: Fix TestFlushBehavior when coin has non-zero dynamic memory usage by PiRK)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. fanquake marked this as ready for review on Sep 18, 2025
  5. fanquake marked this as a draft on Sep 18, 2025
  6. fanquake force-pushed on Sep 18, 2025
  7. fanquake commented at 1:08 PM on September 18, 2025: member

    Runtime is alright, and similar to Valgrind, is being blown a bit by the slowest tests. i.e mini_miner running for a half hour:

    Run mini_miner with args ['/home/admin/actions-runner/_work/_temp/build/bin/fuzz', '-runs=1', PosixPath('/home/admin/actions-runner/_work/_temp/ci/scratch/qa-assets/fuzz_corpora/mini_miner')]INFO: Running with entropic power schedule (0xFF, 100).
<snip>
Done 641 runs in 1868 second(s)
Run txdownloadman_impl with args ['/home/admin/actions-runner/_work/_temp/build/bin/fuzz', '-runs=1', PosixPath('/home/admin/actions-runner/_work/_temp/ci/scratch/qa-assets/fuzz_corpora/txdownloadman_impl')]INFO: Running with entropic power schedule (0xFF, 100).
<snip>
Done 633 runs in 1194 second(s)
Run tx_pool_standard with args ['/home/admin/actions-runner/_work/_temp/build/bin/fuzz', '-runs=1', PosixPath('/home/admin/actions-runner/_work/_temp/ci/scratch/qa-assets/fuzz_corpora/tx_pool_standard')]INFO: Running with entropic power schedule (0xFF, 100).
<snip>
Done 920 runs in 1068 second(s)
Run addrman_serdeser with args ['/home/admin/actions-runner/_work/_temp/build/bin/fuzz', '-runs=1', PosixPath('/home/admin/actions-runner/_work/_temp/ci/scratch/qa-assets/fuzz_corpora/addrman_serdeser')]INFO: Running with entropic power schedule (0xFF, 100).
<snip>
Done 988 runs in 1131 second(s)
Run ephemeral_package_eval with args ['/home/admin/actions-runner/_work/_temp/build/bin/fuzz', '-runs=1', PosixPath('/home/admin/actions-runner/_work/_temp/ci/scratch/qa-assets/fuzz_corpora/ephemeral_package_eval')]INFO: Running with entropic power schedule (0xFF, 100).
>snip>
Done 945 runs in 942 second(s)
  8. fanquake force-pushed on Sep 19, 2025
  9. fanquake referenced this in commit 953544d028 on Sep 20, 2025
  10. fanquake force-pushed on Sep 20, 2025
  11. fanquake commented at 8:23 AM on September 21, 2025: member

    Runtime currently 25m, which is on par with ASAN, and faster than both Windows CIs. Slowest targets:

    addrman_serdeser: 1019
descriptor_parse: 875
ephemeral_package_eval: 863
tx_pool_standard: 829s
mocked_descriptor_parse: 756
  12. maflcko commented at 9:33 AM on September 23, 2025: member

    Unrelatedly(?), I wonder if it is possible to adjust the existing macos fuzz task to have stdlib hardening enabled.

  13. ci: link against -lstdc++ in native fuzz with msan job b77137a564
  14. fanquake force-pushed on Sep 23, 2025
  15. fanquake marked this as ready for review on Sep 23, 2025
  16. fanquake renamed this:
    ci: run native_fuzz_with_msan
    ci: remove Clang build from msan fuzz job
    on Sep 23, 2025
  17. fanquake commented at 1:57 PM on September 23, 2025: member

    Dropped adding the job to the CI (just dropping the Clang build for now).

  18. maflcko commented at 2:02 PM on September 23, 2025: member

    lgtm ACK b77137a5644e09a08442aed7d8a4a9290fb53526

  19. fanquake merged this on Sep 23, 2025
  20. fanquake closed this on Sep 23, 2025
  21. fanquake deleted the branch on Sep 23, 2025
  22. fanquake referenced this in commit 18ccbf971e on Sep 23, 2025
  23. fanquake referenced this in commit 7ebdfa2173 on Sep 23, 2025
  24. willcl-ark referenced this in commit fc8912715b on Sep 23, 2025
  25. willcl-ark referenced this in commit 5750355139 on Sep 23, 2025
  26. fanquake referenced this in commit c5d8702c3f on Sep 23, 2025
  27. fanquake commented at 2:38 PM on September 23, 2025: member

    Unrelatedly(?), I wonder if it is possible to adjust the existing macos fuzz task to have stdlib hardening enabled.

    Opened #33462 to have a look.

  28. in ci/test/01_base_install.sh:61 in b77137a564 
      57 | @@ -58,23 +58,6 @@ fi
  58 |  if [[ -n "${USE_INSTRUMENTED_LIBCPP}" ]]; then
  59 |    ${CI_RETRY_EXE} git clone --depth=1 https://github.com/llvm/llvm-project -b "llvmorg-21.1.1" /llvm-project
  60 |  
  61 | -  if [ -n "${APT_LLVM_V}" ]; then
    Sjors commented at 4:34 PM on September 23, 2025:

    Do I understand correctly that this also (positively) impacts the ASan/TSan, depends jobs?

    maflcko commented at 5:39 PM on September 23, 2025:

    yeah, but only to the extent of fixing the bug introduced in https://github.com/bitcoin/bitcoin/pull/33364/files by reverting the full and redundant clang compile it introduced.

    Sjors commented at 5:58 PM on September 23, 2025:

    That build took over an hour on https://github.com/Sjors/sv2-tp and cherry-picking this commit made it fast again, so that's nice.

  29. fanquake referenced this in commit 72c1f13c33 on Sep 23, 2025
  30. fanquake referenced this in commit 76a784c3b0 on Sep 29, 2025
  31. sedited referenced this in commit 3f14dd4b2a on Oct 7, 2025
  32. fanquake referenced this in commit e4c04f7759 on Oct 8, 2025
  33. sedited referenced this in commit 5f9d179b8d on Oct 8, 2025
  34. sedited referenced this in commit 845b93d99e on Oct 8, 2025
  35. yuvicc referenced this in commit ccce70c31a on Oct 8, 2025
  36. sedited referenced this in commit 3b1e26d5d3 on Oct 10, 2025
  37. sedited referenced this in commit 0fa2fdaca0 on Oct 11, 2025
  38. stringintech referenced this in commit f74b275ffc on Oct 14, 2025
  39. fanquake referenced this in commit 2f7a50f67c on Oct 15, 2025
  40. Raimo33 referenced this in commit 76dbc48232 on Oct 17, 2025
  41. stickies-v referenced this in commit a785fe6759 on Nov 5, 2025
  42. morozow referenced this in commit 3b4a7007b6 on May 8, 2026
  43. morozow referenced this in commit 6ae5e123cb on May 8, 2026
  44. morozow referenced this in commit bb37527a1e on May 8, 2026
  45. Kino1994 referenced this in commit 195fff809f on Jun 28, 2026
  46. Kino1994 referenced this in commit eb896c24b3 on Jun 28, 2026
  47. Kino1994 referenced this in commit 7601171955 on Jun 28, 2026
  48. Kino1994 referenced this in commit 3e652de2be on Jun 28, 2026
  49. BigcoinBGC referenced this in commit 7007bf44c0 on Jun 30, 2026
  50. BigcoinBGC referenced this in commit aff548f5f2 on Jun 30, 2026
  51. BigcoinBGC referenced this in commit 274b85e43a on Jun 30, 2026
  52. BigcoinBGC referenced this in commit b778a9628d on Jun 30, 2026
  53. Kino1994 referenced this in commit dd17e766cf on Aug 19, 2026
  54. Kino1994 referenced this in commit e7e73600de on Aug 19, 2026
  55. Kino1994 referenced this in commit 98596dbb26 on Aug 19, 2026
  56. Kino1994 referenced this in commit 14a056ebf5 on Aug 19, 2026
  57. bitcoin locked this on Sep 23, 2026
Contributors
fanquakeDrahtBotmaflckoSjors
Labels
Tests
Linked (view graph)
#33424 [30.0] Final changes + rc2#33429 fuzz: reduce iterations in slow targets#33462 ci: add libcpp hardening flags to macOS fuzz job
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-04 14:51 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me