depends: static libxcb-cursor #33434

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:static_libxcb_util_cursor changing 3 files +1 −8
  1. fanquake commented at 12:50 pm on September 19, 2025: member
    Remove the runtime requirement of libxcb-cursor. This library is no-longer present on modern Ubuntu. Fixes #33432. Also related to #32097.
  2. DrahtBot added the label Build system on Sep 19, 2025
  3. DrahtBot commented at 12:50 pm on September 19, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33434.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK TheCharlatan, hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. fanquake commented at 12:50 pm on September 19, 2025: member
    @benthecarman any chance you can test a Guix built binary?
  5. benthecarman commented at 2:44 pm on September 19, 2025: contributor

    @benthecarman any chance you can test a Guix built binary?

    I needed to install libxcb-cursor0 to get the guix built binary to work, that’s when it fixed the window issue but removed dark mode

  6. fanquake commented at 2:50 pm on September 19, 2025: member
    Just to be clear, I meant could you test a Guix build of this branch, as the bitcoin-qt produced no-longer has a libxcb-cursor0 dependency.
  7. benthecarman commented at 3:56 pm on September 19, 2025: contributor

    Sorry, that was for v30rc1

    built guix binary for this PR. This fixes so I don’t need libxcb-cursor0 installed to run the binary and is the same where no dark mode but also no windowing bug

  8. in depends/packages/libxcb_util_cursor.mk:9 in 2cf742c521 outdated
     5@@ -6,7 +6,7 @@ $(package)_sha256_hash=0e9c5446dc6f3beb8af6ebfcc9e27bcc6da6fe2860f7fc07b99144dfa
     6 $(package)_dependencies=libxcb libxcb_util_render libxcb_util_image
     7 
     8 define $(package)_set_vars
     9-$(package)_config_opts = --disable-static
    10+$(package)_config_opts = --disable-shared
    


    hebasto commented at 4:07 pm on September 19, 2025:

    Haven’t tested this, or looked for potential side effects (i.e #33432 claims that installing the dep breaks dark mode). Also related to #32097.

    I’m still not sure I understand this fix. Perhaps @benthecarman could provide more details about the reported bug?


    benthecarman commented at 4:15 pm on September 19, 2025:
  9. fanquake marked this as ready for review on Sep 19, 2025
  10. TheCharlatan commented at 8:39 pm on September 21, 2025: contributor

    Concept ACK

    I’m not familiar enough with X to say why it’s seemingly not possible to link all the xcb_utils statically, but this change seems sane to me.

  11. depends: static libxcb_cursor
    Modern Ubuntu isn't shipping with this library installed by default.
    Staticly link it to remove the need for end-users to install it.
    
    Closes #33432.
    eca50854e1
  12. fanquake force-pushed on Sep 23, 2025
  13. fanquake commented at 2:45 pm on September 23, 2025: member

    I’m not familiar enough with X to say why it’s seemingly not possible to link all the xcb_utils statically, but this change seems sane to me.

    Yea, maybe this is the direction we should go. Ideally we can land this change for 30, to remove the awkwardness here. I’ve updated the commit message and PR description.

  14. fanquake commented at 6:27 pm on September 23, 2025: member

    Guix Build (x86_64):

     0cf7f86d91288477c11afdc767969d6b19b0ba1e62c73924e72b22a2527374653  guix-build-eca50854e1cb/output/aarch64-linux-gnu/SHA256SUMS.part
     15afe50eb76079f96a5129b5e51e2ede657f10c5031abe24a875410f006c55511  guix-build-eca50854e1cb/output/aarch64-linux-gnu/bitcoin-eca50854e1cb-aarch64-linux-gnu-debug.tar.gz
     2ba6f7937c5d333e64560abcd95dbb3856ceaa43fbcde766ebcaed1f8e23f2a7e  guix-build-eca50854e1cb/output/aarch64-linux-gnu/bitcoin-eca50854e1cb-aarch64-linux-gnu.tar.gz
     3bbdf057a0b42636765dc4c2e005c955e2b4fa826ea06f649bb6b48dd6dc45d7a  guix-build-eca50854e1cb/output/arm-linux-gnueabihf/SHA256SUMS.part
     47e9d8983db8ee44f5812f9192adca09160acc8a1f0dc07be9b67169896fc15fe  guix-build-eca50854e1cb/output/arm-linux-gnueabihf/bitcoin-eca50854e1cb-arm-linux-gnueabihf-debug.tar.gz
     5135775299474f11f969dbb4f219cfb485ebba5b190f1d558e62eb3311ed7c686  guix-build-eca50854e1cb/output/arm-linux-gnueabihf/bitcoin-eca50854e1cb-arm-linux-gnueabihf.tar.gz
     6e913a502d5d4621b58d943a2963b485911e0309c08cae9fa507fa68600f517da  guix-build-eca50854e1cb/output/arm64-apple-darwin/SHA256SUMS.part
     7cdb3f0de0d2e3d9547f0ed2da640e3b845f3e217ffe882b2c9aa99929359045e  guix-build-eca50854e1cb/output/arm64-apple-darwin/bitcoin-eca50854e1cb-arm64-apple-darwin-codesigning.tar.gz
     8d2b57d19b3c69e22550e448f2d0be6838fd85f334d582618ef00742e5a39eefa  guix-build-eca50854e1cb/output/arm64-apple-darwin/bitcoin-eca50854e1cb-arm64-apple-darwin-unsigned.tar.gz
     9c38a022a112709b43a71090a5408116ae654029ff94e95dced4f267916e75caf  guix-build-eca50854e1cb/output/arm64-apple-darwin/bitcoin-eca50854e1cb-arm64-apple-darwin-unsigned.zip
    10c12073eeb266e309c7669e084d13cec0e5e2224821c3f27d20f600f870ecf19d  guix-build-eca50854e1cb/output/dist-archive/bitcoin-eca50854e1cb.tar.gz
    1174e2670cae2f374a83ecf9b554bf9e5513ed957807cbc0073003a22635e5e451  guix-build-eca50854e1cb/output/powerpc64-linux-gnu/SHA256SUMS.part
    125bbb70440153087cbb737d7f0194ddff93f9c4d1cf3d928a9eee64f065d27184  guix-build-eca50854e1cb/output/powerpc64-linux-gnu/bitcoin-eca50854e1cb-powerpc64-linux-gnu-debug.tar.gz
    133ffe08f501112496a1a72ab9a4a328b294e845fc7ef6b01215234c862289a863  guix-build-eca50854e1cb/output/powerpc64-linux-gnu/bitcoin-eca50854e1cb-powerpc64-linux-gnu.tar.gz
    14c288d11acf623eace1d033b9706af7e58f445571bb855d0f418557660a244d01  guix-build-eca50854e1cb/output/riscv64-linux-gnu/SHA256SUMS.part
    152e7613024ca7d09165f14b93a455f811f819bc0ce533173149a6b15737fbfcc6  guix-build-eca50854e1cb/output/riscv64-linux-gnu/bitcoin-eca50854e1cb-riscv64-linux-gnu-debug.tar.gz
    165e2e71715ca94ef496c6c74db837f76185446cae02992b45de2cd23eb85b4aea  guix-build-eca50854e1cb/output/riscv64-linux-gnu/bitcoin-eca50854e1cb-riscv64-linux-gnu.tar.gz
    176e83a3dd664bd74a6887785d5b8e52caa3680cb2fe732c4dfbe921f7abb92f72  guix-build-eca50854e1cb/output/x86_64-apple-darwin/SHA256SUMS.part
    188f08fbc2ac62c30a0d5416c80ec8be16f051e2cfa1141c8dfc217dc2bc712fc0  guix-build-eca50854e1cb/output/x86_64-apple-darwin/bitcoin-eca50854e1cb-x86_64-apple-darwin-codesigning.tar.gz
    19f28be3037a2230088b5141645f90b20976c5f3c323c2ace495472f45938ad58a  guix-build-eca50854e1cb/output/x86_64-apple-darwin/bitcoin-eca50854e1cb-x86_64-apple-darwin-unsigned.tar.gz
    20a5e84800ab5a7d499e96def0c94325a06170bbcd51aa855e2dd75e0137f3e2a7  guix-build-eca50854e1cb/output/x86_64-apple-darwin/bitcoin-eca50854e1cb-x86_64-apple-darwin-unsigned.zip
    216ea9d32fd447fafef15c83e419c2c4cb2e2bcc168b07f8e71c4f8cc93c15982c  guix-build-eca50854e1cb/output/x86_64-linux-gnu/SHA256SUMS.part
    226d765b1f8191c9bfe030b6c9df01e955bfa5e16683dba61dcfe33b4cd585803a  guix-build-eca50854e1cb/output/x86_64-linux-gnu/bitcoin-eca50854e1cb-x86_64-linux-gnu-debug.tar.gz
    23573aa76d009263d4484baa7404b86fb260636a9e778745846099625b91a69378  guix-build-eca50854e1cb/output/x86_64-linux-gnu/bitcoin-eca50854e1cb-x86_64-linux-gnu.tar.gz
    2425b5854b22434e4fef2c7998c028f6f491dc1e98db4cb00349cf14bbd5186068  guix-build-eca50854e1cb/output/x86_64-w64-mingw32/SHA256SUMS.part
    2516ce26db341a5ab2c0d999af3e79087456df3e3c998d07d172d5110b37f04e42  guix-build-eca50854e1cb/output/x86_64-w64-mingw32/bitcoin-eca50854e1cb-win64-codesigning.tar.gz
    26c66c1b5b4dde0792f8caa3dc320118de39cecc319804a7ed456484a5835a902a  guix-build-eca50854e1cb/output/x86_64-w64-mingw32/bitcoin-eca50854e1cb-win64-debug.zip
    27c16a701fa8455fd7f9d6699c1115f96bb25cd094e8806fa12892480ead7184b2  guix-build-eca50854e1cb/output/x86_64-w64-mingw32/bitcoin-eca50854e1cb-win64-setup-unsigned.exe
    28db990808e826141a62fc9befa988dd462556b4174e4beeebf05c8c31859900a8  guix-build-eca50854e1cb/output/x86_64-w64-mingw32/bitcoin-eca50854e1cb-win64-unsigned.zip
    
  15. davidgumberg commented at 0:06 am on September 24, 2025: contributor

    Trying to do a guix build on this branch I get the following error:

     0$ HOSTS=x86_64-linux-gnu ./contrib/guix/guix-build
     1CMake Error at qtbase/cmake/QtBuildInformation.cmake:522 (message):
     2  Feature "xcb": Forcing to "ON" breaks its condition:
     3
     4      QT_FEATURE_thread AND TARGET XCB::XCB AND TEST_xcb_syslibs AND QT_FEATURE_xkbcommon_x11
     5
     6  Condition values dump:
     7
     8      QT_FEATURE_thread = "ON"
     9      TARGET XCB::XCB found
    10      TEST_xcb_syslibs = "FALSE"
    11      QT_FEATURE_xkbcommon_x11 not evaluated
    12
    13Call Stack (most recent call first):
    14  qtbase/cmake/QtFeature.cmake:322 (qt_configure_add_report_error)
    15  qtbase/cmake/QtFeature.cmake:442 (qt_feature_check_and_save_internal_value)
    16  qtbase/cmake/QtFeature.cmake:711 (qt_evaluate_feature)
    17  qtbase/cmake/QtFeature.cmake:680 (qt_feature_module_end)
    18  qtbase/src/CMakeLists.txt:13 (qt_feature_evaluate_features)
    19
    20
    21Package x11 was not found in the pkg-config search path.
    22Perhaps you should add the directory containing `x11.pc'
    23to the PKG_CONFIG_PATH environment variable
    24No package 'x11' found
    
      0-- Checking dependencies of submodule 'qtbase'
      1-- Configuring submodule 'qtbase'
      2-- [QtBase] CMAKE_BUILD_TYPE was already explicitly set to: 'Release'
      3            -DCMAKE_C_FLAGS=  -I/bitcoin/depends/x86_64-linux-gnu/include  -ffile-prefix-map=/bitcoin/depends/work/build/x86_64-linux-gnu/qt/6.7.3-011bb3e2916=/usr
      4            -DCMAKE_C_FLAGS_RELEASE=-O2
      5            -DCMAKE_C_FLAGS_RELWITHDEBINFO=-O2 -g -DNDEBUG
      6            -DCMAKE_CXX_FLAGS=  -I/bitcoin/depends/x86_64-linux-gnu/include  -ffile-prefix-map=/bitcoin/depends/work/build/x86_64-linux-gnu/qt/6.7.3-011bb3e2916=/usr
      7            -DCMAKE_CXX_FLAGS_RELEASE=-O2
      8            -DCMAKE_CXX_FLAGS_RELWITHDEBINFO=-O2 -g -DNDEBUG
      9            -DCMAKE_OBJCOPY=/home/kepler/.guix-profile/bin/x86_64-linux-gnu-objcopy
     10            -DCMAKE_C_STANDARD=11
     11            -DCMAKE_C_STANDARD_REQUIRED=ON
     12            -DCMAKE_CXX_STANDARD=20
     13            -DCMAKE_CXX_STANDARD_REQUIRED=ON
     14            -DCMAKE_MODULE_PATH:STRING=/bitcoin/depends/work/build/x86_64-linux-gnu/qt/6.7.3-011bb3e2916/qtbase/cmake/platforms
     15CMake Error at qtbase/cmake/QtBuildInformation.cmake:522 (message):
     16  Feature "xcb": Forcing to "ON" breaks its condition:
     17
     18      QT_FEATURE_thread AND TARGET XCB::XCB AND TEST_xcb_syslibs AND QT_FEATURE_xkbcommon_x11
     19
     20  Condition values dump:
     21
     22      QT_FEATURE_thread = "ON"
     23      TARGET XCB::XCB found
     24      TEST_xcb_syslibs = "FALSE"
     25      QT_FEATURE_xkbcommon_x11 not evaluated
     26
     27Call Stack (most recent call first):
     28  qtbase/cmake/QtFeature.cmake:322 (qt_configure_add_report_error)
     29  qtbase/cmake/QtFeature.cmake:442 (qt_feature_check_and_save_internal_value)
     30  qtbase/cmake/QtFeature.cmake:711 (qt_evaluate_feature)
     31  qtbase/cmake/QtFeature.cmake:680 (qt_feature_module_end)
     32  qtbase/src/CMakeLists.txt:13 (qt_feature_evaluate_features)
     33
     34
     35Package x11 was not found in the pkg-config search path.
     36Perhaps you should add the directory containing `x11.pc'
     37to the PKG_CONFIG_PATH environment variable
     38No package 'x11' found
     39
     40-- Configuration summary shown below. It has also been written to /bitcoin/depends/work/build/x86_64-linux-gnu/qt/6.7.3-011bb3e2916/config.summary
     41-- Configure with --log-level=STATUS or higher to increase CMake's message verbosity. The log level does not persist across reconfigurations.
     42
     43-- Configure summary:
     44
     45Building for: linux-g++ (x86_64, CPU features: )
     46Compiler: gcc 13.3.0
     47Build options:
     48  Mode ................................... release
     49  Optimize release build for size ........ no
     50  Fully optimize release builds (-O3) .... no
     51  Building shared libraries .............. no
     52  Using ccache ........................... no
     53  Unity Build ............................ no
     54  Using new DTAGS ........................ yes
     55  Relocatable ............................ no
     56  Using precompiled headers .............. yes
     57  Using Link Time Optimization (LTCG) .... no
     58  Using Intel CET ........................ no
     59  Target compiler supports:
     60    x86 Intrinsics ....................... Basic VAES AVX512VBMI2
     61  Sanitizers:
     62    Addresses ............................ no
     63    Threads .............................. no
     64    Memory ............................... no
     65    Fuzzer (instrumentation only) ........ no
     66    Undefined ............................ no
     67  Build parts ............................ libs
     68  Install examples sources ............... no
     69Qt modules and options:
     70  Qt Concurrent .......................... no
     71  Qt D-Bus ............................... yes
     72  Qt D-Bus directly linked to libdbus .... no
     73  Qt Gui ................................. yes
     74  Qt Network ............................. yes
     75  Qt PrintSupport ........................ no
     76  Qt Sql ................................. no
     77  Qt Testlib ............................. yes
     78  Qt Widgets ............................. yes
     79  Qt Xml ................................. yes
     80Support enabled for:
     81  Using pkg-config ....................... yes
     82  Using vcpkg ............................ no
     83  udev ................................... no
     84  OpenSSL ................................ no
     85    Qt directly linked to OpenSSL ........ no
     86  OpenSSL 1.1 ............................ no
     87  OpenSSL 3.0 ............................ no
     88  Using system zlib ...................... no
     89  Zstandard support ...................... no
     90  Thread support ......................... yes
     91Common build options:
     92  Linker can resolve circular dependencies  yes
     93Qt Core:
     94  backtrace .............................. no
     95  DoubleConversion ....................... yes
     96    Using system DoubleConversion ........ no
     97  CLONE_PIDFD support in forkfd .......... yes
     98  GLib ................................... no
     99  ICU .................................... no
    100  Using system libb2 ..................... no
    101  Built-in copy of the MIME database ..... yes
    102  Application permissions ................ yes
    103  Defaulting legacy IPC to POSIX ......... no
    104  Tracing backend ........................ <none>
    105  OpenSSL based cryptographic hash ....... no
    106  Logging backends:
    107    journald ............................. no
    108    syslog ............................... no
    109    slog2 ................................ no
    110  PCRE2 .................................. yes
    111    Using system PCRE2 ................... no
    112Qt Network:
    113  getifaddrs() ........................... no
    114  IPv6 ifname ............................ no
    115  libproxy ............................... no
    116  Linux AF_NETLINK ....................... yes
    117  DTLS ................................... no
    118  OCSP-stapling .......................... no
    119  SCTP ................................... no
    120  Use system proxies ..................... no
    121  GSSAPI ................................. no
    122  Brotli Decompression Support ........... no
    123  qIsEffectiveTLD() ...................... no
    124    Built-in publicsuffix database ....... no
    125    System publicsuffix database ......... no
    126Core tools:
    127  Android deployment tool ................ no
    128  macOS deployment tool .................. no
    129  Windows deployment tool ................ no
    130  qmake .................................. no
    131Qt Gui:
    132  Accessibility .......................... yes
    133  FreeType ............................... yes
    134    Using system FreeType ................ yes
    135  HarfBuzz ............................... yes
    136    Using system HarfBuzz ................ no
    137  Fontconfig ............................. yes
    138  Image formats:
    139    GIF .................................. no
    140    ICO .................................. no
    141    JPEG ................................. no
    142      Using system libjpeg ............... no
    143    PNG .................................. yes
    144      Using system libpng ................ no
    145  Text formats:
    146    HtmlParser ........................... yes
    147    CssParser ............................ yes
    148    OdfWriter ............................ no
    149    MarkdownReader ....................... no
    150      Using system libmd4c ............... no
    151    MarkdownWriter ....................... no
    152  EGL .................................... no
    153  OpenVG ................................. no
    154  OpenGL:
    155    Desktop OpenGL ....................... no
    156    OpenGL ES 2.0 ........................ no
    157    OpenGL ES 3.0 ........................ no
    158    OpenGL ES 3.1 ........................ no
    159    OpenGL ES 3.2 ........................ no
    160  Vulkan ................................. no
    161  Session Management ..................... no
    162Features used by QPA backends:
    163  evdev .................................. no
    164  libinput ............................... no
    165  HiRes wheel support in libinput ........ no
    166  INTEGRITY HID .......................... no
    167  mtdev .................................. no
    168  tslib .................................. no
    169  xkbcommon .............................. yes
    170  X11 specific:
    171    XLib ................................. no
    172    XCB Xlib ............................. no
    173    EGL on X11 ........................... no
    174    xkbcommon-x11 ........................ yes
    175    xcb-sm ............................... no
    176QPA backends:
    177  DirectFB ............................... no
    178  EGLFS .................................. no
    179  EGLFS details:
    180    EGLFS OpenWFD ........................ no
    181    EGLFS i.Mx6 .......................... no
    182    EGLFS i.Mx6 Wayland .................. no
    183    EGLFS RCAR ........................... no
    184    EGLFS EGLDevice ...................... no
    185    EGLFS GBM ............................ no
    186    EGLFS VSP2 ........................... no
    187    EGLFS Mali ........................... no
    188    EGLFS Raspberry Pi ................... no
    189    EGLFS X11 ............................ no
    190  LinuxFB ................................ no
    191  VNC .................................... no
    192  VK_KHR_display ......................... no
    193  QNX:
    194    lgmon ................................ no
    195    IMF .................................. no
    196  XCB:
    197    Using system-provided xcb-xinput ..... no
    198    GL integrations:
    199      GLX Plugin ......................... no
    200        XCB GLX .......................... no
    201      EGL-X11 Plugin ..................... no
    202  Windows:
    203    Direct 2D ............................ no
    204    Direct 2D 1.1 ........................ no
    205    DirectWrite .......................... no
    206    DirectWrite 3 ........................ no
    207Qt Widgets:
    208  GTK+ ................................... no
    209  Styles ................................. Fusion Windows
    210Qt Testlib:
    211  Tester for item models ................. yes
    212  Batch tests ............................ no
    213
    214
    215Note: Using static linking will disable the use of dynamically loaded plugins. Make sure to import all needed static plugins, or compile needed modules into the library.
    216Note: Disabling X11 Accessibility Bridge: D-Bus or AT-SPI is missing.
    217
    218ERROR: Feature "xcb": Forcing to "ON" breaks its condition:
    219    QT_FEATURE_thread AND TARGET XCB::XCB AND TEST_xcb_syslibs AND QT_FEATURE_xkbcommon_x11
    220Condition values dump:
    221    QT_FEATURE_thread = "ON"
    222    TARGET XCB::XCB found
    223    TEST_xcb_syslibs = "FALSE"
    224    QT_FEATURE_xkbcommon_x11 not evaluated
    225
    226
    227CMake Error at qtbase/cmake/QtBuildInformation.cmake:208 (message):
    228  Check the configuration messages for an error that has occurred.
    229Call Stack (most recent call first):
    230  qtbase/cmake/QtBuildInformation.cmake:39 (qt_configure_print_summary)
    231  qtbase/cmake/QtBaseTopLevelHelpers.cmake:84 (qt_print_feature_summary)
    232  qtbase/cmake/QtBaseTopLevelHelpers.cmake:72 (qt_internal_print_top_level_info)
    233  CMakeLists.txt:113 (qt_internal_top_level_end)
    234
    235
    236-- Configuring incomplete, errors occurred!
    237See also "/bitcoin/depends/work/build/x86_64-linux-gnu/qt/6.7.3-011bb3e2916/CMakeFiles/CMakeOutput.log".
    238See also "/bitcoin/depends/work/build/x86_64-linux-gnu/qt/6.7.3-011bb3e2916/CMakeFiles/CMakeError.log".
    239CMake Error at qtbase/cmake/QtProcessConfigureArgs.cmake:1077 (message):
    240  CMake exited with code 1.
    
  16. fanquake added this to the milestone 30.0 on Sep 24, 2025
  17. hebasto commented at 7:35 am on September 24, 2025: member

    Fixes #33432.

    The issue is titled “v30rc1 Weird GUI windowing behavior”, but libxcb-cursor0 is unrelated to it.


    Is there any particular reason to rush this PR into v30.0?

  18. maflcko added the label DrahtBot Guix build requested on Sep 24, 2025
  19. fanquake commented at 8:25 am on September 24, 2025: member

    but libxcb-cursor0 is unrelated to it.

    Installing libxcb-cursor fixes the windowing behaviour?

    Is there any particular reason to rush this PR into v30.0?

    I’d prefer if we were shipping a gui which didn’t require non technical users to install runtime dependencies.

  20. hebasto commented at 9:17 am on September 24, 2025: member

    but libxcb-cursor0 is unrelated to it.

    Installing libxcb-cursor fixes the windowing behaviour?

    No, it doesn’t. The user tested different binaries, rather than running the same binary with and without libxcb-cursor installed.

    Is there any particular reason to rush this PR into v30.0?

    I’d prefer if we were shipping a gui which didn’t require non technical users to install runtime dependencies.

    Right. And I’ll do my best to review this PR.

    However, I’m a bit reluctant to introduce such a change into rc3, as it leaves little time for broader testing.

  21. fanquake commented at 9:23 am on September 24, 2025: member

    No, it doesn’t. The user tested different binaries, rather than running the same binary with and without libxcb-cursor installed.

    The comment in this thread claims that a Guix build of this PR does not have the windowing bug: #33434 (comment)

  22. hebasto commented at 9:26 am on September 24, 2025: member

    No, it doesn’t. The user tested different binaries, rather than running the same binary with and without libxcb-cursor installed.

    The comment in this thread claims that a Guix build of this PR does not have the windowing bug: #33434 (comment)

    Sure. It never had it. The windowing bug is observed when using Qt 6.4.2 on Ubuntu.

  23. fanquake commented at 9:29 am on September 24, 2025: member
    The initial issue was for a Guix built binary though: #33434 (comment) ?
  24. hebasto commented at 9:34 am on September 24, 2025: member

    The initial issue was for a Guix built binary though: #33434 (comment) ?

    That comment doesn’t make sense: “install libxcb-cursor0” cannot result in “removed dark mode”. The user likely mixed up the binaries they ran.

  25. hebasto commented at 10:11 am on September 24, 2025: member
    Concept ACK. This is consistent with our docs.
  26. hebasto commented at 10:58 am on September 24, 2025: member

    @laanwj

    You might want to take a look at this PR.

  27. hebasto commented at 12:36 pm on September 24, 2025: member

    @davidgumberg

    Trying to do a guix build on this branch I get the following error: …

    What’s the architecture of your build platform?

  28. hebasto commented at 12:41 pm on September 24, 2025: member

    This library is no-longer present on modern Ubuntu.

    Specifically, the Ubuntu 24.04.3 LTS image from https://ubuntu.com/download/desktop does not install libxcb-cursor0 when using the “Default selection” install option.

  29. hebasto commented at 4:16 pm on September 24, 2025: member

    My Guix builds for Linux hosts on both aarch64 and x86_64 platforms:

     0cf7f86d91288477c11afdc767969d6b19b0ba1e62c73924e72b22a2527374653  guix-build-eca50854e1cb/output/aarch64-linux-gnu/SHA256SUMS.part
     15afe50eb76079f96a5129b5e51e2ede657f10c5031abe24a875410f006c55511  guix-build-eca50854e1cb/output/aarch64-linux-gnu/bitcoin-eca50854e1cb-aarch64-linux-gnu-debug.tar.gz
     2ba6f7937c5d333e64560abcd95dbb3856ceaa43fbcde766ebcaed1f8e23f2a7e  guix-build-eca50854e1cb/output/aarch64-linux-gnu/bitcoin-eca50854e1cb-aarch64-linux-gnu.tar.gz
     3bbdf057a0b42636765dc4c2e005c955e2b4fa826ea06f649bb6b48dd6dc45d7a  guix-build-eca50854e1cb/output/arm-linux-gnueabihf/SHA256SUMS.part
     47e9d8983db8ee44f5812f9192adca09160acc8a1f0dc07be9b67169896fc15fe  guix-build-eca50854e1cb/output/arm-linux-gnueabihf/bitcoin-eca50854e1cb-arm-linux-gnueabihf-debug.tar.gz
     5135775299474f11f969dbb4f219cfb485ebba5b190f1d558e62eb3311ed7c686  guix-build-eca50854e1cb/output/arm-linux-gnueabihf/bitcoin-eca50854e1cb-arm-linux-gnueabihf.tar.gz
     6c12073eeb266e309c7669e084d13cec0e5e2224821c3f27d20f600f870ecf19d  guix-build-eca50854e1cb/output/dist-archive/bitcoin-eca50854e1cb.tar.gz
     774e2670cae2f374a83ecf9b554bf9e5513ed957807cbc0073003a22635e5e451  guix-build-eca50854e1cb/output/powerpc64-linux-gnu/SHA256SUMS.part
     85bbb70440153087cbb737d7f0194ddff93f9c4d1cf3d928a9eee64f065d27184  guix-build-eca50854e1cb/output/powerpc64-linux-gnu/bitcoin-eca50854e1cb-powerpc64-linux-gnu-debug.tar.gz
     93ffe08f501112496a1a72ab9a4a328b294e845fc7ef6b01215234c862289a863  guix-build-eca50854e1cb/output/powerpc64-linux-gnu/bitcoin-eca50854e1cb-powerpc64-linux-gnu.tar.gz
    10c288d11acf623eace1d033b9706af7e58f445571bb855d0f418557660a244d01  guix-build-eca50854e1cb/output/riscv64-linux-gnu/SHA256SUMS.part
    112e7613024ca7d09165f14b93a455f811f819bc0ce533173149a6b15737fbfcc6  guix-build-eca50854e1cb/output/riscv64-linux-gnu/bitcoin-eca50854e1cb-riscv64-linux-gnu-debug.tar.gz
    125e2e71715ca94ef496c6c74db837f76185446cae02992b45de2cd23eb85b4aea  guix-build-eca50854e1cb/output/riscv64-linux-gnu/bitcoin-eca50854e1cb-riscv64-linux-gnu.tar.gz
    136ea9d32fd447fafef15c83e419c2c4cb2e2bcc168b07f8e71c4f8cc93c15982c  guix-build-eca50854e1cb/output/x86_64-linux-gnu/SHA256SUMS.part
    146d765b1f8191c9bfe030b6c9df01e955bfa5e16683dba61dcfe33b4cd585803a  guix-build-eca50854e1cb/output/x86_64-linux-gnu/bitcoin-eca50854e1cb-x86_64-linux-gnu-debug.tar.gz
    15573aa76d009263d4484baa7404b86fb260636a9e778745846099625b91a69378  guix-build-eca50854e1cb/output/x86_64-linux-gnu/bitcoin-eca50854e1cb-x86_64-linux-gnu.tar.gz
    
  30. DrahtBot commented at 12:35 pm on September 26, 2025: contributor

    Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

    File commit d41b503ae128ac36ef27e652d2935c6fe7981a79(master) commit 750e71858268450bf6c516afd624c9cf257c505d(pull/33434/merge)
    *-aarch64-linux-gnu-debug.tar.gz 8f3a40cb7e5a59be... 3d6d7e508d2e690f...
    *-aarch64-linux-gnu.tar.gz 9b439381e394581e... d7639a5e8e5b1f14...
    *-arm-linux-gnueabihf-debug.tar.gz bed36adf3e4624b8... 24b9bfdbbd5f06b5...
    *-arm-linux-gnueabihf.tar.gz 045e0c8edb59fa05... 4e6c2a75b7d3bc4d...
    *-arm64-apple-darwin-codesigning.tar.gz 5f94335fb54aedc2... c9f4594c9a9bdc60...
    *-arm64-apple-darwin-unsigned.tar.gz 069c857475b6aa81... 5028860471cc6613...
    *-arm64-apple-darwin-unsigned.zip 30a09bd941c23417... 7a2314ee16256951...
    *-powerpc64-linux-gnu-debug.tar.gz 0fee83e9a4c1f221... 56349f084abdd871...
    *-powerpc64-linux-gnu.tar.gz 6bda2ecee92a584d... 95c961b422ba4f19...
    *-riscv64-linux-gnu-debug.tar.gz 9174e3e001abf18f... 8a2d040178513cab...
    *-riscv64-linux-gnu.tar.gz 1f3a7afe7aba88c5... 833c875817fc8048...
    *-x86_64-apple-darwin-codesigning.tar.gz e202dc9667188619... 9b1ce289ce7ddd5e...
    *-x86_64-apple-darwin-unsigned.tar.gz a44ad3b531a7367d... b694ffe6128535b0...
    *-x86_64-apple-darwin-unsigned.zip 71a7d839d9349fa9... 72b69057d0281aef...
    *-x86_64-linux-gnu-debug.tar.gz 787a6b89477e2a9f... 34e0b620c847d2f7...
    *-x86_64-linux-gnu.tar.gz 1415bd1abe44cf1e... cf1f1c54bdf3ff35...
    *.tar.gz a5d7916ec9ae2b17... 055e2fd900203de9...
    SHA256SUMS.part 636162bfe0bbdb81... e6ff5e02ab01682e...
    guix_build.log f0a52f8f5f1ea0ce... 06dca0dd21d1a474...
    guix_build.log.diff 28e4ad9f7601dcad...
  31. DrahtBot removed the label DrahtBot Guix build requested on Sep 26, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-26 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me