bitcoin-wallet
as-is is merely an offline wallet inspection tool (introduced more than 9 years ago in PR #13926) that doesn’t have any relation with IPC/multiprocess, so remove it from the list of binaries that use libbitcoin_ipc
.
bitcoin-wallet
binary from libbitcoin_ipc
description
#33459
`bitcoin-wallet` as-is is merely an offline wallet inspection tool
(introduced more than 9 years ago in PR #13926) that doesn't have any
relation with IPC/multiprocess, so remove it from the list of binaries
that use `libbitcoin_ipc`.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33459.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
ACK | pablomartin4btc |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
ACK fbde8d9a81d82e53933fe45e36d3a70206a48e0e
I agree that the tool is unrelated to IPC/ multiprocess, so removing it from the list of binaries that use libbitcoin_ipc is appropriate. As an offline wallet utility, it doesn’t provide full “management” like a running wallet RPC (no sending, no RPC-based operations); its capabilities are basically limited to creating wallets, showing wallet details, and importing/exporting wallet data.
theStack
DrahtBot
pablomartin4btc
fanquake
Labels
Docs