bitcoin-wallet as-is is merely an offline wallet inspection tool (introduced more than 9 years ago in PR #13926) that doesn't have any relation with IPC/multiprocess, so remove it from the list of binaries that use libbitcoin_ipc.
doc: remove unrelated `bitcoin-wallet` binary from `libbitcoin_ipc` description #33459
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202509-doc-ipc-remove-bitcoin_wallet changing 1 files +1 −1-
theStack commented at 7:16 PM on September 22, 2025: contributor
-
fbde8d9a81
doc: remove unrelated `bitcoin-wallet` binary from `libbitcoin_ipc` description
`bitcoin-wallet` as-is is merely an offline wallet inspection tool (introduced more than 9 years ago in PR #13926) that doesn't have any relation with IPC/multiprocess, so remove it from the list of binaries that use `libbitcoin_ipc`.
- DrahtBot added the label Docs on Sep 22, 2025
-
DrahtBot commented at 7:16 PM on September 22, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33459.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK pablomartin4btc If your review is incorrectly listed, please react with đź‘Ž to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
pablomartin4btc commented at 3:17 AM on September 23, 2025: member
ACK fbde8d9a81d82e53933fe45e36d3a70206a48e0e
I agree that the tool is unrelated to IPC/ multiprocess, so removing it from the list of binaries that use libbitcoin_ipc is appropriate. As an offline wallet utility, it doesn’t provide full “management” like a running wallet RPC (no sending, no RPC-based operations); its capabilities are basically limited to creating wallets, showing wallet details, and importing/exporting wallet data.
-
- fanquake merged this on Sep 23, 2025
- fanquake closed this on Sep 23, 2025
- fanquake referenced this in commit b044d9d63c on Sep 23, 2025
- theStack deleted the branch on Sep 23, 2025
