The lower-case spelling matches the decodepsbt result field:
https://github.com/bitcoin/bitcoin/blob/200150beba6601237036bc01ee10f6a0a2246c3d/src/rpc/rawtransaction.cpp#L871
https://github.com/bitcoin/bitcoin/blob/200150beba6601237036bc01ee10f6a0a2246c3d/src/rpc/rawtransaction.cpp#L1253
doc: rpc: fix case typo in `finalizepsbt` help (final_scriptwitness) #33484
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202509-rpc-doc-fix_finalizepsbt_case_typo_scriptwitness changing 1 files +1 −1-
theStack commented at 5:38 PM on September 26, 2025: contributor
-
doc: rpc: fix case typo in `finalizepsbt` help (final_scriptwitness) ff05bebcc4
- DrahtBot added the label Docs on Sep 26, 2025
-
DrahtBot commented at 5:38 PM on September 26, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33484.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- l0rinc approved
-
l0rinc commented at 5:59 PM on September 26, 2025: contributor
ACK ff05bebcc4262966b117082a67dc4c63a3f67d2d
The doc seems to be the only mention of
final_scriptWitness, every other one is indeedfinal_scriptwitness- seems it was added incorrectly in https://github.com/bitcoin/bitcoin/commit/c27fe419efb3b6588c400d764122ffb33375e028#diff-a58e7bb9d9a8a0287c0b7281d99da4e79b6f8c2a5780c24c6d76c14212c48640R1624 - rkrux approved
-
rkrux commented at 7:07 AM on September 27, 2025: contributor
Ah crACK ff05bebcc4262966b117082a67dc4c63a3f67d2d
There are two different kinds of spellings in the
decodepsbtresponse. - fanquake merged this on Sep 28, 2025
- fanquake closed this on Sep 28, 2025
- fanquake referenced this in commit b75afaccb8 on Sep 28, 2025
-
- theStack deleted the branch on Sep 28, 2025
Labels