It’s been 2 weeks since rc1: https://github.com/bitcoin/bitcoin/releases/tag/v29.2rc1. We’ve backported more changes:
Lets do rc2
.
It’s been 2 weeks since rc1: https://github.com/bitcoin/bitcoin/releases/tag/v29.2rc1. We’ve backported more changes:
Lets do rc2
.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33534.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
ACK | glozow, davidgumberg, darosior |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
QT translations are optional, but the script would error when
'translations_dir' falls back to its default value NULL.
This PR fixes it by moving the set-up of QT translations under
the check for 'translations_dir' presence.
Github-Pull: #33482
Rebased-From: 7b5261f7ef3d88361204c40eb10c0d9dc44f5ed7
ACK https://github.com/bitcoin/bitcoin/pull/33534/commits/513cef75ee06bc5d310a22d366a5f3c815aa1499
I compared this to other PR’s (#32766) of the “finalize format”, and this has the two finalizing chagnes:
I compared the backport commit https://github.com/bitcoin/bitcoin/pull/33534/commits/6b3c1dbc5c0df4357ee7f57ac238bcdff55526af to https://github.com/bitcoin/bitcoin/pull/33482/commits/7b5261f7ef3d88361204c40eb10c0d9dc44f5ed7 from #33482.
lgtm 513cef75ee06bc5d310a22d366a5f3c815aa1499. Got the same manpages, no changes to examples/bitcoin.conf or bips.md.
I think the release notes need to be updated