[29.x] Finalise 29.2rc2 #33534

pull fanquake wants to merge 4 commits into bitcoin:29.x from fanquake:final_29_2_rc2 changing 9 files +31 −27
  1. fanquake commented at 1:42 pm on October 3, 2025: member

    It’s been 2 weeks since rc1: https://github.com/bitcoin/bitcoin/releases/tag/v29.2rc1. We’ve backported more changes:

    Lets do rc2.

  2. fanquake added this to the milestone 29.2 on Oct 3, 2025
  3. DrahtBot added the label Backport on Oct 3, 2025
  4. DrahtBot commented at 1:42 pm on October 3, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33534.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK glozow, davidgumberg, darosior

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. contrib: fix using macdploy script without translations.
    QT translations are optional, but the script would error when
    'translations_dir' falls back to its default value NULL.
    
    This PR fixes it by moving the set-up of QT translations under
    the check for 'translations_dir' presence.
    
    Github-Pull: #33482
    Rebased-From: 7b5261f7ef3d88361204c40eb10c0d9dc44f5ed7
    6b3c1dbc5c
  6. build: bump version to v29.2rc2 eea16f7de7
  7. doc: update manual pages for v29.2rc2 513cef75ee
  8. fanquake force-pushed on Oct 3, 2025
  9. davidgumberg commented at 3:57 pm on October 3, 2025: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/33534/commits/513cef75ee06bc5d310a22d366a5f3c815aa1499

    I compared this to other PR’s (#32766) of the “finalize format”, and this has the two finalizing chagnes:

    • this bumps the build version in the 29.x branch
    • updates the versions in the manpages.

    I compared the backport commit https://github.com/bitcoin/bitcoin/pull/33534/commits/6b3c1dbc5c0df4357ee7f57ac238bcdff55526af to https://github.com/bitcoin/bitcoin/pull/33482/commits/7b5261f7ef3d88361204c40eb10c0d9dc44f5ed7 from #33482.

  10. in contrib/macdeploy/macdeployqtplus:1 in 6b3c1dbc5c outdated


    glozow commented at 4:57 pm on October 3, 2025:
    Need to update release notes for #33482, no?

    glozow commented at 5:02 pm on October 3, 2025:
    I also don’t see #32989

    fanquake commented at 5:05 pm on October 3, 2025:
    Added a commit.
  11. glozow commented at 5:01 pm on October 3, 2025: member

    lgtm 513cef75ee06bc5d310a22d366a5f3c815aa1499. Got the same manpages, no changes to examples/bitcoin.conf or bips.md.

    I think the release notes need to be updated

  12. doc: update release notes for 29.2rc2 d82fc69829
  13. fanquake force-pushed on Oct 3, 2025
  14. glozow commented at 5:10 pm on October 3, 2025: member
    ACK d82fc69829cd8cabbaf2c3a969597b40c32edc86
  15. DrahtBot requested review from davidgumberg on Oct 3, 2025
  16. davidgumberg commented at 5:12 pm on October 3, 2025: contributor
    reACK d82fc69
  17. darosior approved
  18. darosior commented at 5:15 pm on October 3, 2025: member
    utACK d82fc69829cd8cabbaf2c3a969597b40c32edc86. Changes look good to me, but i have not been through the process of regenerating the doc myself.
  19. DrahtBot requested review from darosior on Oct 3, 2025
  20. glozow merged this on Oct 3, 2025
  21. glozow closed this on Oct 3, 2025

  22. fanquake deleted the branch on Oct 3, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-10 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me