Backports:
[28.x] More backports #33535
pull fanquake wants to merge 4 commits into bitcoin:28.x from fanquake:28_3_rc2_backports changing 4 files +58 −36-
fanquake commented at 3:18 pm on October 3, 2025: member
-
fuzz: don't bypass_limits for most mempool harnesses
Using bypass_limits=true is essentially fuzzing part of a reorg only, and results in TRUC invariants unable to be checked. Remove most instances of bypassing limits, leaving one harness able to do so. Github-Pull: #33504 Rebased-From: bbe8e9063c15dc230553e0cbf16d603f5ad0e4cf
-
Mempool: Do not enforce TRUC checks on reorg
Not enforcing TRUC topology on reorg was the intended behavior, but the appropriate bypass argument was not checked. This mistake means we could potentially invalidate a long chain of perfectly incentive-compatible transactions that were made historically, including subsequent non-TRUC transactions, all of which may have been very high feerate. Lastly, it wastes CPU cycles doing topology checks since this behavior cannot actually enforce the topology in general for the reorg setting. Github-Pull: #33504 Rebased-From: 26e71c237d9d2197824b547f55ee3a0a60149f92
-
test: add more TRUC reorg coverge
Github-Pull: #33504 Rebased-From: 06df14ba75be5f48cf9c417424900ace17d1cf4d
-
doc: update release notes for 28.x 06fe49dc88
-
fanquake added this to the milestone 28.3 on Oct 3, 2025
-
DrahtBot added the label Backport on Oct 3, 2025
-
DrahtBot commented at 3:18 pm on October 3, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33535.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK darosior, dergoegge, instagibbs If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
LLM Linter (✨ experimental)
Possible typos and grammar issues:
- do not do TRUC invariants checks -> do not perform TRUC invariant checks [plural/syntax error: “invariants checks” is ungrammatical; “perform” is clearer than repeated “do”]
drahtbot_id_5_m
-
darosior approved
-
darosior commented at 5:27 pm on October 3, 2025: memberutACK 06fe49dc88638e2ad21f1b7d0dd87661de384517.
-
dergoegge approved
-
dergoegge commented at 3:23 am on October 4, 2025: memberACK 06fe49dc88638e2ad21f1b7d0dd87661de384517
-
instagibbs approved
-
instagibbs commented at 4:19 pm on October 6, 2025: memberACK 06fe49dc88638e2ad21f1b7d0dd87661de384517
-
fanquake marked this as ready for review on Oct 7, 2025
-
fanquake merged this on Oct 7, 2025
-
fanquake closed this on Oct 7, 2025
-
fanquake deleted the branch on Oct 7, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-10 15:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-10 15:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me