[28.x] 28.3rc2 #33557

pull fanquake wants to merge 5 commits into bitcoin:28.x from fanquake:28_3_rc2 changing 11 files +33 −30
  1. fanquake commented at 10:09 am on October 7, 2025: member

    Backports:

    Plus final changes for a 28.3rc2.

  2. fanquake added this to the milestone 28.3 on Oct 7, 2025
  3. DrahtBot added the label Backport on Oct 7, 2025
  4. DrahtBot commented at 10:09 am on October 7, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33557.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK stickies-v, marcofleon
    Stale ACK dergoegge

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. fanquake force-pushed on Oct 7, 2025
  6. contrib: fix using macdploy script without translations.
    QT translations are optional, but the script would error when
    'translations_dir' falls back to its default value NULL.
    
    This PR fixes it by moving the set-up of QT translations under
    the check for 'translations_dir' presence.
    
    Github-Pull: #33482
    Rebased-From: 7b5261f7ef3d88361204c40eb10c0d9dc44f5ed7
    ae8605825f
  7. build: fix depends Qt download link
    Github-Pull: #33563
    Rebased-From: abf4a6eeaee116917dafd56eb9caee03e13048d2
    9c911f7e2d
  8. build: bump version to 28.3rc2 e2e1138350
  9. doc: update manual pages for v28.3rc2 201221b750
  10. fanquake force-pushed on Oct 7, 2025
  11. fanquake marked this as ready for review on Oct 10, 2025
  12. dergoegge approved
  13. dergoegge commented at 7:57 am on October 13, 2025: member
    ACK 8e4651bb33b8f97940bf2ad6a2f97932198f6765
  14. marcofleon approved
  15. marcofleon commented at 10:12 am on October 13, 2025: contributor
    ACK 8e4651bb33b8f97940bf2ad6a2f97932198f6765
  16. in doc/release-notes.md:1 in 8e4651bb33 outdated


    stickies-v commented at 11:02 am on October 13, 2025:

    Download link on l3 needs to be updated:

     0diff --git a/doc/release-notes.md b/doc/release-notes.md
     1index b8b90475c8..f446c14cc5 100644
     2--- a/doc/release-notes.md
     3+++ b/doc/release-notes.md
     4@@ -1,6 +1,6 @@
     5 Bitcoin Core version 28.3rc2 is now available from:
     6 
     7-  <https://bitcoincore.org/bin/bitcoin-core-28.3/test.rc1/>
     8+  <https://bitcoincore.org/bin/bitcoin-core-28.3/test.rc2/>
     9 
    10 This release includes various bug fixes and performance
    11 improvements, as well as updated translations.
    
  17. stickies-v approved
  18. stickies-v commented at 11:03 am on October 13, 2025: contributor

    ACK 8e4651bb33b8f97940bf2ad6a2f97932198f6765 modulo 1 link update required (see comment)

    All backports clean except:

    • 9c911f7e2dcb6dc26b5824bdae2d389cc931607e backported from abf4a6eeaee116917dafd56eb9caee03e13048d2: merge conflict due to qt being bumped to 5.15.16 on master and still at 5.15.14 on 28.x.

    Getting identical manpages, and release notes look complete.

  19. doc: update release notes for 28.x 44d05b2fb2
  20. fanquake force-pushed on Oct 13, 2025
  21. stickies-v approved
  22. stickies-v commented at 11:09 am on October 13, 2025: contributor
    re-ACK 44d05b2fb25b0a5f14e7487c792ac25ad5f5c284
  23. DrahtBot requested review from marcofleon on Oct 13, 2025
  24. DrahtBot requested review from dergoegge on Oct 13, 2025
  25. marcofleon commented at 11:22 am on October 13, 2025: contributor
    Nice, re ACK 44d05b2fb25b0a5f14e7487c792ac25ad5f5c284
  26. fanquake merged this on Oct 13, 2025
  27. fanquake closed this on Oct 13, 2025

  28. fanquake deleted the branch on Oct 13, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-31 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me