Backports:
Plus final changes for a 28.3rc2.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33557.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | stickies-v, marcofleon |
| Stale ACK | dergoegge |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
QT translations are optional, but the script would error when
'translations_dir' falls back to its default value NULL.
This PR fixes it by moving the set-up of QT translations under
the check for 'translations_dir' presence.
Github-Pull: #33482
Rebased-From: 7b5261f7ef3d88361204c40eb10c0d9dc44f5ed7
Github-Pull: #33563
Rebased-From: abf4a6eeaee116917dafd56eb9caee03e13048d2
Download link on l3 needs to be updated:
0diff --git a/doc/release-notes.md b/doc/release-notes.md
1index b8b90475c8..f446c14cc5 100644
2--- a/doc/release-notes.md
3+++ b/doc/release-notes.md
4@@ -1,6 +1,6 @@
5 Bitcoin Core version 28.3rc2 is now available from:
6
7- <https://bitcoincore.org/bin/bitcoin-core-28.3/test.rc1/>
8+ <https://bitcoincore.org/bin/bitcoin-core-28.3/test.rc2/>
9
10 This release includes various bug fixes and performance
11 improvements, as well as updated translations.
ACK 8e4651bb33b8f97940bf2ad6a2f97932198f6765 modulo 1 link update required (see comment)
All backports clean except:
5.15.16 on master and still at 5.15.14 on 28.x.Getting identical manpages, and release notes look complete.