ci: Properly include $FILE_ENV in DEPENDS_HASH #33581

1. 
   achow101 commented at 9:49 pm on October 8, 2025: member

   $FILE_ENV has a full relative path already, prepending with ci/test/ results in a non-existent path which means that DEPENDS_HASH was not actually committing to the test’s environment file.
2. ci: Properly include $FILE_ENV in DEPENDS_HASH

   $FILE_ENV has a full relative path already, prepending with ci/test/
   results in a non-existent path which means that DEPENDS_HASH was not
   actually committing to the test's environment file.

   ceeb53adcd
3. DrahtBot added the label Tests on Oct 8, 2025
4. 
   DrahtBot commented at 9:49 pm on October 8, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33581.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. 
   maflcko commented at 6:47 am on October 9, 2025: member

   No idea what the unrelated intermittent CI failure is about: https://github.com/bitcoin/bitcoin/actions/runs/18358988770/job/52298824086?pr=33581#step:12:287 It just seems to stop during the very first init of bitcoind.exe.
6. 
   maflcko commented at 6:56 am on October 9, 2025: member

   Nice catch. Tested via:

   0sh-5.2$ ( export FILE_ENV="./ci/test/00_setup_env_win64.sh" && git ls-tree HEAD depends "ci/test/$FILE_ENV" | sha256sum | cut -d' ' -f1 )
   19e598ae5c5f89396b330088c224cd5e1b391f8d101906c0270a48fa3acbdce07
   2
   3sh-5.2$ ( export FILE_ENV="./ci/test/00_setup_env_win64.sh" && git ls-tree HEAD depends "$FILE_ENV" | sha256sum | cut -d' ' -f1 )
   46e4783c2f98f56e05e4b0d535b1709fce7c5f318a67932b0c8ed7a34b0a7ffbb
   

   First the erroneous hash, and then the intended hash, both of which are consistent with the output on GHA:

   • https://github.com/bitcoin/bitcoin/actions/runs/18329414346/job/52201316933#step:5:18
   • https://github.com/bitcoin/bitcoin/actions/runs/18358988770/job/52298114859?pr=33581#step:5:18

   lgtm ACK ceeb53adcd0a6a87a65c8ebbb20472c15c502dfd

7. fanquake merged this on Oct 9, 2025
8. fanquake closed this on Oct 9, 2025

   ---

9. fanquake referenced this in commit 00a4865167 on Oct 13, 2025
10. 
    fanquake commented at 2:54 pm on October 13, 2025: member

    Backported to 30.x in #33609.
11. fanquake referenced this in commit c7979f429a on Oct 13, 2025
12. 
    fanquake commented at 3:26 pm on October 13, 2025: member

    Backported to 29.x in #33611.
13. fanquake referenced this in commit 1c521ae922 on Oct 13, 2025
14. 
    fanquake commented at 4:05 pm on October 13, 2025: member

    Backported to 28.x in #33613.
15. 
    5girlstaken-arch commented at 10:30 pm on October 15, 2025: none

    00000020 a6f5e4d3c2b1a0f9e8d7c6b5a4938271605f4e3d2c1b0a000000000000000000 04f15068366fba1de4c323bb6ca4fe58c7d968d81688abf68380bddf46fd4ef0 a08fee68 6a5d0f17 00010007
16. bitcoin deleted a comment on Oct 16, 2025

Contributors
achow101 DrahtBot maflcko fanquake 5girlstaken-arch

Labels
Tests