$FILE_ENV has a full relative path already, prepending with ci/test/ results in a non-existent path which means that DEPENDS_HASH was not actually committing to the test's environment file.
ci: Properly include $FILE_ENV in DEPENDS_HASH #33581
pull achow101 wants to merge 1 commits into bitcoin:master from achow101:ci-depends-hash-file-env changing 1 files +1 −1-
achow101 commented at 9:49 PM on October 8, 2025: member
-
ceeb53adcd
ci: Properly include $FILE_ENV in DEPENDS_HASH
$FILE_ENV has a full relative path already, prepending with ci/test/ results in a non-existent path which means that DEPENDS_HASH was not actually committing to the test's environment file.
- DrahtBot added the label Tests on Oct 8, 2025
-
DrahtBot commented at 9:49 PM on October 8, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33581.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
maflcko commented at 6:47 AM on October 9, 2025: member
No idea what the unrelated intermittent CI failure is about: https://github.com/bitcoin/bitcoin/actions/runs/18358988770/job/52298824086?pr=33581#step:12:287 It just seems to stop during the very first init of bitcoind.exe.
-
maflcko commented at 6:56 AM on October 9, 2025: member
Nice catch. Tested via:
sh-5.2$ ( export FILE_ENV="./ci/test/00_setup_env_win64.sh" && git ls-tree HEAD depends "ci/test/$FILE_ENV" | sha256sum | cut -d' ' -f1 ) 9e598ae5c5f89396b330088c224cd5e1b391f8d101906c0270a48fa3acbdce07 sh-5.2$ ( export FILE_ENV="./ci/test/00_setup_env_win64.sh" && git ls-tree HEAD depends "$FILE_ENV" | sha256sum | cut -d' ' -f1 ) 6e4783c2f98f56e05e4b0d535b1709fce7c5f318a67932b0c8ed7a34b0a7ffbbFirst the erroneous hash, and then the intended hash, both of which are consistent with the output on GHA:
- https://github.com/bitcoin/bitcoin/actions/runs/18329414346/job/52201316933#step:5:18
- https://github.com/bitcoin/bitcoin/actions/runs/18358988770/job/52298114859?pr=33581#step:5:18
lgtm ACK ceeb53adcd0a6a87a65c8ebbb20472c15c502dfd
- fanquake merged this on Oct 9, 2025
- fanquake closed this on Oct 9, 2025
- fanquake referenced this in commit 00a4865167 on Oct 13, 2025
-
- fanquake referenced this in commit c7979f429a on Oct 13, 2025
-
- fanquake referenced this in commit 1c521ae922 on Oct 13, 2025
-
-
5girlstaken-arch commented at 10:30 PM on October 15, 2025: none
00000020 a6f5e4d3c2b1a0f9e8d7c6b5a4938271605f4e3d2c1b0a000000000000000000 04f15068366fba1de4c323bb6ca4fe58c7d968d81688abf68380bddf46fd4ef0 a08fee68 6a5d0f17 00010007
- bitcoin deleted a comment on Oct 16, 2025
