Release notes:https://github.com/actions/download-artifact/releases/tag/v5.0.0
Change: uses: actions/download-artifact@v4 -> uses: actions/download-artifact@v5
Release notes:https://github.com/actions/download-artifact/releases/tag/v5.0.0
Change: uses: actions/download-artifact@v4 -> uses: actions/download-artifact@v5
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33584.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | hebasto, maflcko, willcl-ark |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
ACK b35341b9ba63a0108596e56e9eecc851a4558d98, I have reviewed the code and it looks OK.
I think this might be updated as well: https://github.com/bitcoin/bitcoin/blob/b510893d00760083ac36948747aa6ebd84656192/.github/actions/configure-docker/action.yml#L22
cc @willcl-ark
Missing ci: prefix in pull title? Otherwise:
lgtm ACK b35341b9ba63a0108596e56e9eecc851a4558d98
ACK b35341b9ba63a0108596e56e9eecc851a4558d98
I don't see the reason to upgrade this action (nor actions/github-script@v6) as the changes in both don't concern our usage of the actions, but neither upgrade seems harmful either.