ci: Lint follow-ups #33776

1. 
   maflcko commented at 1:30 pm on November 4, 2025: member

   This contains a few follow-ups to #33744:

   • Rewrite the actions Bash snippet to Python. I’ve confirmed it still works in https://github.com/maflcko/bitcoin-core-with-ci/actions/runs/19067932430 (scroll down).
   • Add a lint-build retry to avoid issues such as #33640 for the lint task as well.
   • Finally, run the debug_pull_request_number_str annotation on all checks, to ensure they are present even when GitHub deletes annotations on a re-run. For example, the initial attempt https://github.com/bitcoin/bitcoin/actions/runs/19041534107/attempts/1?pr=33772 has the annotations, and the lint re-run has them removed: https://github.com/bitcoin/bitcoin/actions/runs/19041534107?pr=33772
2. ci: Rewrite Bash to check inputs to Python

   This is shorter and easier to read. Also, according to the dev notes,
   Bash should not be used.

   fa78d08eb8
3. DrahtBot added the label Tests on Nov 4, 2025
4. 
   DrahtBot commented at 1:30 pm on November 4, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33776.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

5. maflcko force-pushed on Nov 4, 2025
6. DrahtBot added the label CI failed on Nov 4, 2025
7. 
   fanquake commented at 1:57 pm on November 4, 2025: member

   cc @willcl-ark @m3dwards
8. DrahtBot removed the label CI failed on Nov 4, 2025
9. ci: Rewrite lint task Bash snippet to Python

   The Bash snippet was shorter, but relying on implicit word splitting
   (see the shellcheck SC2086 warning).
   
   For example, the DOCKER_BUILD_CACHE_ARG shlex.split is now done
   identical to how ci/test/02_run_container.py does it.
   
   Moreover, the Python will hopefully be easier to modify in the future,
   as the dev notes recommend Python over Bash.

   faec6063cd
10. ci: Retry lint image building once after failure

    The same was done for the other CI tasks in commit fa6aa9f42fa. This may
    guard against intermittent network issues to download the base image or
    packages ...

    faac15a872
11. ci: Annotate all check runs with the pull request number

    On check re-runs the annotations are discarded, so all check runs
    require the number to be set.

    fa56677469
12. maflcko force-pushed on Nov 7, 2025

Contributors
maflcko DrahtBot fanquake

Labels
Tests