scripted-diff: fix leftover references to policy/fees.h #33864

1. 
   ismaelsadeeq commented at 5:43 pm on November 12, 2025: member

   Fixes #33863

   ryanofsky wrote

   I still see some references to the src/policy/fees.h file removed by this PR:

   0$ git grep -n policy/fees.h
   1src/wallet/rpc/spend.cpp:206: * [@param](/bitcoin-bitcoin/contributor/param/)[in]     conf_target       UniValue integer; confirmation target in blocks, values between 1 and 1008 are valid per policy/fees.h;
   2test/functional/rpc_estimatefee.py:39:        # max value of 1008 per src/policy/fees.h
   3test/functional/rpc_psbt.py:604:                assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008",  # max value of 1008 per src/policy/fees.h
   4test/functional/wallet_basic.py:337:            assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008",  # max value of 1008 per src/policy/fees.h
   5test/functional/wallet_fundrawtransaction.py:851:                assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008",  # max value of 1008 per src/policy/fees.h
   6test/functional/wallet_send.py:315:                expect_error=(-8, "Invalid conf_target, must be between 1 and 1008"))  # max value of 1008 per src/policy/fees.h
   

   This is fixed in this PR by running a script that searches for what he greps and replaces it with the right reference.

   0git grep -l "policy\/fees\.h" | xargs sed -i "s/policy\/fees.h/policy\/fees\/block_policy_estimator.h/g"
   

2. scripted-diff: fix leftover references to `policy/fees.h`

   -BEGIN VERIFY SCRIPT-
   git grep -l "policy\/fees\.h" | xargs sed -i "s/policy\/fees.h/policy\/fees\/block_policy_estimator.h/g"
   -END VERIFY SCRIPT-

   b0a3887154
3. DrahtBot added the label Refactoring on Nov 12, 2025
4. ismaelsadeeq marked this as ready for review on Nov 12, 2025
5. 
   DrahtBot commented at 5:44 pm on November 12, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33864.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	kevkevinpal, janb84, rkrux
   Concept ACK	vicjuma

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

6. 
   kevkevinpal commented at 6:21 pm on November 12, 2025: contributor

   ACK b0a3887

   A doc change and scripted-diff are pretty straightforward

7. 
   janb84 commented at 7:44 pm on November 12, 2025: contributor

   ACK b0a38871546dfcdd3a578c1ae4c28a88b6ee32d5

   Trivial cleanup PR. This time I did some extra code searches to find any possible leftovers, could not find one.

8. 
   vicjuma commented at 8:21 pm on November 12, 2025: none

   ACK the OP’s latest commit.

   Confirmed that git grep "policy/fees.h" does not return any lines, meaning that the solution works.

   git grep -l “policy/fees.h” | xargs sed -i “s/policy/fees.h/policy/fees/block_policy_estimator.h/g”

9. rkrux approved
10. 
    rkrux commented at 7:24 am on November 13, 2025: contributor

    lgtm ACK b0a38871546dfcdd3a578c1ae4c28a88b6ee32d5
11. fanquake merged this on Nov 13, 2025
12. fanquake closed this on Nov 13, 2025

    ---

13. 
    ryanofsky commented at 1:03 pm on November 13, 2025: contributor

    Thanks for the cleanup!
14. ismaelsadeeq deleted the branch on Nov 14, 2025

Contributors
ismaelsadeeq DrahtBot kevkevinpal janb84 vicjuma rkrux ryanofsky

Labels
Refactoring