scripted-diff: fix leftover references to `policy/fees.h` #33864

Fixes #33863

ryanofsky wrote

I still see some references to the src/policy/fees.h file removed by this PR:

$ git grep -n policy/fees.h
src/wallet/rpc/spend.cpp:206: * [@param](/bitcoin-bitcoin/contributor/param/)[in]     conf_target       UniValue integer; confirmation target in blocks, values between 1 and 1008 are valid per policy/fees.h;
test/functional/rpc_estimatefee.py:39:        # max value of 1008 per src/policy/fees.h
test/functional/rpc_psbt.py:604:                assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008",  # max value of 1008 per src/policy/fees.h
test/functional/wallet_basic.py:337:            assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008",  # max value of 1008 per src/policy/fees.h
test/functional/wallet_fundrawtransaction.py:851:                assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008",  # max value of 1008 per src/policy/fees.h
test/functional/wallet_send.py:315:                expect_error=(-8, "Invalid conf_target, must be between 1 and 1008"))  # max value of 1008 per src/policy/fees.h

This is fixed in this PR by running a script that searches for what he greps and replaces it with the right reference.

git grep -l "policy\/fees\.h" | xargs sed -i "s/policy\/fees.h/policy\/fees\/block_policy_estimator.h/g"

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33864.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

<!--5faf32d7da4f0f540f40219e4f7537a3-->

ACK b0a3887

A doc change and scripted-diff are pretty straightforward

ACK b0a38871546dfcdd3a578c1ae4c28a88b6ee32d5

Trivial cleanup PR. This time I did some extra code searches to find any possible leftovers, could not find one.

ACK the OP’s latest commit.

Confirmed that git grep "policy/fees.h" does not return any lines, meaning that the solution works.

git grep -l "policy/fees.h" | xargs sed -i "s/policy/fees.h/policy/fees/block_policy_estimator.h/g"

lgtm ACK b0a38871546dfcdd3a578c1ae4c28a88b6ee32d5

Thanks for the cleanup!