vcpkg.json, and there appears to be no reason to omit this configuration option when building on Windows.
cmake: Set WITH_ZMQ to ON in Windows presets
#33971
pull
hebasto
wants to merge
1
commits into
bitcoin:master
from
hebasto:251130-win-zmq
changing
3
files
+7 −5
-
hebasto commented at 1:13 pm on November 30, 2025: memberThe “zeromq” feature is already enabled by default in
-
hebasto added the label Windows on Nov 30, 2025
-
hebasto added the label Build system on Nov 30, 2025
-
DrahtBot commented at 1:13 pm on November 30, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33971.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
-
49c6728535
cmake: Set `WITH_ZMQ` to `ON` in Windows presets
The "zeromq" feature is already enabled by default in `vcpkg.json`, and there appears to be no reason to omit this configuration option when building on Windows.
-
hebasto force-pushed on Nov 30, 2025
-
DrahtBot added the label CI failed on Nov 30, 2025
-
DrahtBot removed the label CI failed on Nov 30, 2025
-
maflcko commented at 7:54 am on December 1, 2025: memberlgtm ACK 49c672853503e561cd1e7fed19a32f21ad345370
-
bitcoin deleted a comment on Dec 1, 2025
-
fanquake merged this on Dec 1, 2025
-
fanquake closed this on Dec 1, 2025
-
hebasto deleted the branch on Dec 1, 2025
Labels
Windows
Build system
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-01 21:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-01 21:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me