The "zeromq" feature is already enabled by default in vcpkg.json, and there appears to be no reason to omit this configuration option when building on Windows.
cmake: Set `WITH_ZMQ` to `ON` in Windows presets #33971
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:251130-win-zmq changing 3 files +7 −5-
hebasto commented at 1:13 PM on November 30, 2025: member
- hebasto added the label Windows on Nov 30, 2025
- hebasto added the label Build system on Nov 30, 2025
-
DrahtBot commented at 1:13 PM on November 30, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33971.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
49c6728535
cmake: Set `WITH_ZMQ` to `ON` in Windows presets
The "zeromq" feature is already enabled by default in `vcpkg.json`, and there appears to be no reason to omit this configuration option when building on Windows.
- hebasto force-pushed on Nov 30, 2025
- DrahtBot added the label CI failed on Nov 30, 2025
- DrahtBot removed the label CI failed on Nov 30, 2025
-
maflcko commented at 7:54 AM on December 1, 2025: member
lgtm ACK 49c672853503e561cd1e7fed19a32f21ad345370
- bitcoin deleted a comment on Dec 1, 2025
- fanquake merged this on Dec 1, 2025
- fanquake closed this on Dec 1, 2025
- hebasto deleted the branch on Dec 1, 2025
- alexanderwiederin referenced this in commit 7334556a3f on Dec 1, 2025
- stringintech referenced this in commit b7c3ec1af3 on Dec 12, 2025
- stickies-v referenced this in commit 9fa736f8e4 on Jan 22, 2026
-
fdtwd8vv45-sketch commented at 2:07 PM on January 26, 2026: none
Test
Contributors
Labels