build: Prevent system header fallback and include path pollution

hebasto commented at 10:17 pm on December 23, 2025: member

Currently, header-only dependencies in the depends subsystem are installed into the standard include/ subdirectory. This inadvertently exposes their headers to the compiler via -I flags brought in by other dependencies (e.g., libevent or sqlite). This “include path pollution” masks missing dependencies in the build configuration. While the build might succeed by accident due to this overlap, it creates a fragile state. If the overlapping library is removed, the build will break, or, worse, the compiler may silently fall back to the host system’s default paths (e.g., /usr/include).

This PR improves build system security and hygiene by enforcing strict, distinguished include paths for header-only dependencies. The missing dependencies revealed by this change (Boost::headers, USDT::headers) have been fixed in separate commits.

hebasto added the label Bug on Dec 23, 2025

hebasto added the label Build system on Dec 23, 2025

DrahtBot commented at 10:17 pm on December 23, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34143.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	theuni

If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#34411 ([POC] Full Libevent removal by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

maflcko added the label DrahtBot Guix build requested on Dec 24, 2025

DrahtBot commented at 2:33 pm on December 26, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit d861c3820528fad2e17a45549bec70b6ba434dcc(master)	commit fc47676ef267d8cb38ce370b7c8cfe846c0e4e0e(pull/34143/merge)
*-aarch64-linux-gnu-debug.tar.gz	`f9d3466be61a6744...`	`aa205a142b3e0679...`
*-aarch64-linux-gnu.tar.gz	`eeba55f49bb0cea8...`	`1f63f2ac82a3a9d6...`
*-arm-linux-gnueabihf-debug.tar.gz	`377cb91a664d226d...`	`7382c420ee6d9afa...`
*-arm-linux-gnueabihf.tar.gz	`e9439c9e75940962...`	`f1d7d1df4e0b27e1...`
*-arm64-apple-darwin-codesigning.tar.gz	`e24ade4558599abc...`	`36db4b587b2a1f80...`
*-arm64-apple-darwin-unsigned.tar.gz	`139e5c93b62e6bd9...`	`8a2c8c8c4ddecd97...`
*-arm64-apple-darwin-unsigned.zip	`7938b4588c399d57...`	`7601a21a0eb3b5ea...`
*-powerpc64-linux-gnu-debug.tar.gz	`c673cfd562f48b6b...`	`c5cf337561643c15...`
*-powerpc64-linux-gnu.tar.gz	`6089f3e1aeaff9f2...`	`f0e69970d9148f61...`
*-riscv64-linux-gnu-debug.tar.gz	`81def88068aa605d...`	`e0bcdda86d024735...`
*-riscv64-linux-gnu.tar.gz	`ca77e2eeff5a7997...`	`1b276f8d8b508587...`
*-x86_64-apple-darwin-codesigning.tar.gz	`0c79942deef08bb4...`	`4445c35eabc5a5c0...`
*-x86_64-apple-darwin-unsigned.tar.gz	`6f6a22f4292aa086...`	`7e9725da2a01d31e...`
*-x86_64-apple-darwin-unsigned.zip	`9bd50bc5b804299f...`	`cd302fca0fe6acf5...`
*-x86_64-linux-gnu-debug.tar.gz	`a6f0a158b31947a7...`	`8832ff496bdef1c0...`
*-x86_64-linux-gnu.tar.gz	`152bfb79e73d6c5c...`	`c314349c64f3b42f...`
*.tar.gz	`11c03cf932f54c54...`	`42bd5bfa5f3c093d...`
SHA256SUMS.part	`1d1e22a8c246fe3b...`	`5d7796eab94e93f7...`
guix_build.log	`ec31c8f59d97cbaa...`	`97ab9e864bd8a123...`
guix_build.log.diff		`08e07a75cde5ff16...`

DrahtBot removed the label DrahtBot Guix build requested on Dec 26, 2025

janb84 commented at 3:21 pm on December 28, 2025: contributor

my Guix Build Output

Host architecture: aarch64 Commit: 2a6901529c73

 05eb1bd5a15708f4270eebbbb8f9e7f7f431da2c8d69603826f47ac18e58b31fd  guix-build-2a6901529c73/output/aarch64-linux-gnu/SHA256SUMS.part
 1b46120b21bacb54cb999a7ee34906203b74a82a7a797adfaf5160ffe39df179f  guix-build-2a6901529c73/output/aarch64-linux-gnu/bitcoin-2a6901529c73-aarch64-linux-gnu-debug.tar.gz
 28d0ab4938c9b3dab75d0a3c75b97aca6ed35644fcdd42eedd95b5b6152892285  guix-build-2a6901529c73/output/aarch64-linux-gnu/bitcoin-2a6901529c73-aarch64-linux-gnu.tar.gz
 3d61e0f3bdb67fb09bd95f9457f2e4fa5949b88045a21ec5519291ee6bea77051  guix-build-2a6901529c73/output/arm-linux-gnueabihf/SHA256SUMS.part
 4b0b1ded64d6f62e4e42fd24e8429a616d372b3d1302a041f73737b2593588558  guix-build-2a6901529c73/output/arm-linux-gnueabihf/bitcoin-2a6901529c73-arm-linux-gnueabihf-debug.tar.gz
 5004b14d5513ce82262cc9510401714a97af37522eff3481a0d70db581f06cd3c  guix-build-2a6901529c73/output/arm-linux-gnueabihf/bitcoin-2a6901529c73-arm-linux-gnueabihf.tar.gz
 69dad3b1374d23171fa400dc286551ee61ac188bec14d576a038ed6de1820fd1a  guix-build-2a6901529c73/output/arm64-apple-darwin/SHA256SUMS.part
 7e101af1b0fd333d5e498da19278b00d844e44f14e46678804577124bd1d9eaef  guix-build-2a6901529c73/output/arm64-apple-darwin/bitcoin-2a6901529c73-arm64-apple-darwin-codesigning.tar.gz
 8b21d7e342bf3e3dbf4a30b547d0eab4c5482e6c48cafc7e52ed6ce84f274f771  guix-build-2a6901529c73/output/arm64-apple-darwin/bitcoin-2a6901529c73-arm64-apple-darwin-unsigned.tar.gz
 957fe0760877802005946963d87c3a6b5849f3d03fd7ad412b2c55f345d0af163  guix-build-2a6901529c73/output/arm64-apple-darwin/bitcoin-2a6901529c73-arm64-apple-darwin-unsigned.zip
107f074c95551f7bbf9f23a85f0ad46aebf9a6069f17e3c89230257ae96b107338  guix-build-2a6901529c73/output/dist-archive/bitcoin-2a6901529c73.tar.gz
11920dc7d726be94004b3003b7d0d1e7ac59ce1fe64275cc42712bb1fa63737e8d  guix-build-2a6901529c73/output/powerpc64-linux-gnu/SHA256SUMS.part
12d3f6f76cc2df64b263612224efdbc5cda29960d939ed7fef56fdb2547618f23e  guix-build-2a6901529c73/output/powerpc64-linux-gnu/bitcoin-2a6901529c73-powerpc64-linux-gnu-debug.tar.gz
130970e286347486e9fef88f15e2409911d09fbbf2cf1d52e8a06a4cc247923e48  guix-build-2a6901529c73/output/powerpc64-linux-gnu/bitcoin-2a6901529c73-powerpc64-linux-gnu.tar.gz
141a9b469909c685d46aeea0668dff6f532570154e4f8abe7224d94c92ef28d1c5  guix-build-2a6901529c73/output/riscv64-linux-gnu/SHA256SUMS.part
15c5a49c68ae6346d1510b497c483e25b04c1aac22f4b9580a15efb80c5590a3cb  guix-build-2a6901529c73/output/riscv64-linux-gnu/bitcoin-2a6901529c73-riscv64-linux-gnu-debug.tar.gz
162bd07c73dc5a13ee33d27db52d903a7f4a71fac45db7b636c37b02c6d3fb4b5f  guix-build-2a6901529c73/output/riscv64-linux-gnu/bitcoin-2a6901529c73-riscv64-linux-gnu.tar.gz
1755b3a2b6258cb645547eb01c3ef46fcd97d4cb27ca8dd84c9c9a91ea1314cf81  guix-build-2a6901529c73/output/x86_64-apple-darwin/SHA256SUMS.part
188e52dc444786c392ac6010b6bb2c8d2536d8da4731a4ef87f211af548bf9dced  guix-build-2a6901529c73/output/x86_64-apple-darwin/bitcoin-2a6901529c73-x86_64-apple-darwin-codesigning.tar.gz
19373ceed73edcc41a343d2bce9b3f6d36634ca873b5d53959464f89435417f585  guix-build-2a6901529c73/output/x86_64-apple-darwin/bitcoin-2a6901529c73-x86_64-apple-darwin-unsigned.tar.gz
2080e3980143fd4d5d8728e660ff01d029c1a8aab69f9718decd0b2149e287d88d  guix-build-2a6901529c73/output/x86_64-apple-darwin/bitcoin-2a6901529c73-x86_64-apple-darwin-unsigned.zip
21392c4d7911daf946bbf913ee27975bfda37693a992ca61794018e39c2fbad68f  guix-build-2a6901529c73/output/x86_64-linux-gnu/SHA256SUMS.part
226bc8ce0727114c65006e98392795d255ed74e2f7a2ebf9ea7518c369fe577fe3  guix-build-2a6901529c73/output/x86_64-linux-gnu/bitcoin-2a6901529c73-x86_64-linux-gnu-debug.tar.gz
2395207f982880b179ec329efd8f0c8cee89868874953d7c8125c2fde44c1edf0f  guix-build-2a6901529c73/output/x86_64-linux-gnu/bitcoin-2a6901529c73-x86_64-linux-gnu.tar.gz
24e269e1eae037b5c76f168945566c44d0695398f287ca6b131f789591ec88462c  guix-build-2a6901529c73/output/x86_64-w64-mingw32/SHA256SUMS.part
2565961e3ab4f98f24db751802a58e1bb1640d956f3b0ae5ee081cef4a8fe897f4  guix-build-2a6901529c73/output/x86_64-w64-mingw32/bitcoin-2a6901529c73-win64-codesigning.tar.gz
26928be5ef461640e856bb9ded3e40a2e8ef131beb8423aa930f43cec34a50a973  guix-build-2a6901529c73/output/x86_64-w64-mingw32/bitcoin-2a6901529c73-win64-debug.zip
275521ed52afad02466930117496741114e7c62792bac25fc707869711c4a115c8  guix-build-2a6901529c73/output/x86_64-w64-mingw32/bitcoin-2a6901529c73-win64-setup-unsigned.exe
28adc5553e1a162662ef668093dba297874a075ddb04992c9f15b58e4fe2131e43  guix-build-2a6901529c73/output/x86_64-w64-mingw32/bitcoin-2a6901529c73-win64-unsigned.zip

theuni commented at 6:03 pm on January 20, 2026: member

Nice. Concept ACK to moving, but I’d like to explore something else before making this boost-specific.

Ideally, all packages would be installed to their own prefix so that no two include dirs are the same. As-is, we could (using your example) run into the same conflict between libevent and sqlite.

The reason depends uses a common prefix by default is that some depends packages depend on other depends packages (the qt/x11 ones, for example).

Since those are the exception rather than the rule, perhaps in the future it would be worth switching to per-package prefixes, and requiring the deps to specify dependent package prefixes where necessary.

For CMake packages, which is most these days (including boost), I wonder if we could do something like this instead:

 0diff --git a/depends/funcs.mk b/depends/funcs.mk
 1index 60e7889a4ec..921464b37ba 100644
 2--- a/depends/funcs.mk
 3+++ b/depends/funcs.mk
 4@@ -223,6 +223,7 @@ $(1)_cmake=env CC="$$($(1)_cc)" \
 5                -DCMAKE_NM=`which $$($(1)_nm)` \
 6                -DCMAKE_RANLIB=`which $$($(1)_ranlib)` \
 7                -DCMAKE_INSTALL_LIBDIR=lib/ \
 8+               -DCMAKE_INSTALL_INCLUDEDIR=$(1)/include \
 9                -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
10                -DCMAKE_VERBOSE_MAKEFILE:BOOL=$(V) \
11                -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY:BOOL=TRUE \

That way the package is still found in the depends root prefix, but each cmake dep gets its own include path.

A quick test shows that this works for boost but it’s broken for zmq (doesn’t find the includedir), libevent (doesn’t install to the includedir), and libmultiprocess (not sure what the problem is there). Am I missing something, or are all of those really misbehaving?

hebasto commented at 12:29 pm on January 21, 2026: member

For CMake packages, which is most these days (including boost), I wonder if we could do something like this instead:
 0diff --git a/depends/funcs.mk b/depends/funcs.mk
 1index 60e7889a4ec..921464b37ba 100644
 2--- a/depends/funcs.mk
 3+++ b/depends/funcs.mk
 4@@ -223,6 +223,7 @@ $(1)_cmake=env CC="$$($(1)_cc)" \
 5                -DCMAKE_NM=`which $$($(1)_nm)` \
 6                -DCMAKE_RANLIB=`which $$($(1)_ranlib)` \
 7                -DCMAKE_INSTALL_LIBDIR=lib/ \
 8+               -DCMAKE_INSTALL_INCLUDEDIR=$(1)/include \
 9                -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
10                -DCMAKE_VERBOSE_MAKEFILE:BOOL=$(V) \
11                -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY:BOOL=TRUE \
That way the package is still found in the depends root prefix, but each cmake dep gets its own include path.

A quick test shows that this works for boost but it’s broken for zmq (doesn’t find the includedir), libevent (doesn’t install to the includedir), and libmultiprocess (not sure what the problem is there). Am I missing something, or are all of those really misbehaving?

This approach seems fragile to me, as CMAKE_INSTALL_INCLUDEDIR is defined in the GNUInstallDirs module, which might not be used by every package. For instance, it was introduced to libevent only in https://github.com/libevent/libevent/pull/1397.

Regarding libzmq, a fix for the bug has been proposed in https://github.com/zeromq/libzmq/pull/4832.

theuni commented at 5:09 pm on January 21, 2026: member

Ok, thanks for confirming.

FWIW, this does seem like the right thing for us to be doing, but apparently with CMake it’s unlikely that a custom CMAKE_INSTALL_INCLUDEDIR will be respected for a majority of dependencies, so I agree that it’s probably not worth the hassle of setting it for all packages.

As an alternative, according to their docs, Boost explicitly supports building with CMAKE_INSTALL_INCLUDEDIR. Specifying that would be more explicit about what’s happening here, as opposed to using the versioned layout which just happens to do what we want. Any reason not to use that for the boost build and set it to a depends-specific subdir instead?

Either way, please add a comment about why we’re setting the var.

theuni commented at 5:10 pm on January 21, 2026: member

Also, nice work on the fix for zmq :)

cmake: Add missed `Boost::headers` 35048d1f00

depends: Prefix include path for headers-only `boost` package 78a60df4e2

cmake: Add missed `USDT::headers` 9ce2a1d925

depends: Prefix include path for headers-only `systemtap` package 29214919fa

hebasto renamed this:
~~build: Switch to "versioned" install layout for `boost` package and add missed `Boost::headers`~~
build: Prevent system header fallback and include path pollution
on Jan 21, 2026

hebasto commented at 10:39 pm on January 21, 2026: member

@theuni

Thank you for the review! Your feedback has been addressed.

Additionally, I applied the same approach to the systemtap package and fixed the related missing dependency.

The PR description has been updated.

hebasto force-pushed on Jan 21, 2026

theuni commented at 4:02 pm on January 22, 2026: member

Grr, the systemtap issue kinda reinforces my point about using CMAKE_INSTALL_INCLUDEDIR. Thinking about it more, it’d be nice to set that, fix (and upstream) the packages where it’s broken, and ignore the ones where it’s non-functional.

What do you think about:

Carrying the zmq patch
Fixing libmultiprocess/capnp (it’s not clear to me where the issue lies)
Setting CMAKE_INSTALL_INCLUDEDIR globally?

Seems to me: worst case (like our libevent version) it’s simply ignored, some cases it’s broken so we fix and upstream, best case it actually catches things. Assuming carrying any necessary patches is trivial enough, I don’t really see any downside?

theuni commented at 9:23 pm on January 22, 2026: member

Ugh, there are actually several libmultiprocess issues.

First, capnproto needs a fix:

 0diff --git a/c++/src/capnp/CMakeLists.txt b/c++/src/capnp/CMakeLists.txt
 1index 9980fde6..8b93617e 100644
 2--- a/c++/src/capnp/CMakeLists.txt
 3+++ b/c++/src/capnp/CMakeLists.txt
 4@@ -71,3 +71,3 @@ target_include_directories(capnp INTERFACE
 5   $<BUILD_INTERFACE:${PARENT_DIR}>
 6-  $<INSTALL_INTERFACE:include>
 7+  $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
 8 )
 9diff --git a/c++/src/kj/CMakeLists.txt b/c++/src/kj/CMakeLists.txt
10index 48c49b74..bf30b00b 100644
11--- a/c++/src/kj/CMakeLists.txt
12+++ b/c++/src/kj/CMakeLists.txt
13@@ -91,3 +91,3 @@ target_include_directories(kj PUBLIC
14   $<BUILD_INTERFACE:${PARENT_DIR}>
15-  $<INSTALL_INTERFACE:include>
16+  $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
17 )

Then, for some reason (I suspect I’m missing something else in capnproto), libmultiprocess still needs help finding them..

 0diff --git a/src/ipc/libmultiprocess/CMakeLists.txt b/src/ipc/libmultiprocess/CMakeLists.txt
 1index a36023b1810..89351deaecd 100644
 2--- a/src/ipc/libmultiprocess/CMakeLists.txt
 3+++ b/src/ipc/libmultiprocess/CMakeLists.txt
 4@@ -144,3 +144,4 @@ target_include_directories(mputil PRIVATE
 5   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
 6-  $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/include>)
 7+  $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/include>
 8+  $<BUILD_INTERFACE:${CAPNP_INCLUDE_DIRECTORY}>)
 9 target_link_libraries(mputil PUBLIC CapnProto::kj)
10@@ -184,2 +185,3 @@ target_include_directories(multiprocess PUBLIC
11   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
12+  $<BUILD_INTERFACE:${CAPNP_INCLUDE_DIRECTORY}>
13   $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)

THEN, there’s the issue of mpgen hard-coding capnproto include paths and not respecting CAPNP_EXECUTABLE/CAPNPC_CXX_EXECUTABLE.

I do think those things are worth fixing, but there’s no need for that to get in the way of the other fixes.

theuni approved

theuni commented at 9:24 pm on January 22, 2026: member

utACK 29214919fa03b31e65c651c8b0061f6dfc05f4b2

hebasto commented at 10:50 pm on January 22, 2026: member

Ugh, there are actually several libmultiprocess issues.

cc @ryanofsky

hebasto commented at 3:35 pm on January 25, 2026: member

My Guix build:

 0$ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1x86_64
 200edb8bb6e51e78b33fb11fdcdf9b2f45c4c14fa8f7ffa1268a5bf4053fa07a5  guix-build-29214919fa03/output/aarch64-linux-gnu/SHA256SUMS.part
 30a552b9e4c7ba85ecdf25f078e3fa6ba8dd6329ba9d8e14986ca172e39da3c5d  guix-build-29214919fa03/output/aarch64-linux-gnu/bitcoin-29214919fa03-aarch64-linux-gnu-debug.tar.gz
 42b95b3f8d096a61a0d8aca91ceb23f215ff19b18d69402806dfe856ac66ae20d  guix-build-29214919fa03/output/aarch64-linux-gnu/bitcoin-29214919fa03-aarch64-linux-gnu.tar.gz
 5efd64763669cc57e7e28a9c101ac2b87f9dff9b3d527985870672c142ffb72ef  guix-build-29214919fa03/output/arm-linux-gnueabihf/SHA256SUMS.part
 652adf5c3a7b121f940af71609c3934b2b458538ac9ce4f467aca01222463861f  guix-build-29214919fa03/output/arm-linux-gnueabihf/bitcoin-29214919fa03-arm-linux-gnueabihf-debug.tar.gz
 7f01545f641da70335d648a451aff49ca20743ba0ab9c90dc071bb268517cc494  guix-build-29214919fa03/output/arm-linux-gnueabihf/bitcoin-29214919fa03-arm-linux-gnueabihf.tar.gz
 88d0c103124e1de45a20ab9bccb5f6e472cf66b75754f693f1d7048b09badc9ef  guix-build-29214919fa03/output/arm64-apple-darwin/SHA256SUMS.part
 90905f370b495568ac12aad2b23aabbaa066aa0cf21db1f2ba8ec5d4604e57370  guix-build-29214919fa03/output/arm64-apple-darwin/bitcoin-29214919fa03-arm64-apple-darwin-codesigning.tar.gz
10014e516279b4f44115b050ea8e680fadf998e0e7f17996300df2739e6e005524  guix-build-29214919fa03/output/arm64-apple-darwin/bitcoin-29214919fa03-arm64-apple-darwin-unsigned.tar.gz
117b0b8960049861848e6c6d3e047c3b16aa9f8746b58a24286db94c5732cb28c6  guix-build-29214919fa03/output/arm64-apple-darwin/bitcoin-29214919fa03-arm64-apple-darwin-unsigned.zip
12e6f09db4402fd396e1247006d7e1e3eb014f32f8d7ea92ae7dfa6e656b64e2c8  guix-build-29214919fa03/output/dist-archive/bitcoin-29214919fa03.tar.gz
131247c558e878d061674289fe64ce5f6caa5104b4c7076493895ac8217a198ef5  guix-build-29214919fa03/output/powerpc64-linux-gnu/SHA256SUMS.part
14879a4bb92073c1b379fd68e84811cb3d8eed75b393a5d34b090ea317fa1a1b44  guix-build-29214919fa03/output/powerpc64-linux-gnu/bitcoin-29214919fa03-powerpc64-linux-gnu-debug.tar.gz
15174545a07eb9abecb6d86e2acc5547d52cc6ae1561300536ee9f0d88b092bf4e  guix-build-29214919fa03/output/powerpc64-linux-gnu/bitcoin-29214919fa03-powerpc64-linux-gnu.tar.gz
16fed409926b48e18f0b430dcdf92e908c69210deccc1f9502c7f0228eb369223d  guix-build-29214919fa03/output/riscv64-linux-gnu/SHA256SUMS.part
17592ea33e41adc0d28600703b911e05135c3dd22512f0c0f2f4703d0a060b13cd  guix-build-29214919fa03/output/riscv64-linux-gnu/bitcoin-29214919fa03-riscv64-linux-gnu-debug.tar.gz
1843b0d5a08957fa2c7bc7190ce4720b8b228a4104d9adddc30aa34f8de12ffe2f  guix-build-29214919fa03/output/riscv64-linux-gnu/bitcoin-29214919fa03-riscv64-linux-gnu.tar.gz
191cd29f87eb9233e19a67f65f8d1025f897b7b8a0c9a9d2972e5903b66a8aec3d  guix-build-29214919fa03/output/x86_64-apple-darwin/SHA256SUMS.part
20515e4a37184426d9f1bc4b47f714a73e7b276fc61813d93bd1c787925704735d  guix-build-29214919fa03/output/x86_64-apple-darwin/bitcoin-29214919fa03-x86_64-apple-darwin-codesigning.tar.gz
21b42186929bcbe6fa178cae8205902aa880b7e96b92e1b7f5c28466e998e666f3  guix-build-29214919fa03/output/x86_64-apple-darwin/bitcoin-29214919fa03-x86_64-apple-darwin-unsigned.tar.gz
22dea2dad5d055fd9b827b4aa37f7d9eb7d19993331967fe0d0024acee86bd77f2  guix-build-29214919fa03/output/x86_64-apple-darwin/bitcoin-29214919fa03-x86_64-apple-darwin-unsigned.zip
2374d5847668219c17618805416dcf28cf3200388f9e91b08d30de3670e9f3dd23  guix-build-29214919fa03/output/x86_64-linux-gnu/SHA256SUMS.part
24ac0d537d45aa5459ab6ca5ba6583da1540f87b8d38a0b5bf68e055316b41aef7  guix-build-29214919fa03/output/x86_64-linux-gnu/bitcoin-29214919fa03-x86_64-linux-gnu-debug.tar.gz
25734d88f2cb29f0cc54cc6ccd8ee6246d5ec9030eee0f5cfaa5b715fe5c2c064e  guix-build-29214919fa03/output/x86_64-linux-gnu/bitcoin-29214919fa03-x86_64-linux-gnu.tar.gz
26e2340ccd2838455955ff4396ac2b63738727d6354a75b31bab3f115cf4ffb748  guix-build-29214919fa03/output/x86_64-w64-mingw32/SHA256SUMS.part
276bb522e50ddf922cc2ae457fa683189a5c86e212fd541df4f830cd7ca3a49cc5  guix-build-29214919fa03/output/x86_64-w64-mingw32/bitcoin-29214919fa03-win64-codesigning.tar.gz
28a6b12c9d9a1e548ce4c8532e30644b4a4fa43c9d97457af8ad26aedd34c718e2  guix-build-29214919fa03/output/x86_64-w64-mingw32/bitcoin-29214919fa03-win64-debug.zip
29122eb2f3debb9bed5ff9b14ec3c02a8f4394a45351735f85555822d0d9c79aeb  guix-build-29214919fa03/output/x86_64-w64-mingw32/bitcoin-29214919fa03-win64-setup-unsigned.exe
30fca881a9d2a4b60e8467c17b15d030ce02497698db43ecb0204cbd5f4814be0d  guix-build-29214919fa03/output/x86_64-w64-mingw32/bitcoin-29214919fa03-win64-unsigned.zip

build: Prevent system header fallback and include path pollution #34143

Code Coverage & Benchmarks

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]