[30.2] Backports & Final #34229

pull fanquake wants to merge 6 commits into bitcoin:30.x from fanquake:30_2_final changing 11 files +93 −43
  1. fanquake commented at 10:25 am on January 8, 2026: member

    Backports:

  2. test: migration, avoid backup name mismatch in default_wallet_failure
    The test calls migrate_and_get_rpc(), which sets mock time internally.
    The caller caches a mock time value and later relies on it to predict the
    backup filename, so setting the mock time again could cause a naming
    mismatch.
    
    Fix this by calling the migration RPC directly. Since the test expects the
    migration to fail, migrate_and_get_rpc() is unnecessary here.
    
    Github-Pull: #34221
    Rebased-From: cbf0bd35bbf312f3b13d92d281d7112e4b43b9c3
    9e59047a7e
  3. DrahtBot added the label Backport on Jan 8, 2026
  4. DrahtBot commented at 10:25 am on January 8, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34229.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, willcl-ark, marcofleon
    Stale ACK furszy

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • Bitcoin Core daemon version v30.2.0 bitcoind -> Bitcoin Core daemon bitcoind version v30.2.0 [current phrasing is awkward and can be confusing; reordering clarifies that “bitcoind” is the daemon name]

    2026-01-09

  5. fanquake added this to the milestone 30.2 on Jan 8, 2026
  6. furszy commented at 11:08 pm on January 8, 2026: member
    ACK 4606741e782fcf921049ef25ec6075caf4046be2
  7. davidgumberg commented at 0:29 am on January 9, 2026: contributor
    #34226 should probably be backported as well, this adds test cases for the relative path issue which existed before #34156.
  8. wallet: test: Failed migration cleanup
    Refactor a common way to perform the failed migration test that exists
    for default wallets, and add relative-path wallets and absolute-path
    wallets.
    
    Github-Pull: #34226
    Rebased-From: eeaf28dbe0e09819ab0e95bb7762b29536bdeef6
    1dae0027cd
  9. fanquake force-pushed on Jan 9, 2026
  10. guix: Fix `osslsigncode` tests
    Github-Pull: #34227
    Rebased-From: 194114daf385a5db50e1507fda79a1a93240d494
    6d86b32e78
  11. doc: update release notes for v30.2 6c98d68be1
  12. build: bump version to v30.2 ed355b8f57
  13. doc: update manual pages for v30.2 04a996b1a7
  14. fanquake force-pushed on Jan 9, 2026
  15. fanquake marked this as ready for review on Jan 9, 2026
  16. hebasto approved
  17. hebasto commented at 11:32 am on January 9, 2026: member
    ACK 04a996b1a77b5e4c73df27540eca0e1f6587c56e, I have reviewed the code and it looks OK.
  18. DrahtBot requested review from furszy on Jan 9, 2026
  19. willcl-ark approved
  20. willcl-ark commented at 11:37 am on January 9, 2026: member

    ACK 04a996b1a77b5e4c73df27540eca0e1f6587c56e

    Backports are clean and in release notes.

  21. marcofleon approved
  22. marcofleon commented at 11:50 am on January 9, 2026: contributor
    ACK 04a996b1a77b5e4c73df27540eca0e1f6587c56e
  23. fanquake renamed this:
    [30.x] Backports & Final
    [30.2] Backports & Final
    on Jan 9, 2026
  24. fanquake merged this on Jan 9, 2026
  25. fanquake closed this on Jan 9, 2026

  26. fanquake deleted the branch on Jan 9, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-01-10 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me