test: Check that interrupt results in EXIT_SUCCESS #34241

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2601-init-zero changing 1 files +27 −21

maflcko commented at 4:30 PM on January 9, 2026: member

This is a test for #34224. The test can be tested by reverting that pull request and observing the test failure.

Also, includes a small test cleanup/refactor.
DrahtBot renamed this:
~~test: Check that interrupt results in EXIT_SUCCESS~~
test: Check that interrupt results in EXIT_SUCCESS
on Jan 9, 2026
DrahtBot added the label Tests on Jan 9, 2026
DrahtBot commented at 4:30 PM on January 9, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34241.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK janb84, sedited

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
DrahtBot added the label CI failed on Jan 9, 2026

Type	Reviewers
ACK	janb84, sedited

fanquake commented at 5:57 PM on January 9, 2026: member

https://github.com/bitcoin/bitcoin/actions/runs/20858499232/job/59931634182?pr=34241#step:8:4476:

 test  2026-01-09T17:12:46.225024Z TestFramework (ERROR): Unexpected exception 
                                   Traceback (most recent call last):
                                     File "/home/runner/work/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 142, in main
                                       self.run_test()
                                     File "/home/runner/work/bitcoin/bitcoin/ci_build/test/functional/feature_init.py", line 300, in run_test
                                       self.init_stress_test_interrupt()
                                     File "/home/runner/work/bitcoin/bitcoin/ci_build/test/functional/feature_init.py", line 93, in init_stress_test_interrupt
                                       sigterm_node()
                                     File "/home/runner/work/bitcoin/bitcoin/ci_build/test/functional/feature_init.py", line 56, in sigterm_node
                                       assert_equal(0, node.process.wait())
                                     File "/home/runner/work/bitcoin/bitcoin/test/functional/test_framework/util.py", line 80, in assert_equal
                                       raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
                                   AssertionError: not(0 == 1)
 test  2026-01-09T17:12:46.226511Z TestFramework (DEBUG): Closing down network thread

maflcko commented at 11:54 AM on January 10, 2026: member
Nice. Everything works as expected:
- Test-each-commit CI fails before the fix is applied.
- Windows CI passes.
I'll rebase once the fix is merged.
maflcko marked this as ready for review on Jan 14, 2026

test: Split large init_stress_test into two smaller functions

This refactor can be reviewed with:
--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

This split makes the code easier to read, modify, and understand.

fab7c7f56c

test: Check that interrupt results in EXIT_SUCCESS fa16b275fa
maflcko force-pushed on Jan 14, 2026
DrahtBot removed the label CI failed on Jan 14, 2026
janb84 commented at 1:07 PM on February 5, 2026: contributor

ACK fa16b275fa94f66067c94fb8d0854859df6953b8

Simple test addition to prevent #34224 regression. Code review looks good, test succeeds on master, fails if #34224 is reverted. LGTM.
sedited approved
sedited commented at 12:58 PM on February 9, 2026: contributor

ACK fa16b275fa94f66067c94fb8d0854859df6953b8
sedited merged this on Feb 9, 2026
sedited closed this on Feb 9, 2026
maflcko deleted the branch on Feb 9, 2026

Contributors

Labels

Linked (view graph)

#34224 init: Return EXIT_SUCCESS on interrupt

test: Check that interrupt results in EXIT_SUCCESS #34241

Code Coverage & Benchmarks

Reviews