guix: stop passing depends sources to codesigning #34309

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:codesigning_no_source changing 1 files +0 −12
  1. fanquake commented at 3:58 PM on January 15, 2026: member

    I think this is just a copy-pasta from the build container (which has existed since this file was introduced in 38eb91eb0616ed6dbe34c23e11588d130fef07f8). I don't see why we'd need the depends sources available when performing codesigning.

  2. guix: stop passing depends sources to codesigning
    I think this is just a copy-pasta from the build container. I don't see
    why we'd need the depends sources available when performing codesigning.
    d94d7b1a4b
  3. DrahtBot added the label Build system on Jan 15, 2026
  4. DrahtBot commented at 3:59 PM on January 15, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34309.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, willcl-ark, sedited

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. DrahtBot added the label CI failed on Jan 15, 2026
  6. DrahtBot removed the label CI failed on Jan 16, 2026
  7. hebasto approved
  8. hebasto commented at 4:03 PM on January 16, 2026: member

    ACK d94d7b1a4b70cc93296c19fd221f8b8ac8ab90ee, I have reviewed the code and it looks OK.

  9. fanquake requested review from theuni on Jan 20, 2026
  10. willcl-ark approved
  11. willcl-ark commented at 10:25 AM on January 22, 2026: member

    ACK d94d7b1a4b70cc93296c19fd221f8b8ac8ab90ee

  12. sedited approved
  13. sedited commented at 4:07 PM on January 22, 2026: contributor

    tACK d94d7b1a4b70cc93296c19fd221f8b8ac8ab90ee

  14. sedited merged this on Jan 22, 2026
  15. sedited closed this on Jan 22, 2026

  16. fanquake deleted the branch on Jan 22, 2026


theuni


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me